From patchwork Mon Oct 24 11:26:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8994 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp439884wru; Mon, 24 Oct 2022 06:03:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4w7NEmFMU4pJspx/qmKjeZTCAizx+kSPmvCs3bMFhmvUcnDLbpiTscVfTVCOIqXqGa7NL7 X-Received: by 2002:a63:8942:0:b0:46e:c02e:2eaf with SMTP id v63-20020a638942000000b0046ec02e2eafmr13968553pgd.394.1666616608309; Mon, 24 Oct 2022 06:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666616608; cv=none; d=google.com; s=arc-20160816; b=bfFuRE1RyO+cILjDHFlo/XrVVG6KFLhbgDA1NpJazXmKSyo6zfrGjcSXREKlbP4yAX m2rUrWuCjBh7bT3ik5LPG2jfhpLeW1RoIIGPZ75q05ZZcG6vail5Ak07MvCXPBdwrTvU oLE/x41anceOhCYxAnCdfmpxBfDn+JnbWiWGW0zT5i5b3RluvhGjm/IakxVBl4l/cHYR wcYiB5lH4myPb9KJO7kIoPMSKc40oo+6CZHKP8tuyPPoVfw61v+SS/eTmnxUoszKelk3 ElyCOidFUHyOxZ11nllOLRGTuLKHYeMQuORqC6HbYUbT00iym73giQK3u4c+JjGsLZT7 yatg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hqD9q0SdEqLRnVrN/9eUBaqCBBbZLCZidD/IzlXqgXo=; b=qnoM9D/i2MXnjilRH/V0yUSWc0dzkhcI2kntte79RDo3/LlBQYp3RcP+TE2CjoNavZ CQkBYvHoBIuXRrWAnoufMQnJG6N1rfj0amToUTfyc9vwiI9EYZpcQvNRNQTjm/peDrJL Y/aOxZ0+6pGIpM+h1EOaoJOIA58/V77iuI8RSsMfK1S+IuQEyJMDJ1S2DzdbLdvMhIXd nTvwHKpfGIrxNHKlWqbmUaivsaWZq94CU2cjQUJXYXWwM6rBdEi4hM1TIHFFXe6NykD0 CRhVwQabBW4xSDWhoffzOF6TBWkueJAAyHDNjqsmlXVnM/vtQRikzoecpaNyGaKC8xj6 2kVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LACqWbE7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ob2-20020a17090b390200b002131cee8cd2si2436567pjb.10.2022.10.24.06.02.27; Mon, 24 Oct 2022 06:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LACqWbE7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235149AbiJXNBs (ORCPT + 99 others); Mon, 24 Oct 2022 09:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235050AbiJXM7M (ORCPT ); Mon, 24 Oct 2022 08:59:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC739A9D1; Mon, 24 Oct 2022 05:18:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D2C36612B3; Mon, 24 Oct 2022 12:16:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0B15C433C1; Mon, 24 Oct 2022 12:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613797; bh=C7Sw+F0psfsIdMKZyZ8pozfOSTUPYIlLKRPvT+MdUd0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LACqWbE78aNVxDQDSBDXmox7MqlSfbOIxSELlbmdQwdXi5kuWemUOAT07l5O4dXuP jos2vB7XoU+IsCcm/f+f7KbQMiEVRVv8RP4GrJxAsAjmWXpKS0xY43A7ff5w4bDqWy aZmp2bQ7oIhB0yqXYhRnoKKqqLjpYlCwtutSaLBU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Callum Osmotherly , Takashi Iwai Subject: [PATCH 5.10 005/390] ALSA: hda/realtek: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 Date: Mon, 24 Oct 2022 13:26:42 +0200 Message-Id: <20221024113022.766721768@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747574176923188231?= X-GMAIL-MSGID: =?utf-8?q?1747574176923188231?= From: Callum Osmotherly commit 417b9c51f59734d852e47252476fadc293ad994a upstream. After some feedback from users with Dell Precision 5530 machines, this patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK. While it improved the speaker output quality, it caused the headphone jack to have an audible "pop" sound when power saving was toggled. Fixes: 1885ff13d4c4 ("ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5530 laptop") Signed-off-by: Callum Osmotherly Cc: Link: https://lore.kernel.org/r/Yz0uyN1zwZhnyRD6@piranha Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8774,7 +8774,6 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB), - SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),