From patchwork Mon Oct 24 11:32:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8985 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp439188wru; Mon, 24 Oct 2022 06:02:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4IDdMMpWgvKBZcIZiBx8v1KG3Y5BH7fMUjXRa9n1isyPN2HSs8WOGOpfUJ1ibnByw5B77M X-Received: by 2002:a63:4507:0:b0:43c:9cf4:f1d6 with SMTP id s7-20020a634507000000b0043c9cf4f1d6mr28925826pga.316.1666616541407; Mon, 24 Oct 2022 06:02:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666616541; cv=none; d=google.com; s=arc-20160816; b=fGpeiuot7EF8Zr2BSltxlr8Q/CuWwK5EqfL/q01G3lnvZ4WYMomTRUzCtYTNu3KaWZ aPyiJrnJA75Swb9pYETv/HV8gxchL7cy/tT/TY0v/QGd1UwIh7oSwsnVCX4HRTMB/dvw tCumhgWujOYONGR5ph+U0PMGrqDpSLr5OinBrAOcNvXM9UuJRDEbVb/W6r8WubBpJYzs gf3d2N2rMkPtwVVhPSowXTlchaAKRDs9YyjKmxje8g9ORTweeWpfIK5EUaF8P5CkzpKD 8owh+KCvAcH6UNw8erA9yy1V7EM+jd+gE6BiuyNop1q5QC24rh0AGMSbMs/k4wJUNhJG w+lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pGMHBgq/x11kaps4EyzckQEw08t4uTzmnp5Kgnxj0jU=; b=0zgZ9vylrrRKc7yB+vzfkM27zaeJPYZJJTrqzLMCpt3M7vhNkSy/trMtx/Dav8136S Y2g/M0Gmvg5dDh17KhrrL5He1sRrktUyk4wDsuWy7GNL/7OPr3wGokPoGMwr553nQG9A arNAHTQPBz2MZtEvT0h5MEwyU01TCwgOpa235PZUpd3ZeY+4LXXMXnFss0YovMrEsL+V DisutgaW3IhocNMHVsIeeeW3+DsZPaakk3Vm2dpvKnwXP3/JKqlAJGvm9q0joPUf0byA fsFsVPtAxlOVYJfvLhZjDlmAddJalifNdXTwDpVMLN15PsqL6Gg7YY1oHssL3FlRqraI AXvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dxVH7Ne8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 2-20020a630d42000000b0045a8a6b75fesi33791334pgn.499.2022.10.24.06.01.48; Mon, 24 Oct 2022 06:02:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dxVH7Ne8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235060AbiJXNBN (ORCPT + 99 others); Mon, 24 Oct 2022 09:01:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234979AbiJXM7E (ORCPT ); Mon, 24 Oct 2022 08:59:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72E709938C; Mon, 24 Oct 2022 05:17:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54423612A0; Mon, 24 Oct 2022 12:15:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67CF2C433D6; Mon, 24 Oct 2022 12:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613739; bh=QR3O8uBGc8eFe5nbi7RUEstzEsOIsXyPelHp6Zn1iTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dxVH7Ne8WvT78ALfv5lTlAiK85dySVsHB8C9t9NqG2l8w5yPk27UJzEOWVM6TtWte Zb+yibEJGcJTpou4ltEs1++AIdy/f6FG2TBNZj0V2EcDPOKX+4p40/aJbZK0j+1tfW xBQEs/MUNlFbbqYjYqwfPKcKcCLwUbWJKbpsaUYA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot , Tetsuo Handa , Alexander Aring , Stefan Schmidt , Sasha Levin Subject: [PATCH 5.4 250/255] net/ieee802154: dont warn zero-sized raw_sendmsg() Date: Mon, 24 Oct 2022 13:32:40 +0200 Message-Id: <20221024113011.611161417@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747574106738535650?= X-GMAIL-MSGID: =?utf-8?q?1747574106738535650?= From: Tetsuo Handa [ Upstream commit b12e924a2f5b960373459c8f8a514f887adf5cac ] syzbot is hitting skb_assert_len() warning at __dev_queue_xmit() [1], for PF_IEEE802154 socket's zero-sized raw_sendmsg() request is hitting __dev_queue_xmit() with skb->len == 0. Since PF_IEEE802154 socket's zero-sized raw_sendmsg() request was able to return 0, don't call __dev_queue_xmit() if packet length is 0. ---------- #include #include int main(int argc, char *argv[]) { struct sockaddr_in addr = { .sin_family = AF_INET, .sin_addr.s_addr = htonl(INADDR_LOOPBACK) }; struct iovec iov = { }; struct msghdr hdr = { .msg_name = &addr, .msg_namelen = sizeof(addr), .msg_iov = &iov, .msg_iovlen = 1 }; sendmsg(socket(PF_IEEE802154, SOCK_RAW, 0), &hdr, 0); return 0; } ---------- Note that this might be a sign that commit fd1894224407c484 ("bpf: Don't redirect packets with invalid pkt_len") should be reverted, for skb->len == 0 was acceptable for at least PF_IEEE802154 socket. Link: https://syzkaller.appspot.com/bug?extid=5ea725c25d06fb9114c4 [1] Reported-by: syzbot Fixes: fd1894224407c484 ("bpf: Don't redirect packets with invalid pkt_len") Signed-off-by: Tetsuo Handa Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20221005014750.3685555-2-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- net/ieee802154/socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c index a92b11999e5f..6d6c28581770 100644 --- a/net/ieee802154/socket.c +++ b/net/ieee802154/socket.c @@ -273,6 +273,10 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) err = -EMSGSIZE; goto out_dev; } + if (!size) { + err = 0; + goto out_dev; + } hlen = LL_RESERVED_SPACE(dev); tlen = dev->needed_tailroom;