From patchwork Mon Oct 24 11:32:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8981 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp438778wru; Mon, 24 Oct 2022 06:01:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7cHurPC2KCajmAzbFonSes35yk65P6woQQZBAQR05qyiDz9e21i0gfEVn8TM0yAanJxU4Q X-Received: by 2002:a05:6a00:22cc:b0:56b:f793:5ab2 with SMTP id f12-20020a056a0022cc00b0056bf7935ab2mr2065521pfj.3.1666616507007; Mon, 24 Oct 2022 06:01:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666616507; cv=none; d=google.com; s=arc-20160816; b=Cntv2xFV6JyKdppvHb+IDBH3AhjDvlBEwQy2PPJ5wq4zYlUeZiYKUKwrT+w2lrTkr/ z2zyDZGjlVKLqObWaNfKgOG1LEkgk2zNI1fFvzZ4u2MitJCiOuQUaFp3P7qLut3igCCP Y0vQFlKMpVHSPJn3E+nJDVEUVkcOW0fi29O/9Ve0pTVH5PMDmVKGrKFDvtscnpp/BlHz IlqbKtAJUtDw2uRyxBPda0yEw8VGPy7IwxyTIYoA8KhJulY/iJ2m9GVjbLU57vUjEMuN yJEKVqG++y1ycK8nBa9eCnpnrTnzUBuyHyM/oagmfWsvW/GEkdpPE7Gx5AilBm12CxsN iERg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5P7OA4B75wnBVFRAjCvIgkQqC+x3HUTAZ2cBg5af3nU=; b=N05PvQMjuoVbsExiZQ40AyYykK1VzBL877YRDSBUIsGnWVXiRaK4sxwCy9zI/cLioC A6uJXSGnNt26w15tyRoO96YZY6E5Df8/epxjxyyaeM9FlUy9fxvhHTqclvEzds2mqhO5 tG4F+Asx2zE193pvlfiHBeevSy05UK5TcRsaYISXhTsafmyIFCTueygNS4+R1QRSuHGl pj9epjB+bez1doIqgpoJ+OfBvWKyoXDwciGff/cdYu/QIvV1HoH5QULDmLMOXHG+htow QX9anz6A64wQ3uZFl5T5roJG70zTGxBhPFPLytSBrGzJw2AV3Dn7TswCPDTh9kiF7UAf JVWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dbA2uNCQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i3-20020a6551c3000000b0046b2ea05986si31579049pgq.63.2022.10.24.06.01.16; Mon, 24 Oct 2022 06:01:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dbA2uNCQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234899AbiJXNAj (ORCPT + 99 others); Mon, 24 Oct 2022 09:00:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234900AbiJXM6f (ORCPT ); Mon, 24 Oct 2022 08:58:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB7CE80F42; Mon, 24 Oct 2022 05:17:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FE1A61313; Mon, 24 Oct 2022 12:14:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A26B3C433D6; Mon, 24 Oct 2022 12:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613698; bh=D8ozL383GaaeAGtKQvIA9IdpVRSMEvGm6dPoBfIkAio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dbA2uNCQnV4h5HCOXnGkYLN/8Qb2xwnK99Pz6bY0LrLT31slTajDaLOOKic7kUjku bXDOiVY/PMxtlvnGpx1zpNV0fngK8kNB8xXBPkve+35FO2905MkNS40uOgM7W+ZqRr ND/XZHwhbUB2ksA29AoctX8I/KKNPdcDJ73siquo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hyunwoo Kim , Jiri Kosina , Sasha Levin Subject: [PATCH 5.4 236/255] HID: roccat: Fix use-after-free in roccat_read() Date: Mon, 24 Oct 2022 13:32:26 +0200 Message-Id: <20221024113011.053440968@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747574070402823294?= X-GMAIL-MSGID: =?utf-8?q?1747574070402823294?= From: Hyunwoo Kim [ Upstream commit cacdb14b1c8d3804a3a7d31773bc7569837b71a4 ] roccat_report_event() is responsible for registering roccat-related reports in struct roccat_device. int roccat_report_event(int minor, u8 const *data) { struct roccat_device *device; struct roccat_reader *reader; struct roccat_report *report; uint8_t *new_value; device = devices[minor]; new_value = kmemdup(data, device->report_size, GFP_ATOMIC); if (!new_value) return -ENOMEM; report = &device->cbuf[device->cbuf_end]; /* passing NULL is safe */ kfree(report->value); ... The registered report is stored in the struct roccat_device member "struct roccat_report cbuf[ROCCAT_CBUF_SIZE];". If more reports are received than the "ROCCAT_CBUF_SIZE" value, kfree() the saved report from cbuf[0] and allocates a new reprot. Since there is no lock when this kfree() is performed, kfree() can be performed even while reading the saved report. static ssize_t roccat_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) { struct roccat_reader *reader = file->private_data; struct roccat_device *device = reader->device; struct roccat_report *report; ssize_t retval = 0, len; DECLARE_WAITQUEUE(wait, current); mutex_lock(&device->cbuf_lock); ... report = &device->cbuf[reader->cbuf_start]; /* * If report is larger than requested amount of data, rest of report * is lost! */ len = device->report_size > count ? count : device->report_size; if (copy_to_user(buffer, report->value, len)) { retval = -EFAULT; goto exit_unlock; } ... The roccat_read() function receives the device->cbuf report and delivers it to the user through copy_to_user(). If the N+ROCCAT_CBUF_SIZE th report is received while copying of the Nth report->value is in progress, the pointer that copy_to_user() is working on is kfree()ed and UAF read may occur. (race condition) Since the device node of this driver does not set separate permissions, this is not a security vulnerability, but because it is used for requesting screen display of profile or dpi settings, a user using the roccat device can apply udev to this device node or There is a possibility to use it by giving. Signed-off-by: Hyunwoo Kim Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-roccat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/hid-roccat.c b/drivers/hid/hid-roccat.c index 26373b82fe81..6da80e442fdd 100644 --- a/drivers/hid/hid-roccat.c +++ b/drivers/hid/hid-roccat.c @@ -257,6 +257,8 @@ int roccat_report_event(int minor, u8 const *data) if (!new_value) return -ENOMEM; + mutex_lock(&device->cbuf_lock); + report = &device->cbuf[device->cbuf_end]; /* passing NULL is safe */ @@ -276,6 +278,8 @@ int roccat_report_event(int minor, u8 const *data) reader->cbuf_start = (reader->cbuf_start + 1) % ROCCAT_CBUF_SIZE; } + mutex_unlock(&device->cbuf_lock); + wake_up_interruptible(&device->wait); return 0; }