From patchwork Mon Oct 24 11:32:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9699 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp544357wru; Mon, 24 Oct 2022 09:31:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7gLnlk7oqV08TvSjDHfvphUTqvp7T3ToeaYhPx3yodIDR4/gEPquq/jn3HfQLzZf0l9v6l X-Received: by 2002:a05:6402:2319:b0:45c:4231:de18 with SMTP id l25-20020a056402231900b0045c4231de18mr32398172eda.383.1666629112637; Mon, 24 Oct 2022 09:31:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666629112; cv=none; d=google.com; s=arc-20160816; b=s47dalD0lQ73k2cztmMNs7y3TF6fDCh1VVumjlPB2S0WujoOAFQ1v6Q+ONb/HeDSv7 5bqXzD6XhTITnCZGBO6wM3LoZBDeJpvovbSluv/LgvD0M4CBABD7VYejATqeRifXq6Hd dZryFUFJ7Oi6cYjV/t0kGWDFSMm9bI5zOvWG4buRRffk+j/hNULrAufyW+DD5Cguc7+e DhfkkGq0D8kU88qTDO0cSnohQCjK5HNOWvcOMZO1LaN8+OJHobD/eacejslab5SWzEn/ MdKwqZ8UeG/I7HUemA86GMt1Vh8W3Te2er9CZ4aXP2s1wVU4QmLgMtoWlJrAM31cOf04 bO6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HKWcpNGSz/qO9umKP5O4jo5RzD6s32hka6dtmUVAbiY=; b=Hfg6OHzzlF+pgdCoo/IBpht644hgghaefuP6MnNolmLL+BMmKeR1HPPUkXVAnTDOUw dyl1k+mb5qB0pKfe8A9gpeB1cABePA1WAjTpRO5hRFUvtdDBc55lmSVEYm/JUzqandae dhkq5KDdoeBPdEWALq2LWHhVs+1wGn4FfWxN/qwelC7shQFBWoquNgaJpZQMpAgQUBSy NkLrDqeuc85HRkaV1vaPkjdUEXiy2xJUKnXBXbHr/IsHqWq1ChSal69gbXaliryDK555 tOCvkgQTLdUHkLx7F3i6G9lBSjPM3jKtp5Sps4GNtQ3YwdrDONBo5YcVrrkk+sceM8mg dOrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tAXq7kOK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020a170906378200b00781ea213f99si151459ejc.173.2022.10.24.09.31.28; Mon, 24 Oct 2022 09:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tAXq7kOK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234230AbiJXQRJ (ORCPT + 99 others); Mon, 24 Oct 2022 12:17:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234838AbiJXQPR (ORCPT ); Mon, 24 Oct 2022 12:15:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 294696110A; Mon, 24 Oct 2022 08:03:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 31003B81616; Mon, 24 Oct 2022 12:14:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86355C433C1; Mon, 24 Oct 2022 12:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613650; bh=VyRbyK2ww2404bbaV+nZGsh7aEeNQVyazO8tGuaL5hY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tAXq7kOKkAymH9RElguko6EA2AdxGtCj529TX+aBWSwhR90JbH+HA/+Pw8henBENc 8Mqf7LE1fGW0jVsp6GQ9b33/cXjkIB88rB3vidqpMFDj7zgfr7/xez3aQ6vA7jDs6D hhN/Cmh0Q8WqHwYpZXrRURgRiorVx4E7eH+XFw1Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Sasha Levin Subject: [PATCH 5.4 216/255] platform/x86: msi-laptop: Change DMI match / alias strings to fix module autoloading Date: Mon, 24 Oct 2022 13:32:06 +0200 Message-Id: <20221024113010.243527543@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747587288300829506?= X-GMAIL-MSGID: =?utf-8?q?1747587288300829506?= From: Hans de Goede [ Upstream commit 2a2565272a3628e45d61625e36ef17af7af4e3de ] On a MSI S270 with Fedora 37 x86_64 / systemd-251.4 the module does not properly autoload. This is likely caused by issues with how systemd-udevd handles the single quote char (') which is part of the sys_vendor / chassis_vendor strings on this laptop. As a workaround remove the single quote char + everything behind it from the sys_vendor + chassis_vendor matches. This fixes the module not autoloading. Link: https://github.com/systemd/systemd/issues/24715 Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20220917210407.647432-1-hdegoede@redhat.com Signed-off-by: Sasha Levin --- drivers/platform/x86/msi-laptop.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c index 3e935303b143..0e804b6c2d24 100644 --- a/drivers/platform/x86/msi-laptop.c +++ b/drivers/platform/x86/msi-laptop.c @@ -596,11 +596,10 @@ static const struct dmi_system_id msi_dmi_table[] __initconst = { { .ident = "MSI S270", .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "MICRO-STAR INT'L CO.,LTD"), + DMI_MATCH(DMI_SYS_VENDOR, "MICRO-STAR INT"), DMI_MATCH(DMI_PRODUCT_NAME, "MS-1013"), DMI_MATCH(DMI_PRODUCT_VERSION, "0131"), - DMI_MATCH(DMI_CHASSIS_VENDOR, - "MICRO-STAR INT'L CO.,LTD") + DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-STAR INT") }, .driver_data = &quirk_old_ec_model, .callback = dmi_check_cb @@ -633,8 +632,7 @@ static const struct dmi_system_id msi_dmi_table[] __initconst = { DMI_MATCH(DMI_SYS_VENDOR, "NOTEBOOK"), DMI_MATCH(DMI_PRODUCT_NAME, "SAM2000"), DMI_MATCH(DMI_PRODUCT_VERSION, "0131"), - DMI_MATCH(DMI_CHASSIS_VENDOR, - "MICRO-STAR INT'L CO.,LTD") + DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-STAR INT") }, .driver_data = &quirk_old_ec_model, .callback = dmi_check_cb