From patchwork Mon Oct 24 11:31:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8949 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp435757wru; Mon, 24 Oct 2022 05:55:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4zYqNQeFWxSHDVxxLlwVtsNNuu/LlP8iuEZT2cGnhhkd1VYanA6l57fiQs5TjewTkwWyi+ X-Received: by 2002:a63:804a:0:b0:461:25fe:e7c5 with SMTP id j71-20020a63804a000000b0046125fee7c5mr28625652pgd.395.1666616124529; Mon, 24 Oct 2022 05:55:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666616124; cv=none; d=google.com; s=arc-20160816; b=KjIvdi1IpBI4URME100Ntr7bUaObTSvGTMuD1gksL1UfOtiNDZlA8URlpmWUQq9LFJ 2dSFRt/kB/omDfLm1fPJVvlCoKVIeHzQPJ/oWYKoOI6BCJvhEJUVEnVryV9gV3PvhmF3 e/znB4FNimg0XdevpRSvl8xGpjN+tqwVT+7pKPt2rsGU1ElGLNWoEJ2iJu0tiSkerTek qhsk+7d+MfQIjF9x6uNi4I6nlUSpg+dBBhLmzUTKvLDvcs4sIOW5YdH6A3/EPlUaTL6/ 7aepocYCvS7xaE6ejcqdqBTEyszue2d15s9SiEcB0M5cqxXx7cL/FLQci7E5MD9n3Iig oW7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZeJTlCQ0Nrcjnw8GslUTJRF9NOEJ2QmtO/YwA20Sq/Y=; b=eOuT4o+QM17qFhm7sruI4SXCriBpgg7vXtM7I007HSdba5bQH2WiKlSZR/GOZYnWHl BnJJiNmXM5WNQU6KGMvVOBeJV9zl7c26YaMa/kgqwLTlaNhKSW2aEZQA9wqgFrSs5hu8 yGE2tlbq00ery3E20I/MYK1f6MtG9qQCXzo13psXEJamEeHXAAmw/v9z10Xp10af844S NhIyhqzOcEL3X4i/l2y8Op4o0eISrvkJeI8+pLqzZTg2QLQaXxuQeWBpVN1bvrSlE5un 4wSjHGfOTQPtJdYiisnadzKKO/KpfMDYwjThTWCBg2JvKhUiOKbsqF55dCBuunxNZ+Cu dV4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Epd8wVYd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p2-20020a170902b08200b001747ed48ee8si30666297plr.150.2022.10.24.05.55.12; Mon, 24 Oct 2022 05:55:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Epd8wVYd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234539AbiJXMxM (ORCPT + 99 others); Mon, 24 Oct 2022 08:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234529AbiJXMvg (ORCPT ); Mon, 24 Oct 2022 08:51:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE112101C2; Mon, 24 Oct 2022 05:13:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AABD8612FE; Mon, 24 Oct 2022 12:12:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD8F9C433C1; Mon, 24 Oct 2022 12:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613529; bh=QbdfTwb918X465SnDLFPDScYTGIArpwH5oy7h7MXV6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Epd8wVYdZAH4ZD2mICilEUKvz51CoGKyG9A7BF9fGGiR7DCGFna4mhOy12HZlzr2h nxYb/Z/t86K0x0NeaFH3xt+lh3+f8gNPpFjTxskcT4oJNzDrRuc7mcjWZPbhmm1kas tbNZcngOTQhJjBXyc+qr+PAFuH0xuodvm/7eN1g0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Michael Ellerman , Tyrel Datwyler , Sasha Levin , Miaoqian Lin Subject: [PATCH 5.4 172/255] powerpc/pci_dn: Add missing of_node_put() Date: Mon, 24 Oct 2022 13:31:22 +0200 Message-Id: <20221024113008.507791202@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747573669578794435?= X-GMAIL-MSGID: =?utf-8?q?1747573669578794435?= From: Liang He [ Upstream commit 110a1fcb6c4d55144d8179983a475f17a1d6f832 ] In pci_add_device_node_info(), use of_node_put() to drop the reference to 'parent' returned by of_get_parent() to keep refcount balance. Fixes: cca87d303c85 ("powerpc/pci: Refactor pci_dn") Co-authored-by: Miaoqian Lin Signed-off-by: Liang He Signed-off-by: Michael Ellerman Reviewed-by: Tyrel Datwyler Link: https://lore.kernel.org/r/20220701131750.240170-1-windhl@126.com Signed-off-by: Sasha Levin --- arch/powerpc/kernel/pci_dn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/pci_dn.c b/arch/powerpc/kernel/pci_dn.c index d876eda92609..d28433f0fc8e 100644 --- a/arch/powerpc/kernel/pci_dn.c +++ b/arch/powerpc/kernel/pci_dn.c @@ -325,6 +325,7 @@ struct pci_dn *pci_add_device_node_info(struct pci_controller *hose, INIT_LIST_HEAD(&pdn->list); parent = of_get_parent(dn); pdn->parent = parent ? PCI_DN(parent) : NULL; + of_node_put(parent); if (pdn->parent) list_add_tail(&pdn->list, &pdn->parent->child_list);