From patchwork Mon Oct 24 11:31:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8948 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp435753wru; Mon, 24 Oct 2022 05:55:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4dLCekgeuwRm6i8yG05n5Sv2F4QiU4xmGjh6/hm++8i5KefYQOKKKFRq4HTRoOWP9xwY8q X-Received: by 2002:a17:906:8457:b0:78d:b793:5511 with SMTP id e23-20020a170906845700b0078db7935511mr27198878ejy.393.1666616124414; Mon, 24 Oct 2022 05:55:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666616124; cv=none; d=google.com; s=arc-20160816; b=abDuOLux++WPFTHtW9E53FvgtRYFUPdk6vS+fpa9HFasrVU+mPqZbQgtGBrdrudK9A ES4BP3kxNBWaJ4hRK4+3QbmApX3KQ7ECqtAZR0NnV9QbJRCIbD9h/X2ogdhCPMaLkR4X +RPEmuJxC7Gr5fG77AFYI1+OrFWx1pDfYKBPZLiq9oNTp/wv8CKV5jX+a+Prhkq3XHKd 4hMaM2KDgy9BiwMUp7P1XREreI4GjeNAp+uDfY5mRHNk1Exdxeg93+KUpb1cWlSNy39o ZsTjv2aoe+LZBTyNgmpfc8HQa1t8KSCnPuqpiRE1vXbhnRO0GS770suN5XEsjIE4kU1F uldQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RROoPqgo4uYddrnJLfWkSH89+kTVk+4o2wIEmEt3e/w=; b=TaR6ZgcaR5PLNi44d0x5gU6KYTc+Lw86ET5b2qex/ZKUvlKWe78/dhAD6kk9RkN5bV MLJyhQuPIuUUcnfLnP2U5OWN3a4rgtdLgChquemFBfGuqs6HuECG0uLE1dwg8Ambfb2S 1Ab6d/MSSqnkPPTu3/+qz3ORTYFAgASJUgGDbfNNduTbd8jNBBjOCOPzH0IR97QDffuj 3st03/xwyA1xHYUXyrB3m3aS77/wRNJbakdtcFJqHbV/hREv0Uk3j1S0GtO5wdY2UuKD TjFs1POaRJfD0ewnIQ7U5eQha2jHoGGzmyL37RBtag7lJ0B+V+d+S0oIn8H9vke9xVV2 zHqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=03qMsOTR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb26-20020a1709077e9a00b0078db3762061si29424938ejc.439.2022.10.24.05.54.54; Mon, 24 Oct 2022 05:55:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=03qMsOTR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234525AbiJXMxG (ORCPT + 99 others); Mon, 24 Oct 2022 08:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232141AbiJXMtq (ORCPT ); Mon, 24 Oct 2022 08:49:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6767192CD3; Mon, 24 Oct 2022 05:13:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1747F612FD; Mon, 24 Oct 2022 12:12:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 289F1C433C1; Mon, 24 Oct 2022 12:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613526; bh=FpXhnLqOG5Yvh/g9j3Y6llbNQVhcq7oq+QMST9zMdbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=03qMsOTRmFwz9bX+tXVaifosibJDbKfkCCexCDT4anMrjo/SwoylqRXhfLhDKQ94j 1m/QC98NV8K9vxgeYInBB+NUPM5OidU1ZPEhDuIw2zDAHEqr3HOdpPS9GUW/35KWiw iICDHHQX3e9HxQ9RPi8QGlqG5qIPnzpdXJb68rnE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Michael Ellerman , Sasha Levin , Miaoqian Lin Subject: [PATCH 5.4 171/255] powerpc/sysdev/fsl_msi: Add missing of_node_put() Date: Mon, 24 Oct 2022 13:31:21 +0200 Message-Id: <20221024113008.469549959@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747573668855645016?= X-GMAIL-MSGID: =?utf-8?q?1747573668855645016?= From: Liang He [ Upstream commit def435c04ee984a5f9ed2711b2bfe946936c6a21 ] In fsl_setup_msi_irqs(), use of_node_put() to drop the reference returned by of_parse_phandle(). Fixes: 895d603f945ba ("powerpc/fsl_msi: add support for the fsl, msi property in PCI nodes") Co-authored-by: Miaoqian Lin Signed-off-by: Liang He Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20220704145233.278539-1-windhl@126.com Signed-off-by: Sasha Levin --- arch/powerpc/sysdev/fsl_msi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c index 808e7118abfc..d276c5e96445 100644 --- a/arch/powerpc/sysdev/fsl_msi.c +++ b/arch/powerpc/sysdev/fsl_msi.c @@ -211,8 +211,10 @@ static int fsl_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) dev_err(&pdev->dev, "node %pOF has an invalid fsl,msi phandle %u\n", hose->dn, np->phandle); + of_node_put(np); return -EINVAL; } + of_node_put(np); } for_each_pci_msi_entry(entry, pdev) {