From patchwork Mon Oct 24 11:31:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8961 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp436595wru; Mon, 24 Oct 2022 05:57:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4s3GJ9/EP2d8AYZjz44iqpCMHP0Nyn6TBhzxZ4NR1bX4btk1eCbYasM4DB7PoGTK345bCP X-Received: by 2002:a17:902:b101:b0:186:7067:3ea3 with SMTP id q1-20020a170902b10100b0018670673ea3mr20291686plr.59.1666616259189; Mon, 24 Oct 2022 05:57:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666616259; cv=none; d=google.com; s=arc-20160816; b=c71TyZI0F2m4QSkbKpC5Z5Voi4+eiDEBU3iIgvyMM7uJUOwhn7rI7cg6INLKj6QJp3 V9IqM/X/Bq9vDYI0Eef4nhch+ShwDnkbHFQ8KHD9xS06KTIUdUc3ykezO9y0186VVPtw PKrk4dic4x0FSUQu05qqVOdvrvShthwbxixgE8XZcbg5/H2rFFE2e/J5rhH5jVAHP1uS 4HN2CztqPJ9hB0jmfny0Ty/HIjfXMXd/Umti51Ek8M2ZV4U8GLZfe6x6cPD7zOk+t5PN Aiqfb4DSF/oXRF2apEuTFKzcGxqhhaSo6rDYv33HvRFXJ/uTUM8KtC2Pkc/wkaiJDFG6 6fkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IOHSfyFD4niVyHHhM+glbmmMt/480At2Df81CEcv5Vo=; b=qksxm9JMfOTt/La4g/VHkb6uhrmWw0V2MFCvhd2edMsNXry9njBAOfsnJTEkiipVFZ OSllSm1tDAMKSWBfnCHmAqOH5Cz9laDvAGmzNQV0Hv1yfUTr/Yqrh0yUgsLg87NHY/5K 9aCYSOq37Gpd7dL6X15uGJ3DNAVyAA4FZd3ZgndJkSTmBnIMBnUqZOFMQNm5TqqWB0/T qElPh/70m021Sc4AuYwDE8jK4oNphbVPYZozmVCQOrbwn658vsraCmO/k+z0/cQ1rzT7 5pCf0td3zBa06J0Bw4lEXN+HpFdXhZY8Mn6QmjX+4v2d1+1HufQzr/raaDvQuPFOS3yT uccA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fNNkFhTi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eb19-20020a056a004c9300b00563a0453c55si30735407pfb.268.2022.10.24.05.57.25; Mon, 24 Oct 2022 05:57:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fNNkFhTi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234363AbiJXM4f (ORCPT + 99 others); Mon, 24 Oct 2022 08:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234749AbiJXM4K (ORCPT ); Mon, 24 Oct 2022 08:56:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6E8D77E84; Mon, 24 Oct 2022 05:15:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91D096127C; Mon, 24 Oct 2022 12:12:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A03C6C433D6; Mon, 24 Oct 2022 12:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613571; bh=0EsrBRhNjT/7EWbcf7qA2B5MZSx/S7gsSGue+kr9cJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fNNkFhTiWmIrJ/3BBY5IEb2d08nOoxH4VPPBHQqhHxoPNgUF29naTISpQD1uCGceX R0lL/5uUMbcTLd1Mhp1PFphuOYIrDRAebeSczbl4YWu/lMaOtXEtIxDNFol0MRvVjo 4iYx7tOrvq2VG81PmkroCaPzruFrWqfbsvVirRGg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , Hans de Goede , Lee Jones , Sasha Levin Subject: [PATCH 5.4 157/255] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Mon, 24 Oct 2022 13:31:07 +0200 Message-Id: <20221024113007.870720716@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747573810728184462?= X-GMAIL-MSGID: =?utf-8?q?1747573810728184462?= From: Christophe JAILLET [ Upstream commit 48749cabba109397b4e7dd556e85718ec0ec114d ] The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220801114211.36267-1-andriy.shevchenko@linux.intel.com Signed-off-by: Sasha Levin --- drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index c9f35378d391..4d9b2ad9b086 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -111,6 +111,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; }