From patchwork Mon Oct 24 11:30:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9012 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp441113wru; Mon, 24 Oct 2022 06:05:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5wg4TX0ox5hofKRHncdhCI5sHuFpmyJ8ihBZNPm19AnN3dM+P016pilHn2JutNhODmai/x X-Received: by 2002:a17:902:db09:b0:185:53c7:6e8e with SMTP id m9-20020a170902db0900b0018553c76e8emr33475986plx.155.1666616722817; Mon, 24 Oct 2022 06:05:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666616722; cv=none; d=google.com; s=arc-20160816; b=eyy3d2KdQtfKCKze+fOoFzC2wgZUhZLnc2EB8MTpFl5GVnAdiw+N0mL4xtQMUE/Voj heFkc+9Fdsl1m3ODoDZTDdz/GI4HABUyPC9uIZ7meLmt+WFQ9Cr1ucO+/tkbDOIZ14iX FyjfGk5gUROo5XHE5MJOlDvYrS1sV929yjyFQPnDIYUiaEO2gZgPoX4y47Gq7ryfJKOR 0Tl668wJfJWEebdfl477XjmXmeaAUPNNiUs7McJOomuRS+ndwTjMPpLl0VEtb8Q2EwfM FD7AFz8VMZl91wmOTmy1O0FNrxMkPuy6rkxNEhvTJnGB6YZe3U3kAigjUleTVGN7ibur Vuow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=G5n5fw6Ej3l5dvSD0k8+uaWWO1aSGho/BzJQ3CJVykg=; b=pw64tL9qBgxD/mDv9lIFlRqNF6tHGvKGEvD5hXkbKQPG2GlJ10rj5uF932vCVZ1ZIU dJYwDnxW6OCkIQCg5xgSWz71JNBgstnF+21RWZ07CGZ94kkvkxYbNTZhCVRwsVc/aQVX lbRRG5x4oV0ULPGUAR0tdvIjPipPdfcoxFKIDvfuQXL9zaa1EtFV3s/JqukDvWjkQCM3 d0bKnxKLhwys9gMFIGqTWro+/Qy7BmGPQpmeQ+0CF8aj0mxYK96SgqrCsOlrx98GffCl A87HMLo9xNEbHTzXXvtoDQ1TdxnCIc5p9x+ykD4SGJvdePDvkIw5FMsMSb4/h2qVAfb4 E3/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sNcue61Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t185-20020a6381c2000000b00434bfa4c2d7si1401953pgd.317.2022.10.24.06.04.54; Mon, 24 Oct 2022 06:05:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sNcue61Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235206AbiJXNDd (ORCPT + 99 others); Mon, 24 Oct 2022 09:03:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235300AbiJXM7x (ORCPT ); Mon, 24 Oct 2022 08:59:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7CEC82740; Mon, 24 Oct 2022 05:19:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4069161254; Mon, 24 Oct 2022 12:10:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57FC3C433D6; Mon, 24 Oct 2022 12:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613437; bh=aMwCiuho+5sGPWzHfvZm4UqIdHJc/Ci1aTkPE5AYjf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sNcue61QhnFAmLGaXVuBPV7YlF9qrhFdFkGKKBrPjs8qZLr08ypBkrw3S/WDjg/rk kh8UQGaOLXKcChPvjRWWVViV17MfFafDRC6+7H2Fbbtyk5wEdkT1JT0NZmU17Jfgg0 cbW9DflVZo9lmpje+o2kzpHXIBPCXYkk69+7loxM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rasmus Villemoes , Jason Baron , Daniel Vetter , Jim Cromie , Sasha Levin Subject: [PATCH 5.4 137/255] dyndbg: fix module.dyndbg handling Date: Mon, 24 Oct 2022 13:30:47 +0200 Message-Id: <20221024113007.133286024@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747574296455265095?= X-GMAIL-MSGID: =?utf-8?q?1747574296455265095?= From: Jim Cromie [ Upstream commit 85d6b66d31c35158364058ee98fb69ab5bb6a6b1 ] For CONFIG_DYNAMIC_DEBUG=N, the ddebug_dyndbg_module_param_cb() stub-fn is too permissive: bash-5.1# modprobe drm JUNKdyndbg bash-5.1# modprobe drm dyndbgJUNK [ 42.933220] dyndbg param is supported only in CONFIG_DYNAMIC_DEBUG builds [ 42.937484] ACPI: bus type drm_connector registered This caused no ill effects, because unknown parameters are either ignored by default with an "unknown parameter" warning, or ignored because dyndbg allows its no-effect use on non-dyndbg builds. But since the code has an explicit feedback message, it should be issued accurately. Fix with strcmp for exact param-name match. Fixes: b48420c1d301 dynamic_debug: make dynamic-debug work for module initialization Reported-by: Rasmus Villemoes Acked-by: Jason Baron Acked-by: Daniel Vetter Signed-off-by: Jim Cromie Link: https://lore.kernel.org/r/20220904214134.408619-3-jim.cromie@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- include/linux/dynamic_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 4cf02ecd67de..65575143c89f 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -191,7 +191,7 @@ static inline int ddebug_remove_module(const char *mod) static inline int ddebug_dyndbg_module_param_cb(char *param, char *val, const char *modname) { - if (strstr(param, "dyndbg")) { + if (!strcmp(param, "dyndbg")) { /* avoid pr_warn(), which wants pr_fmt() fully defined */ printk(KERN_WARNING "dyndbg param is supported only in " "CONFIG_DYNAMIC_DEBUG builds\n");