From patchwork Mon Oct 24 11:32:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8876 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp433249wru; Mon, 24 Oct 2022 05:48:55 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6klsoP1+sBQZ8EARdu10FZj/HN84kW7j0jgILKUt5XRsJOcBaQj16q1PSVnrFtcaf/OkWl X-Received: by 2002:a17:903:41ca:b0:186:a68e:c06d with SMTP id u10-20020a17090341ca00b00186a68ec06dmr5419047ple.61.1666615735479; Mon, 24 Oct 2022 05:48:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615735; cv=none; d=google.com; s=arc-20160816; b=TQJpXoWSYRcv9dYuRQWI8uyZ7E+L/ttkVZi+EF9BlTlVV6FCR/PzdB82Sxq/x2ModA mOamw6p/AfMbrFwAxBr1E8GFxm5VzIpYgwfYvaErWJ9XinS2WI4m39PygN6hF9v6oFOH QXoUZhue5TJtcQyhbznUr6SJp7yBLvPp7fqRQbNQNcWlEYED2pXVSRLMwhmqIhpB+o/H S5K8d8GmEynDI5JsyJ//Akd52H6dr237gPXfxV38YuAykZ58w0nQDMWN5BmL1hu2k7xt iti1lVdJe0m9XmYC9bPM1tUi9vQf8uVltuEb70a3bDV+tOukAwXKw7HsjsucvT7uhv/c g6BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=E3LFXV2vyuRDWnSXKx01IaPvG9g3EwNCRRsEgRJ1rQs=; b=FHl5w/yDJQWRaJc3/6kc9HJPMGQbHBOnokgrzvv9+JnQnqZxiAt3KmwR9opVKI3rMc rGAYDRZPRPgTQ71/23xjlYWG+mVuWucnyjb+o7bcTemRfhr9uVOoCJc0GB9CxxkWJVsJ cHLxEGEhn0ZjqqJJaVWuIV80tLooNU2ePh6aiq6eWKdxYxDuZefx74HQRMj23GhrhuRo ARPERVxMbs60O2pYDnESWfH1ehEPgwvP2dJfE+My2qm898JCaujJ7i7Lbldt6N9OY3f2 tMTZhXNVZQX4cFqZaRH8+hpja1PyrvQsVBcrvl7Etvp06GaW9VSJN8dRJ2WUNVPpu51D EaQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i1tTvQKO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l1-20020a635701000000b00438d11be245si32475731pgb.429.2022.10.24.05.48.40; Mon, 24 Oct 2022 05:48:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i1tTvQKO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbiJXMmX (ORCPT + 99 others); Mon, 24 Oct 2022 08:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234301AbiJXMjd (ORCPT ); Mon, 24 Oct 2022 08:39:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 656998A7FE; Mon, 24 Oct 2022 05:07:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 45B8D61254; Mon, 24 Oct 2022 12:04:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58C2FC433C1; Mon, 24 Oct 2022 12:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613074; bh=0+56YQKLRS3I50WR/rVpZJDlwNIJzh94dKECmtCa8lc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i1tTvQKOvkN8DBtVPbJCe9WCB3kZ3Gh2G/+xi//3IVXgFro+JAXcO/fMXqEmr32xZ Hy1h7dKQHHfYM3CCG4Hu8H+1LcXV7IsKteIOTyHaheh0t1p5yX1w+rrzLMdJ9DFXYn umXQHXD/ou/q8pi1GaafZlhN7kBz8kVEKkKzjwUk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Martin Liska , Peter Oberparleiter , Andrew Morton Subject: [PATCH 4.19 229/229] gcov: support GCC 12.1 and newer compilers Date: Mon, 24 Oct 2022 13:32:28 +0200 Message-Id: <20221024113006.684314336@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747573261565819104?= X-GMAIL-MSGID: =?utf-8?q?1747573261565819104?= From: Martin Liska commit 977ef30a7d888eeb52fb6908f99080f33e5309a8 upstream. Starting with GCC 12.1, the created .gcda format can't be read by gcov tool. There are 2 significant changes to the .gcda file format that need to be supported: a) [gcov: Use system IO buffering] (23eb66d1d46a34cb28c4acbdf8a1deb80a7c5a05) changed that all sizes in the format are in bytes and not in words (4B) b) [gcov: make profile merging smarter] (72e0c742bd01f8e7e6dcca64042b9ad7e75979de) add a new checksum to the file header. Tested with GCC 7.5, 10.4, 12.2 and the current master. Link: https://lkml.kernel.org/r/624bda92-f307-30e9-9aaa-8cc678b2dfb2@suse.cz Signed-off-by: Martin Liska Tested-by: Peter Oberparleiter Reviewed-by: Peter Oberparleiter Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- kernel/gcov/gcc_4_7.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) --- a/kernel/gcov/gcc_4_7.c +++ b/kernel/gcov/gcc_4_7.c @@ -33,6 +33,13 @@ #define GCOV_TAG_FUNCTION_LENGTH 3 +/* Since GCC 12.1 sizes are in BYTES and not in WORDS (4B). */ +#if (__GNUC__ >= 12) +#define GCOV_UNIT_SIZE 4 +#else +#define GCOV_UNIT_SIZE 1 +#endif + static struct gcov_info *gcov_info_head; /** @@ -439,12 +446,18 @@ static size_t convert_to_gcda(char *buff pos += store_gcov_u32(buffer, pos, info->version); pos += store_gcov_u32(buffer, pos, info->stamp); +#if (__GNUC__ >= 12) + /* Use zero as checksum of the compilation unit. */ + pos += store_gcov_u32(buffer, pos, 0); +#endif + for (fi_idx = 0; fi_idx < info->n_functions; fi_idx++) { fi_ptr = info->functions[fi_idx]; /* Function record. */ pos += store_gcov_u32(buffer, pos, GCOV_TAG_FUNCTION); - pos += store_gcov_u32(buffer, pos, GCOV_TAG_FUNCTION_LENGTH); + pos += store_gcov_u32(buffer, pos, + GCOV_TAG_FUNCTION_LENGTH * GCOV_UNIT_SIZE); pos += store_gcov_u32(buffer, pos, fi_ptr->ident); pos += store_gcov_u32(buffer, pos, fi_ptr->lineno_checksum); pos += store_gcov_u32(buffer, pos, fi_ptr->cfg_checksum); @@ -458,7 +471,8 @@ static size_t convert_to_gcda(char *buff /* Counter record. */ pos += store_gcov_u32(buffer, pos, GCOV_TAG_FOR_COUNTER(ct_idx)); - pos += store_gcov_u32(buffer, pos, ci_ptr->num * 2); + pos += store_gcov_u32(buffer, pos, + ci_ptr->num * 2 * GCOV_UNIT_SIZE); for (cv_idx = 0; cv_idx < ci_ptr->num; cv_idx++) { pos += store_gcov_u64(buffer, pos,