From patchwork Mon Oct 24 11:30:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10259 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp643854wru; Mon, 24 Oct 2022 13:43:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7UWx/iWKxwtR6uKPsnXKjtcIiZ5Dv0PldXctiIoqbNHmuaJuL5MDziLOL3lJCTyRnad0RE X-Received: by 2002:a63:b545:0:b0:43c:2ad9:b00 with SMTP id u5-20020a63b545000000b0043c2ad90b00mr29606008pgo.535.1666644187626; Mon, 24 Oct 2022 13:43:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666644187; cv=none; d=google.com; s=arc-20160816; b=Bsxf+1BcWK9jM6IIZ1AIe+HN9I9FVHFow7EmbvrXRqGbuGh4v+KtkUDPk/7teOfP02 x7wZMWSmUMZLpmypS3mrTe4uEhfbZqw1hgr+FcVPAUVRPb7Ju2u29JFbIOzPcMW1BDbF OYm5jPWufmBBlcK9xG+RswurIRY1EOtCD37F25tIB1iBzr0E4RSUDsfALHuCFWDK5gL5 Ad1zo2xZYo4VfbMQ6nl5gWdtYoWPMMPwE6hplgZ6vgPbzQCAtbFB1QBbbLHDnmTLqi/0 WO7mCk3jOpS+yWEXPHocW50IhK5YS3sH+msHAZJLOcivd/eyvBm84NoD6pOkNIqv6TVA 74bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P7he3boLJjoDyg4JyksFE1FjKdheQ/OWPJaEtn3/zDQ=; b=l2WfO37tqAoGeyyvEMlly7y8AdZGfn5SASgPdgUJQxY78cLAxlQ+UoeQ92Dmdy713P tVZfN889umO4dFjfP5EEzrXzB7b7/qQKHXioA+VbnoY5X63YKjsns413Q4ogXr3a/KhG h2D+1CQqmNQE5fETjE5NXcxiSooplsbTaf1ZgyTz+2XmM6gjBJLaiqHYFFFQ0lV24HfB HnRhI/zu8lNKJQHK0V9FTjgdoSvpG3Y6+x9mOC0CIiAzZGATqhtxjtSLU/MVo67Zgkkg bOrSQAk9f4TmROjxe+uQ1N61GbpIFpq66wOncjnOJkb5FOT+Mu0R4Vh55wEYCjFluyTF o1vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OhzG9GdB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x184-20020a6386c1000000b00438d7ca729bsi619190pgd.207.2022.10.24.13.42.52; Mon, 24 Oct 2022 13:43:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OhzG9GdB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234999AbiJXUmV (ORCPT + 99 others); Mon, 24 Oct 2022 16:42:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234881AbiJXUlT (ORCPT ); Mon, 24 Oct 2022 16:41:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64246114DCA; Mon, 24 Oct 2022 11:50:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0E566B815D8; Mon, 24 Oct 2022 12:11:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64583C433D6; Mon, 24 Oct 2022 12:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613484; bh=X38VWH2et6l8j7ErF92H2f0hZx1DchmzPhdw98JHFCs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OhzG9GdBMMr0oDwsstn/J/B5k5VHjVEYcXTS7Kb6eZ5cVLTpibyaIei09EPy31+X6 ocjz3jWe97dZyX+09yc0eUNQog5K0r622YUrO+8Kx4wkXJoE7v8EepMfW3vYN58sVx P8TlAGb0e6JFmOOkWKh54J9sHD42psML2NPVlmQw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Stephen Boyd , Sasha Levin Subject: [PATCH 5.4 124/255] clk: oxnas: Hold reference returned by of_get_parent() Date: Mon, 24 Oct 2022 13:30:34 +0200 Message-Id: <20221024113006.681951284@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747603095611087068?= X-GMAIL-MSGID: =?utf-8?q?1747603095611087068?= From: Liang He [ Upstream commit 1d6aa08c54cd0e005210ab8e3b1e92ede70f8a4f ] In oxnas_stdclk_probe(), we need to hold the reference returned by of_get_parent() and use it to call of_node_put() for refcount balance. Fixes: 0bbd72b4c64f ("clk: Add Oxford Semiconductor OXNAS Standard Clocks") Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220628143155.170550-1-windhl@126.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/clk-oxnas.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c index 78d5ea669fea..2fe36f579ac5 100644 --- a/drivers/clk/clk-oxnas.c +++ b/drivers/clk/clk-oxnas.c @@ -207,7 +207,7 @@ static const struct of_device_id oxnas_stdclk_dt_ids[] = { static int oxnas_stdclk_probe(struct platform_device *pdev) { - struct device_node *np = pdev->dev.of_node; + struct device_node *np = pdev->dev.of_node, *parent_np; const struct oxnas_stdclk_data *data; const struct of_device_id *id; struct regmap *regmap; @@ -219,7 +219,9 @@ static int oxnas_stdclk_probe(struct platform_device *pdev) return -ENODEV; data = id->data; - regmap = syscon_node_to_regmap(of_get_parent(np)); + parent_np = of_get_parent(np); + regmap = syscon_node_to_regmap(parent_np); + of_node_put(parent_np); if (IS_ERR(regmap)) { dev_err(&pdev->dev, "failed to have parent regmap\n"); return PTR_ERR(regmap);