From patchwork Mon Oct 24 11:32:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9158 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp457769wru; Mon, 24 Oct 2022 06:36:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4BXsrdzWkq0vVBBKGkXfWonEmhgUKWD+bH1eUjaB+WsoJKnFYrkiwoMn6ndhrm/jwgU/DQ X-Received: by 2002:a17:90b:110c:b0:205:cfeb:cfb with SMTP id gi12-20020a17090b110c00b00205cfeb0cfbmr39092554pjb.75.1666618589837; Mon, 24 Oct 2022 06:36:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618589; cv=none; d=google.com; s=arc-20160816; b=zwxCTr8MAb5L4vBAlIT+jn2rA3tZBbOKAxHHAQ6PZ8D6iGw+dhjYuCAWdj6BU8WgeX 39QE9sg+C3ifBWdAu31bxe10e6Km8u+WxRICRPdUhpRsicdRfn139HbJvsgXmrhbCB3H w7TeOXk75tyx6dd+NVaLwn+jpz0xWok58CL1fhIqy6qvjSh9ODimC0WvkkqV9ktIZun1 KapbQzGQ2etG8b2prw65DKB042ZE75Z5H3BTn/uajlgkpEuwc9TAiKGGFsjVqUhfDRiV VUDA5ehrJEeJ/Wl7SiG59hYqajpGbqDvsjOxJkK/jEyuXTzipy+YKzp7zuHhDP1uWc+k MHqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vdko9PHJXcgQzJFIVTxjnQU8/97DsQn/zeFFz0NnEMA=; b=UAHTiCUMbZ6C/cPo8YWAX2TxmmTe+yo9TY2r8c0srsm0M1s7qrESXPwby9sCu+XT2l E13Ee2UPNeag8tn+ZEsIdVoxB8sRuQMO78Y3w3PSZtYzna9OatawkCpbMa4h+V9qP6qH TJaV+YVT9n10ekySHRSRPOB1h03wYiQrM5sAL63V+6OtXhaaAw4IwCMFlcdUIhQz+1wE fpa7GViuZrAfhCqTMij9AUHxmJZN/yrh/4ldplr/EN22jrdwshkY2cmM7BeYxGsyYdYq 0pNW9bzP3+9hY44e+RzrIrffi18HnCyZ2bBUeNC1M2avocniQxXuBKXCuN8n/VVT+Zuz uL6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oi0EEdJQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j19-20020a633c13000000b0046efa6dfeaasi4922587pga.859.2022.10.24.06.36.15; Mon, 24 Oct 2022 06:36:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oi0EEdJQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235883AbiJXNRc (ORCPT + 99 others); Mon, 24 Oct 2022 09:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233113AbiJXNQw (ORCPT ); Mon, 24 Oct 2022 09:16:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02F1B537F6; Mon, 24 Oct 2022 05:26:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DFA64B81199; Mon, 24 Oct 2022 12:04:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 357A5C433D6; Mon, 24 Oct 2022 12:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613082; bh=WWkcmlAyA3f6jXwUv+XMv0JhZ1/YMiSwL+vY8mPdxkY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oi0EEdJQJJCJEVZk3tlb1xC3fYQjt+xwyNas+ac8OJ6vCk88CNJyvVj9H4DywK0sE a+MGL1ZFOQogFWwwBkG1WMQpIb2HGezlN76U5jy2AjWzqI0UNPD4cHvTjH+M2Xb6yQ da5KsBaYdyagTL2JKUXBhIrJtpk8pWLvq4VQwOcU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Maxime Ripard , Stefan Wahren , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 220/229] clk: bcm2835: Make peripheral PLLC critical Date: Mon, 24 Oct 2022 13:32:19 +0200 Message-Id: <20221024113006.365791198@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576254797743664?= X-GMAIL-MSGID: =?utf-8?q?1747576254797743664?= From: Maxime Ripard [ Upstream commit 6c5422851d8be8c7451e968fd2e6da41b6109e17 ] When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system. It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled. It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash. Reported-by: Noralf Trønnes Signed-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20220926084509.12233-1-maxime@cerno.tech Reviewed-by: Stefan Wahren Acked-by: Noralf Trønnes Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 5a2f8d5d8d7a..180abc00160d 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1737,7 +1737,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .load_mask = CM_PLLC_LOADPER, .hold_mask = CM_PLLC_HOLDPER, .fixed_divider = 1, - .flags = CLK_SET_RATE_PARENT), + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), /* * PLLD is the display PLL, used to drive DSI display panels.