From patchwork Mon Oct 24 11:32:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8817 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp431104wru; Mon, 24 Oct 2022 05:42:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4A//cIxJF+Hit4icacrjzsjcSUz7WYK3u/YbdWaQ0f8BayRwnBOgh6bHmOkLuC703yfF3c X-Received: by 2002:a17:90b:3141:b0:20d:49d6:30c with SMTP id ip1-20020a17090b314100b0020d49d6030cmr37826287pjb.175.1666615379234; Mon, 24 Oct 2022 05:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615379; cv=none; d=google.com; s=arc-20160816; b=KD2z+9Yc2WDFuKaQQRcx0xJt/I+dNo3RaFVycZjRbz9pUV5J50R3Ijouf1gKR41AuH G5Dq2SKQqPCQDh9lJPPatsCGW16mV+cD3QrwlDfqW2DaCO5AtM01heKYdddFYhFm3YGt u8okzpC1sQzyPIkgTlmPPlwR/QjTcmucSsE0VxE3M/isVVu7hCT5d2cOQm2qmMShmeR9 eFMLTcOb7vzzIdob/u1fNkbFoCujet0s58V4cFJm7tXklpZObJY5EvZ9Q3MK7yb4RjDB wbCBv1Y5TtYvtRR78iggdbeI/QEFCFUsu+uF5/BAw23dXlGL5RhPsUjgJS/0gLZlISMx 37OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=G4uk5i0+bSWrpOOfmEy9duYbhh6NtBcqcwNkOLDhaDI=; b=DIGCtz15VylBWw/v8lJay3tlinNTxBLPKlqM3oYGk8LiAtsgloNYnSnh0YISXBEcmR OMa5I5H0aCvvgz9Wa4nspsVO8meLBZJ2e37ZjAwmrhhVwH3rZTQcO7/arl4GglWbTJua MPmANr0tQFwSzrfuk4hc2+ZpTHmp/kgyIP+cU4by/x0OhhPAx4BhR1/UZQ9w5caxmfqf 5xfzdzYmQ0ZQ54qFCJSOuQmviKDozXdsvBaItZMcBKU7QlaHqLT7x3gT+wgcXI3qkXmN Iqa8KaQ+Xk7e+CjPcQfWZ6KXcO9q+A6E31u0q1HRVbaYKJ9mfUj5OgTwkHbMpSHK5u4i ktQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YbdfvEj2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c18-20020a056a000ad200b0050d80e4935fsi34330206pfl.256.2022.10.24.05.42.44; Mon, 24 Oct 2022 05:42:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YbdfvEj2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230396AbiJXMgM (ORCPT + 99 others); Mon, 24 Oct 2022 08:36:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234323AbiJXMaB (ORCPT ); Mon, 24 Oct 2022 08:30:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 545A2356EA; Mon, 24 Oct 2022 05:04:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8719361295; Mon, 24 Oct 2022 12:03:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97DDEC433C1; Mon, 24 Oct 2022 12:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613038; bh=c9KwSiNVgBXBuKA/mG8YVGWL/opA9IdLJkp3LRCodbs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YbdfvEj2ScSh0UmzMbT1QJW7K6CYLcMSa0fKiiFBbkyzMU1tbZiO8Xqt64YeUyBKz Igf9Af0s5Iqb/bkXdMhOWIFo1HarNc+rD93h6zF3+iBNV+CW4DV9CnTPtnNNM9484h MohChdSypAjREgukUwIcX3ExhvFHDQYD9iGEC9cM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hyunwoo Kim , Jiri Kosina , Sasha Levin Subject: [PATCH 4.19 213/229] HID: roccat: Fix use-after-free in roccat_read() Date: Mon, 24 Oct 2022 13:32:12 +0200 Message-Id: <20221024113006.104138122@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747572888026163546?= X-GMAIL-MSGID: =?utf-8?q?1747572888026163546?= From: Hyunwoo Kim [ Upstream commit cacdb14b1c8d3804a3a7d31773bc7569837b71a4 ] roccat_report_event() is responsible for registering roccat-related reports in struct roccat_device. int roccat_report_event(int minor, u8 const *data) { struct roccat_device *device; struct roccat_reader *reader; struct roccat_report *report; uint8_t *new_value; device = devices[minor]; new_value = kmemdup(data, device->report_size, GFP_ATOMIC); if (!new_value) return -ENOMEM; report = &device->cbuf[device->cbuf_end]; /* passing NULL is safe */ kfree(report->value); ... The registered report is stored in the struct roccat_device member "struct roccat_report cbuf[ROCCAT_CBUF_SIZE];". If more reports are received than the "ROCCAT_CBUF_SIZE" value, kfree() the saved report from cbuf[0] and allocates a new reprot. Since there is no lock when this kfree() is performed, kfree() can be performed even while reading the saved report. static ssize_t roccat_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) { struct roccat_reader *reader = file->private_data; struct roccat_device *device = reader->device; struct roccat_report *report; ssize_t retval = 0, len; DECLARE_WAITQUEUE(wait, current); mutex_lock(&device->cbuf_lock); ... report = &device->cbuf[reader->cbuf_start]; /* * If report is larger than requested amount of data, rest of report * is lost! */ len = device->report_size > count ? count : device->report_size; if (copy_to_user(buffer, report->value, len)) { retval = -EFAULT; goto exit_unlock; } ... The roccat_read() function receives the device->cbuf report and delivers it to the user through copy_to_user(). If the N+ROCCAT_CBUF_SIZE th report is received while copying of the Nth report->value is in progress, the pointer that copy_to_user() is working on is kfree()ed and UAF read may occur. (race condition) Since the device node of this driver does not set separate permissions, this is not a security vulnerability, but because it is used for requesting screen display of profile or dpi settings, a user using the roccat device can apply udev to this device node or There is a possibility to use it by giving. Signed-off-by: Hyunwoo Kim Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-roccat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/hid-roccat.c b/drivers/hid/hid-roccat.c index 5be8de70c651..c9cec00b4e6e 100644 --- a/drivers/hid/hid-roccat.c +++ b/drivers/hid/hid-roccat.c @@ -260,6 +260,8 @@ int roccat_report_event(int minor, u8 const *data) if (!new_value) return -ENOMEM; + mutex_lock(&device->cbuf_lock); + report = &device->cbuf[device->cbuf_end]; /* passing NULL is safe */ @@ -279,6 +281,8 @@ int roccat_report_event(int minor, u8 const *data) reader->cbuf_start = (reader->cbuf_start + 1) % ROCCAT_CBUF_SIZE; } + mutex_unlock(&device->cbuf_lock); + wake_up_interruptible(&device->wait); return 0; }