From patchwork Mon Oct 24 11:29:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8902 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp433949wru; Mon, 24 Oct 2022 05:50:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7titgYSZoPAIOTz+vdd/CA0mI/xsQNUTCho3wPM1i9ZIRkpUr2QaB89KylXhTTvicak67J X-Received: by 2002:a05:6402:e87:b0:456:c93c:5361 with SMTP id h7-20020a0564020e8700b00456c93c5361mr29829233eda.88.1666615857581; Mon, 24 Oct 2022 05:50:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615857; cv=none; d=google.com; s=arc-20160816; b=ygFbUg72FUms/devfyNORAlau6YqQOBk7+/xzTCoEhSMrEl2eAIrlQpUJ2Ff24YlGs RUjJEZdfBf5P3wKv/84VS4hhEpaEh3N5BQ42LY44vVYid6UJnK6qwOx1ts0C3c4kjh1h EYfrb6je+SY75exwDzFuPCcbuq8eKVTYYtuDf5fuUpsC40gwAAf+6Gqz8QBw6SVdirFC 2ZXSg1J12SrRRUKJE1xPbHD6dRPp/Nzt8yVj+SQv2RxF3y+OUL36yKb4Rvpeur4Mot68 HSKCmvSb63P0HsEHyKtoxyyrCoqU0qaJJgGiTSukarJPDjRpLiDaYla5hcRhxu1H++hu NJmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cAAvUSqZ+Bmx/V9PQbFkICxUMdOHINiHXyVaEInYbAY=; b=AoKkAZzS9mhJCOEljZYp2EQAEuNCa/SmOA7Y+4kC6mSaKleS7b4vW9l2O7WwzN1CVI Y/ZumBCc35rlU+DSBkl7wmRkY0gAXlJSDZW+zUSGNLN3isk4JCsm2zE7V0oCRPYoVeo1 bL0fChVypMVWJVZXFHDMn/mS8p+UgtOkfSVYvc59BA+jPhO2u+/rRmQ4GwmFQNIMNZ2H ucH4YDMf2JLblr+QRAaT77JnIDv4r4dh3vw4iCj/3il44LvwR55OitdKG6R/NJpoGH4F NGgy9pTHBJKt7FizTo1Q8NKZ6aAX6nBXFNDCQ97OQ6DGpkmnnDRgtp20Zt5smRQ6eWjc v0vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iui385KT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wu13-20020a170906eecd00b0078db6f5f499si31464444ejb.796.2022.10.24.05.50.31; Mon, 24 Oct 2022 05:50:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iui385KT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234491AbiJXMs6 (ORCPT + 99 others); Mon, 24 Oct 2022 08:48:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234392AbiJXMon (ORCPT ); Mon, 24 Oct 2022 08:44:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25EDDB5E; Mon, 24 Oct 2022 05:09:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 098DB612D6; Mon, 24 Oct 2022 12:07:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17C6CC43470; Mon, 24 Oct 2022 12:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613266; bh=PBbgQzVY69vYoEKwRWh1226dyBvyaJBWcFSUeNNxKVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iui385KTGhPmi7NsE4QtaIvVOZoh2l71d8G8tyRFhu0b7IsEiYwd1xEAboEOnjyoh 79U4FQiHb1wuLRJMxg/P99N+WI5sw2p7qtvuOldHBrhHxRcZhUtmUL08h/UlPiwpVs 4afDzYEL1RYS/dllQ8LFzFzsENbF0ky0lYOhyxL0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bitterblue Smith , Kalle Valo , Sasha Levin Subject: [PATCH 5.4 072/255] wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration Date: Mon, 24 Oct 2022 13:29:42 +0200 Message-Id: <20221024113004.904664709@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747573389375625170?= X-GMAIL-MSGID: =?utf-8?q?1747573389375625170?= From: Bitterblue Smith [ Upstream commit e963a19c64ac0d2f8785d36a27391abd91ac77aa ] Found by comparing with the vendor driver. Currently this affects only the RTL8192EU, which is the only gen2 chip with 2 TX paths supported by this driver. It's unclear what kind of effect the mistake had in practice, since I don't have any RTL8192EU devices to test it. Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts") Signed-off-by: Bitterblue Smith Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 977ebb647c0e..b472dc4c551e 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -2926,12 +2926,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv, } if (!(simubitmap & 0x30) && priv->tx_paths > 1) { - /* path B RX OK */ + /* path B TX OK */ for (i = 4; i < 6; i++) result[3][i] = result[c1][i]; } - if (!(simubitmap & 0x30) && priv->tx_paths > 1) { + if (!(simubitmap & 0xc0) && priv->tx_paths > 1) { /* path B RX OK */ for (i = 6; i < 8; i++) result[3][i] = result[c1][i];