From patchwork Mon Oct 24 11:31:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8877 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp433295wru; Mon, 24 Oct 2022 05:49:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7S26/hgcLVcIdLYQc1CimLrL13OIIorMKnXpkP5ZxAqE8vLBwphveZYQuhNCw1yGl8qkXQ X-Received: by 2002:a63:4282:0:b0:46e:9bac:6d9e with SMTP id p124-20020a634282000000b0046e9bac6d9emr18889826pga.334.1666615743200; Mon, 24 Oct 2022 05:49:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615743; cv=none; d=google.com; s=arc-20160816; b=yp2/1qkOjwvhVH7xKoJxq3EaYG4HYGN1aTy6ZhYXUWF5gMeMwF4RtAsZauFWdrIAOg cYyQZzrhERplUtrKn7Z7HNZUnNgNjQwkho9Wjbl+HpnahgR7Msnn5ZXqhdXX9z+Diwyg tGgaGjnhbLwHIDAj8HPh6v7o0RMp+Cm04k1x0YNO+rXqrUjJXdKMFCEql39aVbcPATwy l1bKSnkuZZnRLaWVyCzu2g5qipsKQZQCk7caGHQyi1+KYWKB5ASvmf3GOjKlWvxG1lu+ PQtDNH02T84dlH0UbEekJeXO76BENoI2uzTcAoz2Bz42NVmxI+QaX5L8JtDFUgtD+hbz RGQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WDkDKj1O7oO+OvaWK7i6FwljzBGiyQ9jC5kcyFvWEK8=; b=Mb2b7C9vBMc4r4UqVhE2Qy9+5j6WtO0epL0o7GkkrSAOolzi0UYUwKzsROhcaMBCyn 8742P5lvMImH8exYqILFFE6lgfgqx/PN6RafOGT0CUfZns2aMnwajmGdNZ7qrlTUgdOo AE6riy2vbGlWO60xWP++fVk1Pf918gEIehkfA0u0ZGMjcVA1VAnofCQpMf64i9QHF8wy fxwTYQAr8Mex9mCVdjk5jgu/SnNCmKsjbgLO6zZcFoc82QsvixMadheSREELJ0r+uPkt Kmv31DMQZWIqRgi2nJVll4TUvXQsY5FP3Rj6KonK9nEuAqhLwxaAx8LbqVGS5Q37oiK7 +K4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pISd+Wqm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a170902d38900b0018678dab04asi10122815pld.189.2022.10.24.05.48.48; Mon, 24 Oct 2022 05:49:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pISd+Wqm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234251AbiJXMmm (ORCPT + 99 others); Mon, 24 Oct 2022 08:42:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234681AbiJXMk2 (ORCPT ); Mon, 24 Oct 2022 08:40:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 717CC8C478; Mon, 24 Oct 2022 05:08:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 63C2761280; Mon, 24 Oct 2022 12:01:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7886DC433C1; Mon, 24 Oct 2022 12:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612893; bh=/1DW5WW1xl+F1DQUELEVGXcIOZpqadrzRHptiXSg1bE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pISd+WqmQlRPKoEAcQkrSMnipOd0pbNnM3QeBE5VBsLMMHl2C8w4hCkE0rLouvh0L 9dwm4vztcMHCNzDk7oCccjPT9oRZCacrkItHvpFsmAfHx3urxVDXMONj6c9b25v2Ln jV+dmjKQb86nJBKCUrFdpKt56leycrSy8KXGigKo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Michael Ellerman , Sasha Levin , Miaoqian Lin Subject: [PATCH 4.19 160/229] powerpc/sysdev/fsl_msi: Add missing of_node_put() Date: Mon, 24 Oct 2022 13:31:19 +0200 Message-Id: <20221024113004.174029483@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747573269390949952?= X-GMAIL-MSGID: =?utf-8?q?1747573269390949952?= From: Liang He [ Upstream commit def435c04ee984a5f9ed2711b2bfe946936c6a21 ] In fsl_setup_msi_irqs(), use of_node_put() to drop the reference returned by of_parse_phandle(). Fixes: 895d603f945ba ("powerpc/fsl_msi: add support for the fsl, msi property in PCI nodes") Co-authored-by: Miaoqian Lin Signed-off-by: Liang He Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20220704145233.278539-1-windhl@126.com Signed-off-by: Sasha Levin --- arch/powerpc/sysdev/fsl_msi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c index df95102e732c..44aedb6b9f55 100644 --- a/arch/powerpc/sysdev/fsl_msi.c +++ b/arch/powerpc/sysdev/fsl_msi.c @@ -216,8 +216,10 @@ static int fsl_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) dev_err(&pdev->dev, "node %pOF has an invalid fsl,msi phandle %u\n", hose->dn, np->phandle); + of_node_put(np); return -EINVAL; } + of_node_put(np); } for_each_pci_msi_entry(entry, pdev) {