From patchwork Mon Oct 24 11:29:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp433654wru; Mon, 24 Oct 2022 05:50:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4XHOBSFT/eHff+IsJqOklEXhKiVxjcy+GxLxjM6LiQSzHWm7oy9gBooeJasPn4C1aOb/2r X-Received: by 2002:a17:907:628f:b0:72f:57da:c33d with SMTP id nd15-20020a170907628f00b0072f57dac33dmr27176048ejc.374.1666615806752; Mon, 24 Oct 2022 05:50:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615806; cv=none; d=google.com; s=arc-20160816; b=IK4VGGGS8NBjVCMbMjsw+w84dUNb4ex6UsBAQkD3mnSWumwhxpfjt7S+E0A0SkgKwe 05PeE1xFj3DBRPG64bqSxywCfBwTKGMAfb7fjVQtV1fVIBS3wgFwrG2wb0r1te8ldstE PuAZT+atGZorMeqkn+xYmYVLcAFHnchs/g266nE3U/BfwXZe+pgssczk3GAXPSIFqa9H WrbxRNXJg5etPLjzAXL+S1/3vP5Vf1KSRTp7ECyfQ8fiw+EBko7hbrZZIYc7LnztUcp5 y5Mxv/qmChLUWjk2maDit37RuL+/RE84lAwmkHGNBEmT5Ctrq+58eZID1o7ZksZoGC7k p5kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xYI14rWA1yANQLUVHEUXbqAAPR8TAypk4vrznp5QGzc=; b=DaOdHcC6OQBtccR5+KOzWaHGrjMQcLXdwqk6bbAzK73B97M9U7c3RB192dMsAKGrhz XeZafw7pjgro7fHmdprCFNnbmDAbBzKEdDKHoqYTTbZQNtpKKn8oCkp75lrXkwPlgp+V Or/ApPPpsta2lxUdnhYQdScbttfTKklApmjyNBcyHtoNUF67oXah6DQr0ACih0vGM21I OmykSE7FK+qssRX1cj/GEmgUWDrXmC+se3jq34Zd8ob+6yZw1E+5i+7LDjrU+rwUHcCi eGu+YGr64Dc7za1QaJvuAhQ3CugxEqvQYl11ZMYZ8hsIT5NqQ8qYacXT8u/ltD8aEb/K Nhiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WTNzZ5uF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fk23-20020a056402399700b004608b4f28b7si11831670edb.106.2022.10.24.05.49.41; Mon, 24 Oct 2022 05:50:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WTNzZ5uF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232144AbiJXMrx (ORCPT + 99 others); Mon, 24 Oct 2022 08:47:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234255AbiJXMmo (ORCPT ); Mon, 24 Oct 2022 08:42:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAFDD8A7EE; Mon, 24 Oct 2022 05:08:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F7FD612D4; Mon, 24 Oct 2022 12:06:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B13C5C433C1; Mon, 24 Oct 2022 12:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613193; bh=9lSZ8aRNqxUmK/4jyig8irUcUZqPBRulXTjpjA2nuaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WTNzZ5uFc+dTmt9k2csTbehDzNldzFNj/hHot+GdrOTAq+SCm8UXG0EYA/CEHlB5h BFNYnkAafylPL5kMCE9uITe267zWPDOyampLZZPojKyWyEyKuf+MtJNilH3mKPyhaj vUWHO0EKOoaxmqFKxN4E5u87fv1eIOJgg55l2c/0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Lalith Rajendran , Theodore Tso Subject: [PATCH 5.4 043/255] ext4: make ext4_lazyinit_thread freezable Date: Mon, 24 Oct 2022 13:29:13 +0200 Message-Id: <20221024113003.863221366@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747573335907418393?= X-GMAIL-MSGID: =?utf-8?q?1747573335907418393?= From: Lalith Rajendran commit 3b575495ab8dbb4dbe85b4ac7f991693c3668ff5 upstream. ext4_lazyinit_thread is not set freezable. Hence when the thread calls try_to_freeze it doesn't freeze during suspend and continues to send requests to the storage during suspend, resulting in suspend failures. Cc: stable@kernel.org Signed-off-by: Lalith Rajendran Link: https://lore.kernel.org/r/20220818214049.1519544-1-lalithkraj@google.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3157,6 +3157,7 @@ static int ext4_lazyinit_thread(void *ar unsigned long next_wakeup, cur; BUG_ON(NULL == eli); + set_freezable(); cont_thread: while (true) {