From patchwork Mon Oct 24 11:31:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8898 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp433868wru; Mon, 24 Oct 2022 05:50:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7n9Y9Hy+3IJnQnJ6LS0zbjPI/zBbyS7nZoqdNslpjcHqs1fSk6tXhfEqVFqHBiaPcfsISc X-Received: by 2002:a17:907:8a23:b0:78d:b042:eece with SMTP id sc35-20020a1709078a2300b0078db042eecemr26351413ejc.494.1666615843647; Mon, 24 Oct 2022 05:50:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615843; cv=none; d=google.com; s=arc-20160816; b=isL27mgFj1fVimQhAzT3EpDa0OSiPdb1Ow9EEcMOCPp7dNCMB2ClfLrgFuB+qGuINe K1om0Qnn6oAV6Nel+a+VBQP51x/Um5Nt7J/duaNyfEk4AK2p6wUYfzxGzhhe3zcD1dOQ 4m7fvjahXffcSFBF7ESVXrgBpjOuHYVxxZmUjMkM2QOnoymxZfcgAydRhstG1QFz1bR6 RIHJ41//7qSWM6AgUSm0u+zetvB+n133qds3gRzhBy6SYwoPMqESSYpULNhm82gGBHDR Z0G5sM72uCAadfIMLj3eOYGGR9mk5phQirKmBtd33Ke8a1lS3LuFkPUnurNYtDLkBYxd I0Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uJPkekfWKzbn0H27WryBySo9kxN9UyLkULUU9WeBzRA=; b=gxli20119Xylgmo2kxBMP2DnfcQS4e30EWKNgHonPSDcOXD5jvyl2e0iIbFNSo/cua R3rVSnfeITvLdeJFvV+whg4O/TW9tEXDnEAY8PnVlpPfI1HfpOjfmqZTikpkLwjOfJas qB77fYyyRSIMCoOS2efhHoo2DHahHpoSpVbAn2XyuufkrOmMXpx02z5zB2apvJ3EDFul 7weNeLpT5rKS0VXOBCgOD0pUz9RqN6suke65Iex7hq3yWnmxAVWdWh6iO9Cy6U026RyQ LS39916dhSaqezV3f7X6JbLdiPX2qmCP7ClZTq1ICtuwBz9RujQWssjvLyi34x7t6MhC bnaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Qbwkoaz8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r18-20020a05640251d200b004593895fb89si1213903edd.390.2022.10.24.05.50.16; Mon, 24 Oct 2022 05:50:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Qbwkoaz8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234015AbiJXMiV (ORCPT + 99 others); Mon, 24 Oct 2022 08:38:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234452AbiJXMfE (ORCPT ); Mon, 24 Oct 2022 08:35:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C263E57BEE; Mon, 24 Oct 2022 05:05:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4D1A7B811F3; Mon, 24 Oct 2022 12:02:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9747DC433C1; Mon, 24 Oct 2022 12:02:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612975; bh=AnpJOvKIYkYcjJKzinlWrtkIErjeO2lFOTxCU7ONgSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qbwkoaz8N2BJEvUCIJ13PnwvaaL3+GZYWQ/zXq8v8ipiGxsY3aGYRMKfhrPskAZok gZ9enuX/7rPbkpSGY0nBQMSPS2uLngJFGtHt3jVQ4aDGENyhalDGKOUtHnYaIq8TS6 3owYfwg3Lae+BZ3tknjH1/NfuvHJNqrYn5qMcKxk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , Hans de Goede , Lee Jones , Sasha Levin Subject: [PATCH 4.19 149/229] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Mon, 24 Oct 2022 13:31:08 +0200 Message-Id: <20221024113003.832209259@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747573374850470836?= X-GMAIL-MSGID: =?utf-8?q?1747573374850470836?= From: Christophe JAILLET [ Upstream commit 48749cabba109397b4e7dd556e85718ec0ec114d ] The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220801114211.36267-1-andriy.shevchenko@linux.intel.com Signed-off-by: Sasha Levin --- drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 274306d98ac1..75a2a793ac14 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -118,6 +118,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; }