From patchwork Mon Oct 24 11:29:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10269 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp644818wru; Mon, 24 Oct 2022 13:46:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Hf4S95ENOtNNdLGxmmJMlj+vp5G6I2Gptpxae9e6L107PHFSsrHBFVQJxtm6fZGeZFubP X-Received: by 2002:a17:90a:f001:b0:213:bf4:ee29 with SMTP id bt1-20020a17090af00100b002130bf4ee29mr8285776pjb.98.1666644374254; Mon, 24 Oct 2022 13:46:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666644374; cv=none; d=google.com; s=arc-20160816; b=OFisuQMo83oSszEuA2aSL8QNmaZdK7ZN3kVx2fIBaJtoZ3ggd7nL3K4g6VuZYIUM3z 3+7n23GstFrUW3UuTZOeItwhrVvvap0dIeeYj6OdPlr8IxwWrwzkXx9A5Eck4JEfEniY WfozUoi4Sy3AHXP4ualV6B2nIb9puOvu2S89VeBRTT3e3HJ3wGK+OVryNSB23PHHUnLD slpXN31Brlmc1G4BXBKNxHiVZn+ShWCDCe8h4RJlbvrIfnwPxTANzjfJ5y83q3egYdAq lPnpwJ8mCKGO9DFCZZKKtkP643a6vz0dOIdVuGRVyrLQg0uJsCZVPW7vsRcxv4aAI7de N+sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gRjFT5msr9HK47fVA2pbFydpTuf04++rBXHCVaPgRHo=; b=JADMmSsbRsCuJmSDyn7E8P8rOl/06KbtGYKkq/1LDaLfiFKoDnsGjPWy3icRxn3lsI TjUxjoXQ7prjTsl1NuAfypnoCtQEN0HWbVh8pZ1mt6FQLjDFxuhZdA/RPSqwPff3GHz+ CuoSO3vOevIMptQAhXhJvXpqBujjjpY4sYjYuMdMhJtLIOzNi1GvYVrQVAancycHn8zT VTcsUvkR12s3XgRYJuvlKgPO4ZRtj6SzVIb5WcynEbo1FNNtwgf/RK3cmuANYgwCQ/u8 ZSX2c6iEg3dPXf4CXgEME+ygLgyavKGgAoHmqqBt+H5AHg1UcvDBorsbKtoQj6I6Ar6Y 4mxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mzjp5qz8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020a17090332d100b0018686834315si649385plr.431.2022.10.24.13.46.01; Mon, 24 Oct 2022 13:46:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mzjp5qz8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235040AbiJXUpl (ORCPT + 99 others); Mon, 24 Oct 2022 16:45:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235168AbiJXUoL (ORCPT ); Mon, 24 Oct 2022 16:44:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A148175AF; Mon, 24 Oct 2022 11:52:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8357AB811B6; Mon, 24 Oct 2022 12:06:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E113CC433D6; Mon, 24 Oct 2022 12:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613185; bh=XTVhTzc/xTN+HjoQQ+gMakvgeYZ5zzi8LY0H4wMCYgM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mzjp5qz8f2z2bMbej0OFbyUNuJBdL4KQR0iD7O+Xi05pmvKK5VKHbWypNgBCh/sDW lRHOXXxkRYlJV39J/KPZOJm4pLFYfGTQFFKDqujSdu+zDO7KO1qFMdTfgjMNeiUn/k 1omPnu42yO46/vaDDdNo3UGx157NYmzFPfocpvtY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Tadeusz Struk , syzbot+bd13648a53ed6933ca49@syzkaller.appspotmail.com, Jan Kara , Lukas Czerner , Theodore Tso Subject: [PATCH 5.4 041/255] ext4: avoid crash when inline data creation follows DIO write Date: Mon, 24 Oct 2022 13:29:11 +0200 Message-Id: <20221024113003.793730758@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747603291604045863?= X-GMAIL-MSGID: =?utf-8?q?1747603291604045863?= From: Jan Kara commit 4bb26f2885ac6930984ee451b952c5a6042f2c0e upstream. When inode is created and written to using direct IO, there is nothing to clear the EXT4_STATE_MAY_INLINE_DATA flag. Thus when inode gets truncated later to say 1 byte and written using normal write, we will try to store the data as inline data. This confuses the code later because the inode now has both normal block and inline data allocated and the confusion manifests for example as: kernel BUG at fs/ext4/inode.c:2721! invalid opcode: 0000 [#1] PREEMPT SMP KASAN CPU: 0 PID: 359 Comm: repro Not tainted 5.19.0-rc8-00001-g31ba1e3b8305-dirty #15 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-1.fc36 04/01/2014 RIP: 0010:ext4_writepages+0x363d/0x3660 RSP: 0018:ffffc90000ccf260 EFLAGS: 00010293 RAX: ffffffff81e1abcd RBX: 0000008000000000 RCX: ffff88810842a180 RDX: 0000000000000000 RSI: 0000008000000000 RDI: 0000000000000000 RBP: ffffc90000ccf650 R08: ffffffff81e17d58 R09: ffffed10222c680b R10: dfffe910222c680c R11: 1ffff110222c680a R12: ffff888111634128 R13: ffffc90000ccf880 R14: 0000008410000000 R15: 0000000000000001 FS: 00007f72635d2640(0000) GS:ffff88811b000000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000565243379180 CR3: 000000010aa74000 CR4: 0000000000150eb0 Call Trace: do_writepages+0x397/0x640 filemap_fdatawrite_wbc+0x151/0x1b0 file_write_and_wait_range+0x1c9/0x2b0 ext4_sync_file+0x19e/0xa00 vfs_fsync_range+0x17b/0x190 ext4_buffered_write_iter+0x488/0x530 ext4_file_write_iter+0x449/0x1b90 vfs_write+0xbcd/0xf40 ksys_write+0x198/0x2c0 __x64_sys_write+0x7b/0x90 do_syscall_64+0x3d/0x90 entry_SYSCALL_64_after_hwframe+0x63/0xcd Fix the problem by clearing EXT4_STATE_MAY_INLINE_DATA when we are doing direct IO write to a file. Cc: stable@kernel.org Reported-by: Tadeusz Struk Reported-by: syzbot+bd13648a53ed6933ca49@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?id=a1e89d09bbbcbd5c4cb45db230ee28c822953984 Signed-off-by: Jan Kara Reviewed-by: Lukas Czerner Tested-by: Tadeusz Struk Link: https://lore.kernel.org/r/20220727155753.13969-1-jack@suse.cz Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/file.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -505,6 +505,12 @@ loff_t ext4_llseek(struct file *file, lo inode_unlock_shared(inode); break; } + /* + * Make sure inline data cannot be created anymore since we are going + * to allocate blocks for DIO. We know the inode does not have any + * inline data now because ext4_dio_supported() checked for that. + */ + ext4_clear_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA); if (offset < 0) return offset;