From patchwork Mon Oct 24 11:32:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10045 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp622722wru; Mon, 24 Oct 2022 12:46:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ycvUWHgMcbkYXz9rchbxtEXEmk4OvoTPEvf/t/e93RxZEmYqBqii/tAWwiinhe6ehZ0yf X-Received: by 2002:aa7:c58e:0:b0:461:77b:7bd with SMTP id g14-20020aa7c58e000000b00461077b07bdmr21412904edq.387.1666640778846; Mon, 24 Oct 2022 12:46:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666640778; cv=none; d=google.com; s=arc-20160816; b=KAnG+ahML3WflHHAyC/RZTdAHw435lsPYDE5pacoTO1HBRzjJzlhTta0TbV3VlxUkH mKcQUuxU+EugtdzOwgl8vjqfceThVRDYhc3ZpFmIU0sBr4VmZuXtrBBNd3rONj0arBmX j0K9uakI1myLASEO2VS/0o70rb8fAJDMRxwEZG9GKA89JQtVZjRQJSRNtlqfJ9D601/C E8cgQv7QhW2srlh1pkHSP+nKSla8luyEmZN0iO2ITW7M40GOhBx6t7DQ5fH4NJPdtO1s LPGGVGqF6R8RM2MjO3pKDtGms8nEcWVa4KxnVEX0K0dW78m1qavopxAUIb0S0tV8dve2 ibHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=d7xXdrhTwnQmoZA8uPRVVzlvi0NIQuuXN3Rlmj5f1ww=; b=sh+z9tM/Z0+SK1oJkDNljC1jaZhexUHMFsBUiOgZSo6+GLCu/U+UHbQNKS7w8cXx/C 5J22OV/HjsCvEuk3I8Mv1pWRktkVh9tKsIft9657YJMpClZsn3eGROlAK66jJCJXkIhr Czkz8LucSsuDJjvugiq6cdKEuCAjVvUqjZ0zhXFQfFxIxHKnYIHkThrTP+/DqqnIeWnt T3CJ5bDs1OJ4z57GBLaZMcrax06pJaWbPu+4/ria8abDIYIm+ci96rvScbFobWijsFoy v6Fnlud6u4V6auqWEVRWwzWPOUwqxxW/XpEGiXt49qlZ1UsLw/nrAmxtEE01yRE/dad+ TT9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZFYER+HX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a170906844a00b00781df60a2c8si512134ejy.342.2022.10.24.12.45.51; Mon, 24 Oct 2022 12:46:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZFYER+HX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233008AbiJXTng (ORCPT + 99 others); Mon, 24 Oct 2022 15:43:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232117AbiJXTlx (ORCPT ); Mon, 24 Oct 2022 15:41:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7D5A265C64; Mon, 24 Oct 2022 11:11:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ED2DBB81144; Mon, 24 Oct 2022 11:54:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54B85C433C1; Mon, 24 Oct 2022 11:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612483; bh=5Vy4jq/SW/H+3NBkjZm5KJ4gAaL+cSLzxnmDanCaLrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZFYER+HXM2Frq6TZY9nZleSw3N1gSs1wzpe3plILQSvUYDy+dmIpkZIoX0WWz3lQ6 /XP7aF9o3qYzTjp4fWrQGCTw5fs0dnLFmiSbQW8Qb0i2rujTC1kLCz0q3OA06J4qiL IcdOcHhQ2wsBY2aMgp2OU8CcKT+KDYV997O4JSTY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot , Tetsuo Handa , Alexander Aring , Stefan Schmidt , Sasha Levin Subject: [PATCH 4.14 205/210] net/ieee802154: dont warn zero-sized raw_sendmsg() Date: Mon, 24 Oct 2022 13:32:02 +0200 Message-Id: <20221024113003.651648084@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747599521558760596?= X-GMAIL-MSGID: =?utf-8?q?1747599521558760596?= From: Tetsuo Handa [ Upstream commit b12e924a2f5b960373459c8f8a514f887adf5cac ] syzbot is hitting skb_assert_len() warning at __dev_queue_xmit() [1], for PF_IEEE802154 socket's zero-sized raw_sendmsg() request is hitting __dev_queue_xmit() with skb->len == 0. Since PF_IEEE802154 socket's zero-sized raw_sendmsg() request was able to return 0, don't call __dev_queue_xmit() if packet length is 0. ---------- #include #include int main(int argc, char *argv[]) { struct sockaddr_in addr = { .sin_family = AF_INET, .sin_addr.s_addr = htonl(INADDR_LOOPBACK) }; struct iovec iov = { }; struct msghdr hdr = { .msg_name = &addr, .msg_namelen = sizeof(addr), .msg_iov = &iov, .msg_iovlen = 1 }; sendmsg(socket(PF_IEEE802154, SOCK_RAW, 0), &hdr, 0); return 0; } ---------- Note that this might be a sign that commit fd1894224407c484 ("bpf: Don't redirect packets with invalid pkt_len") should be reverted, for skb->len == 0 was acceptable for at least PF_IEEE802154 socket. Link: https://syzkaller.appspot.com/bug?extid=5ea725c25d06fb9114c4 [1] Reported-by: syzbot Fixes: fd1894224407c484 ("bpf: Don't redirect packets with invalid pkt_len") Signed-off-by: Tetsuo Handa Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20221005014750.3685555-2-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- net/ieee802154/socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c index 16bf114118c3..a8929675b5ab 100644 --- a/net/ieee802154/socket.c +++ b/net/ieee802154/socket.c @@ -284,6 +284,10 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) err = -EMSGSIZE; goto out_dev; } + if (!size) { + err = 0; + goto out_dev; + } hlen = LL_RESERVED_SPACE(dev); tlen = dev->needed_tailroom;