From patchwork Mon Oct 24 11:32:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10011 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp618333wru; Mon, 24 Oct 2022 12:33:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5POWZgpz+5bh2LGgHXhph8ojk27Pj2BhK5nGjOJbQz60/AJqxWcjJqXHBfzm9vuPZURBfx X-Received: by 2002:a63:1e56:0:b0:462:970:e0de with SMTP id p22-20020a631e56000000b004620970e0demr30491066pgm.90.1666640018160; Mon, 24 Oct 2022 12:33:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666640018; cv=none; d=google.com; s=arc-20160816; b=Ujhi/6vda2TzJaYBQDa6Y3tPEX5VKrekchNJ5dsBxSSWIIQ8wLKf2Nwt8P1RDUd2hf ynd51vL9H1rZej8AXGTDdaRiMQg374sbMyBkxJcxvjXLRIdS3Uw0edZ5Ex97Mgb0RgP0 DkBHUMV+Y53FAB479iT2IfVxiwIbs98Eupb02aTcgTnkahDti+JOu4rwA8xYti/l5F6r ScafwmWmSdv1amvF6gxi42QMlmSglGHLcBRx3W7AYfj40PLS71Fd6o54Qq3icyTtBWfP Yrfn1cLZbmqZ8MWOKWuNEAJ9OGUEyfL1RF73RUOSZkkExyKC3YBeLXtzScZeXQ12mnlP Dnqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w+JeoqngnDIj22oFXTpwtF8uTj2pzFV8HLCcISlxjDE=; b=Ad8yW0Aexj6g7EdkLEXb94oeI5JFkuzpz883qWyOQ/nOtJU1kVlOfsXagrcyIHpBzV ZAyZ///UuQ7c+Ow57RQSfMXzEmg7SYWourYVMf+JbtzAPR1Xudn/1XH9a/rJKPrJGzJx gzO7aJwuB7CfCel4GN+JfAUCfqUBwdAlFp6sexbYiyQI087S+QpGU+FKgfjvwDu6rFSI IzW/1lI3zNo8iNii9I88IosCBmtttWLaGJ8qH8S1GAn6Ies/0VMNLff+YzrXKuli7Dsl ziZPElZ1GGRQnmOeIN6jqmqJzIUo8MjJgrieIOMt7YRyWxMP7YTbE5SqIA3s7GisebrF az5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iZdVAUtp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g5-20020aa79f05000000b0056bdae22580si506036pfr.338.2022.10.24.12.33.24; Mon, 24 Oct 2022 12:33:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iZdVAUtp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231143AbiJXTcf (ORCPT + 99 others); Mon, 24 Oct 2022 15:32:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233243AbiJXTcO (ORCPT ); Mon, 24 Oct 2022 15:32:14 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F4EE367A2; Mon, 24 Oct 2022 11:02:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 95509CE136A; Mon, 24 Oct 2022 11:54:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADAA1C433C1; Mon, 24 Oct 2022 11:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612481; bh=nU5shlmlTDL+WA15wXTBEMZOu70bg3gompzMDfGsWu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iZdVAUtp/h9bRYMb6cConkvau5LV/f5eVVIPNkyOtqdaG/L63UcJmlJhV4mFKHaHM DsleZ90NvngFtbZnJX7JUTjCLXR+OyOcYPe4+4iORk2oCrJJwsPRjOKJ5IM4Wq5m2/ 67PV676oKSy1SNPfu4mnimPmdSyDL3CVSjDgg+vI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Aring , "David S. Miller" Subject: [PATCH 4.14 204/210] net: ieee802154: return -EINVAL for unknown addr type Date: Mon, 24 Oct 2022 13:32:01 +0200 Message-Id: <20221024113003.608477909@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747598723951332987?= X-GMAIL-MSGID: =?utf-8?q?1747598723951332987?= From: Alexander Aring commit 30393181fdbc1608cc683b4ee99dcce05ffcc8c7 upstream. This patch adds handling to return -EINVAL for an unknown addr type. The current behaviour is to return 0 as successful but the size of an unknown addr type is not defined and should return an error like -EINVAL. Fixes: 94160108a70c ("net/ieee802154: fix uninit value bug in dgram_sendmsg") Signed-off-by: Alexander Aring Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/net/ieee802154_netdev.h | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) --- a/include/net/ieee802154_netdev.h +++ b/include/net/ieee802154_netdev.h @@ -193,21 +193,27 @@ static inline int ieee802154_sockaddr_check_size(struct sockaddr_ieee802154 *daddr, int len) { struct ieee802154_addr_sa *sa; + int ret = 0; sa = &daddr->addr; if (len < IEEE802154_MIN_NAMELEN) return -EINVAL; switch (sa->addr_type) { + case IEEE802154_ADDR_NONE: + break; case IEEE802154_ADDR_SHORT: if (len < IEEE802154_NAMELEN_SHORT) - return -EINVAL; + ret = -EINVAL; break; case IEEE802154_ADDR_LONG: if (len < IEEE802154_NAMELEN_LONG) - return -EINVAL; + ret = -EINVAL; + break; + default: + ret = -EINVAL; break; } - return 0; + return ret; } static inline void ieee802154_addr_from_sa(struct ieee802154_addr *a,