From patchwork Mon Oct 24 11:30:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8805 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp430917wru; Mon, 24 Oct 2022 05:42:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5H0MBCLKajFaqbLGqdaPUL7UeXW+IvpFLoGHngSfEBxbUvt61+VlmBJ456brTWAk8utkLw X-Received: by 2002:a63:5b5c:0:b0:440:8531:d3f6 with SMTP id l28-20020a635b5c000000b004408531d3f6mr28760217pgm.114.1666615351729; Mon, 24 Oct 2022 05:42:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615351; cv=none; d=google.com; s=arc-20160816; b=o0MWyLQMorY//a2M3zvvTN0y1xApI1j18fzeTLmgUIeJE52IWT50IDkf/vv3bbANpv 0QXf/HDpGaKuRSqm+pYe8UupVCJmW4lEjHjIwaDTG1s+ezDdsqSE6KybkgFqn445fmxf GHEgGn5DKMcTZ965wRbkqNg6vT4TNi9VJ2DtTPD4KskCUPJR4dcD9FvER6erW22zgoeB bytE14apwXywdPy5SfPALjbjUp+zU56j9ON21HoiQ7Az/xKMphvQRCe+5K7ftz9qNgkL rNnCL6B7/Ee4p37ZI5AcNmMP1TjwCvv5B3mDnyh/3neGPxZMH1TF1FT6dnTKKQV32ovc ooCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bkH6yJOgxrk1DHmD1HHkVAffvLJ628gFumv6oo74OSA=; b=B4bnikImLuZDsmw8LK+PAwyRfLd+l7VrZoIfGOONv2CYxeovBWzXarUMaibLhvkRS4 U/01Tlq1Kak4I3J9d6uQMUS6Fe7avOG66KwK1axAyYSGBo00rkMg+SxZ4xucG41il1kY cPYYsG4SeUmav9UggFHKnCwQJykR0AM26XZahc3G8BlkaSP5fzU9tNato1R6oa0nJGGR ng3QJj7JN0EXG9FtOBtF98bi7WfYgBMN0pFXgVPAjt79btGUKXd3eTRGqdWeWk+PIB/1 +aOiFMr0KG74u/ab2WwA6vulw5k0fk0cpnwnvaYhLbXBdrymIoF9mU7oN4zMwm9DQSfu 6uvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sDeFgPvZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n15-20020a6546cf000000b0046b2ec0de65si34522887pgr.789.2022.10.24.05.42.18; Mon, 24 Oct 2022 05:42:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sDeFgPvZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232740AbiJXMdm (ORCPT + 99 others); Mon, 24 Oct 2022 08:33:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234128AbiJXM3Y (ORCPT ); Mon, 24 Oct 2022 08:29:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 229E388A00; Mon, 24 Oct 2022 05:03:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01E7EB81203; Mon, 24 Oct 2022 12:00:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B782C433B5; Mon, 24 Oct 2022 12:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612822; bh=7S74saqVx1Z5JOwQfwfMYXqdxLHiFdAxBPFGunevnug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sDeFgPvZ6jJiu+dLYLb0vaGxGpAXtlmcShaCxfTc9HJYsE6CIVjXQ+tCZN8pRAce/ ZBIy+R2GbykN54oFA3L1/fD3HsU54yyvuWE8UD42fLCo3l6FJUhSijfpWZlnyY2hcP 8pbGu/IJcapl9RDpavO7oVNq9euuAmeajwd0CD+A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rasmus Villemoes , Jason Baron , Daniel Vetter , Jim Cromie , Sasha Levin Subject: [PATCH 4.19 133/229] dyndbg: fix module.dyndbg handling Date: Mon, 24 Oct 2022 13:30:52 +0200 Message-Id: <20221024113003.300400201@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747572859031292976?= X-GMAIL-MSGID: =?utf-8?q?1747572859031292976?= From: Jim Cromie [ Upstream commit 85d6b66d31c35158364058ee98fb69ab5bb6a6b1 ] For CONFIG_DYNAMIC_DEBUG=N, the ddebug_dyndbg_module_param_cb() stub-fn is too permissive: bash-5.1# modprobe drm JUNKdyndbg bash-5.1# modprobe drm dyndbgJUNK [ 42.933220] dyndbg param is supported only in CONFIG_DYNAMIC_DEBUG builds [ 42.937484] ACPI: bus type drm_connector registered This caused no ill effects, because unknown parameters are either ignored by default with an "unknown parameter" warning, or ignored because dyndbg allows its no-effect use on non-dyndbg builds. But since the code has an explicit feedback message, it should be issued accurately. Fix with strcmp for exact param-name match. Fixes: b48420c1d301 dynamic_debug: make dynamic-debug work for module initialization Reported-by: Rasmus Villemoes Acked-by: Jason Baron Acked-by: Daniel Vetter Signed-off-by: Jim Cromie Link: https://lore.kernel.org/r/20220904214134.408619-3-jim.cromie@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- include/linux/dynamic_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index b3419da1a776..77a16b2eb42f 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -168,7 +168,7 @@ static inline int ddebug_remove_module(const char *mod) static inline int ddebug_dyndbg_module_param_cb(char *param, char *val, const char *modname) { - if (strstr(param, "dyndbg")) { + if (!strcmp(param, "dyndbg")) { /* avoid pr_warn(), which wants pr_fmt() fully defined */ printk(KERN_WARNING "dyndbg param is supported only in " "CONFIG_DYNAMIC_DEBUG builds\n");