From patchwork Mon Oct 24 11:31:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8792 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp430827wru; Mon, 24 Oct 2022 05:42:20 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4hXzD85UIZLPbULihK2T4jithF7shQTbTFVERcSDqzP/dmDejclm1rqg/CJOYir+X9nmlF X-Received: by 2002:a17:903:2284:b0:180:289f:7f09 with SMTP id b4-20020a170903228400b00180289f7f09mr33780738plh.120.1666615340696; Mon, 24 Oct 2022 05:42:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615340; cv=none; d=google.com; s=arc-20160816; b=t97fzQxJxxj9Q4hIi2sivtBt+ItmNmh3bzSmVyVh8KOeUK1OQvOxN2u93SQGyMYQmx +JHf1baSjJPLCxZc8BsGJYZ9lImTg1XVOnvGmLErYckWN9Isj2MuW8FA25tHoo9p/jw5 mGsZRUp9I2LMSwRy+uF+u05EnUSgEdSq5Jb3P5OUvB/LJukj522xAItMBfnxijHnV9zX Vo34xANP2zRH7Q7rhVjPITf1zLANv/IQk14QwJP6WCY81D2395rgh1HDt11uH5EE9q45 WgFfJSXwdBjIFbz7S/Hly6C9aMqkT2vTg2ajeJ082d/Iq9HeYvuuNuoUtM+B1A/GOdyE dXlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UQoT74ONE1T6eJthZiZ4GVP2H2+DV6FRmhVWUOTtMcg=; b=mBr30G5wtl1fKlbfnS9j7lC38mzxS39+BuToftS7wvfZOpsVw0S9pa0OVDx+m9kW0K oHQPgBJfEOZ6WUfpnm4x2a4nXeXGdyt1RnBpt4uzuQs2H7zl6euZysKYa1h37UQVag00 EYvExU3ZtwsjmJdCOX71aYJJtQhB+lxUHE9jcjXaWLzFrLEGiGoGc0RtDtoFQK3BWrxo CZvDq/WSE2pHrabKxEMXe0wtpzQl7T+drixGRXrwY9OxBG2m5OlmKb0OaVs6ZLXsPJzf ekoIW8TQsFOZKLXMUWtDaDbNk9rb1LAWsF2zXjjX3KX4qAvVD4KKWzrCmNn7biLtVdnA oOug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="TbcYE/Wy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v23-20020a634657000000b00455bdca34dcsi36220709pgk.88.2022.10.24.05.42.04; Mon, 24 Oct 2022 05:42:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="TbcYE/Wy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231797AbiJXMdq (ORCPT + 99 others); Mon, 24 Oct 2022 08:33:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234134AbiJXM3Y (ORCPT ); Mon, 24 Oct 2022 08:29:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5A6C88DF2; Mon, 24 Oct 2022 05:03:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0756E612D8; Mon, 24 Oct 2022 11:53:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E284C433C1; Mon, 24 Oct 2022 11:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612394; bh=0vXha/ZnD8UqFgF3bT4H9GPLaJFT/OwUwdOCaflmLtc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TbcYE/Wy/37yq3p2cadURopHlzKy55ZGJ6/b23zXbSe7APgKapef/kfl7tsnLqzxr jaVrgGQFgKhtrw2fvVniu4L5UY9zwX5T6nrAVVI3JVuw9yo4KnLIeBdEDqkoD8s+3g Fx8bRNeG7PhQGewe555fH7DRrxMg7MAgAfranYFk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luiz Augusto von Dentz , Sungwoo Kim , Sasha Levin Subject: [PATCH 4.14 182/210] Bluetooth: L2CAP: Fix user-after-free Date: Mon, 24 Oct 2022 13:31:39 +0200 Message-Id: <20221024113002.867559589@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747572847437949340?= X-GMAIL-MSGID: =?utf-8?q?1747572847437949340?= From: Luiz Augusto von Dentz [ Upstream commit 35fcbc4243aad7e7d020b7c1dfb14bb888b20a4f ] This uses l2cap_chan_hold_unless_zero() after calling __l2cap_get_chan_blah() to prevent the following trace: Bluetooth: l2cap_core.c:static void l2cap_chan_destroy(struct kref *kref) Bluetooth: chan 0000000023c4974d Bluetooth: parent 00000000ae861c08 ================================================================== BUG: KASAN: use-after-free in __mutex_waiter_is_first kernel/locking/mutex.c:191 [inline] BUG: KASAN: use-after-free in __mutex_lock_common kernel/locking/mutex.c:671 [inline] BUG: KASAN: use-after-free in __mutex_lock+0x278/0x400 kernel/locking/mutex.c:729 Read of size 8 at addr ffff888006a49b08 by task kworker/u3:2/389 Link: https://lore.kernel.org/lkml/20220622082716.478486-1-lee.jones@linaro.org Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sungwoo Kim Signed-off-by: Sasha Levin --- net/bluetooth/l2cap_core.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 75a76353525c..652c0723051b 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4049,6 +4049,12 @@ static int l2cap_connect_create_rsp(struct l2cap_conn *conn, } } + chan = l2cap_chan_hold_unless_zero(chan); + if (!chan) { + err = -EBADSLT; + goto unlock; + } + err = 0; l2cap_chan_lock(chan); @@ -4078,6 +4084,7 @@ static int l2cap_connect_create_rsp(struct l2cap_conn *conn, } l2cap_chan_unlock(chan); + l2cap_chan_put(chan); unlock: mutex_unlock(&conn->chan_lock);