From patchwork Mon Oct 24 11:28:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9130 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp456517wru; Mon, 24 Oct 2022 06:34:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4EMwycV/AX/iOZ8ShwmkwyVRnPNlC3Wv5y1wyUliLuz0moqCbUcnBT/scobFHuBZY9RiTg X-Received: by 2002:a17:90a:a415:b0:20a:f813:83a3 with SMTP id y21-20020a17090aa41500b0020af81383a3mr39086886pjp.238.1666618460774; Mon, 24 Oct 2022 06:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618460; cv=none; d=google.com; s=arc-20160816; b=OVkGa737Ewp/LPvNBDmxVjcmY3Geg4wa+iyvVFAh+vTtx1HeCzjAi2YLrqrhU+fS9R rkjsV38vnPXg1tTI6QXs/VTgbP6A14CZE1NtVttySDajtEdV6B3/U/lHYijjVE5PdI0F Vqv4yLkTVUBw+xm+issXV77X3DFIY1+lNlZqpMn4ZXd6B02CB4wjTeYYi62GKtTS/huv Xcxnay6Kzy4tErlC0iPcXi2r4Kbke8t8SC7UxbCes3CuS76WuVaC8t/Z27raaZ/ZxDV/ r546F+YnDduGEBd864WXJ7b4DOUvaWXiFNCG+ewrJ1NNjFuD10U7/VxU4QZ8HobLifSo SWCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=C6IAUMiAxMB2o/oEr9viw+sWxMc1ZYztwU0143LliyA=; b=HlUY8cD5qbfae3Z9rEP9HnC0IVfQlf/n5OOo6T1B7a2xipwpr3X/BM7jo/B8uuNdPv b0v+f6jENorwTFLHPrKNFJ9wGsfXGOcP0iRZ+hhWdCHAyvTnuf/Sn/2j/5BgnkWBYMCK 4A6tw/0RTrpP/DGivB4SKRtaqdYpvOaOk/EAS9lrRzG6HdAZ2lUz/yhZ9L+KJ5Hb0vfw 6dD4XxonCOxgp3YDk/Cus44UOl2C48lp9lAAVGA8Fqb8zd8D1GoaOxL4zBxctsnoXh9X odVdleG7K7ssFnfJHOu8J9nmUvrFYtVASAGdLfUBCkSnGeJvqgSIU8QdQ6Isx2YQ9ZW0 hakw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=n5uz2h2f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020a170902ec8600b0017535568d5dsi40629336plg.256.2022.10.24.06.34.07; Mon, 24 Oct 2022 06:34:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=n5uz2h2f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231863AbiJXNVN (ORCPT + 99 others); Mon, 24 Oct 2022 09:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236257AbiJXNTn (ORCPT ); Mon, 24 Oct 2022 09:19:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1855AA6C05; Mon, 24 Oct 2022 05:28:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B55BEB810F5; Mon, 24 Oct 2022 12:05:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17D46C433C1; Mon, 24 Oct 2022 12:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613145; bh=dZdoUx1cfGig2aKa5ufWKxeODt8wBSQvHb3m16sWYFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n5uz2h2fZzRfw4GyLmFXgOy6EC6g1j4r9VwF79NGKFPUWSv3/ExdBL2cCs+aiwZSO iHP8TopRLBa9Q3qvd2IP4Yi9rUhL4BFYZ1bwLm8e8LbTGsLCRhyImVE6DjyLVQIVB6 gbm/O9NidLTmCkvCVQdEKxeoNi1zv79XDWLsDkr4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Callum Osmotherly , Takashi Iwai Subject: [PATCH 5.4 005/255] ALSA: hda/realtek: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 Date: Mon, 24 Oct 2022 13:28:35 +0200 Message-Id: <20221024113002.638783406@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113002.471093005@linuxfoundation.org> References: <20221024113002.471093005@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576119511851125?= X-GMAIL-MSGID: =?utf-8?q?1747576119511851125?= From: Callum Osmotherly commit 417b9c51f59734d852e47252476fadc293ad994a upstream. After some feedback from users with Dell Precision 5530 machines, this patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK. While it improved the speaker output quality, it caused the headphone jack to have an audible "pop" sound when power saving was toggled. Fixes: 1885ff13d4c4 ("ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5530 laptop") Signed-off-by: Callum Osmotherly Cc: Link: https://lore.kernel.org/r/Yz0uyN1zwZhnyRD6@piranha Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8138,7 +8138,6 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB), - SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),