From patchwork Mon Oct 24 11:31:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8627 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp420426wru; Mon, 24 Oct 2022 05:18:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ZUWxF1biDGENiyqr5WCclbJ1GgwDsx7iAHWQByibGRDoi2LfLjBuiiy9CJWqB2lXCfww4 X-Received: by 2002:a17:907:2c67:b0:78d:49d2:6297 with SMTP id ib7-20020a1709072c6700b0078d49d26297mr28230111ejc.21.1666613890305; Mon, 24 Oct 2022 05:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666613890; cv=none; d=google.com; s=arc-20160816; b=fb7UhP7HiJwIgwGrJxcA/pjtaSpo2JzmnPxqr1vU/1iooSFjkakuhvggZotbL8RuPl UaPKfyMDND5f0alwHkPue353SBoVy3F8iGYSIidWWnkD5q8cQnj6y5KhZCeU1P1OWYrD 2Z3gDGikbyPf3Foit2LX1XdpYdiWv4ZKN6BT7BOJSZGkI2EzpjkSZX86vkMxwjcMPMuQ tH8j5ZKqzlSvuN2cR+SJAhnPqKOhfCuAxf3ZtO+HDucBzDTeyvA1Mf73nqaeMF1NCRgg HLpByzjcgYT/U8Eiy6fjZLImb2/mC9MM9emn0nZ5QGQqycwEDO4ksq3F3zgKo+j6lnAs h7Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wtwZaoxzq9yFJ4a5aZxYsJkqw6mHkDLzX9xaqLsA6wQ=; b=dZHorewx9bu+GHqQbW43Ggx/LkRzzMFH88jHxiVP8gzpcjlrdFakQ4cwjyw59fjUkl IWsfHNFFdXdlbuL1cgxADvSPHqye++AI7vYr4I1OaxNlf3Q7aV8Km49D6jc3dZb9xf7z cntxbsObRc+dXyC1vyplMVw/1I4NR3Sl271dbwqnYwqF+ri3JxeyzEQRT29kq3ob142h xBPC26L1gGZetl9rF666mce4kHhQfZOzqRtt5/ZXWBrXaxnjPORzX2UFxoDrX/AU9akH SJwTv2DGyUos0LkS6Kqy5CTYxOSDX3qvtczl4FAcOnJX2iCpx0cEcuEmKYmFJYuyoL2r iUWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oWAQ50bN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa43-20020a17090786ab00b00782b261ea1asi27263956ejc.67.2022.10.24.05.17.46; Mon, 24 Oct 2022 05:18:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oWAQ50bN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232810AbiJXMLk (ORCPT + 99 others); Mon, 24 Oct 2022 08:11:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232502AbiJXMKI (ORCPT ); Mon, 24 Oct 2022 08:10:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E79D27FE75; Mon, 24 Oct 2022 04:53:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B066B81134; Mon, 24 Oct 2022 11:52:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE69CC433D7; Mon, 24 Oct 2022 11:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612321; bh=sRESwLM37kyav1ZqzHsIQQZE1DF/iVdBz1Bgkyw1Cks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oWAQ50bNlRCfMJ4Amc9d0nytI0dYYrIyAWfQYrBytPdf1MZth4773Wo8lg5Ucn+qa FtoBRYyzUxvXp/GVdbWqoFWgMrPh9E5lOaXgFmAQ4btBg9DHa+aSOyGMRPBTZcdW4u Oqcksvs1O32qx8yFKohxr57GL4zp9Kl50r6F2IwM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Michael Ellerman , Sasha Levin , Miaoqian Lin Subject: [PATCH 4.14 153/210] powerpc/sysdev/fsl_msi: Add missing of_node_put() Date: Mon, 24 Oct 2022 13:31:10 +0200 Message-Id: <20221024113001.943630984@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571326788758021?= X-GMAIL-MSGID: =?utf-8?q?1747571326788758021?= From: Liang He [ Upstream commit def435c04ee984a5f9ed2711b2bfe946936c6a21 ] In fsl_setup_msi_irqs(), use of_node_put() to drop the reference returned by of_parse_phandle(). Fixes: 895d603f945ba ("powerpc/fsl_msi: add support for the fsl, msi property in PCI nodes") Co-authored-by: Miaoqian Lin Signed-off-by: Liang He Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20220704145233.278539-1-windhl@126.com Signed-off-by: Sasha Levin --- arch/powerpc/sysdev/fsl_msi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c index 44cbf4c12ea1..d43d3d1b27ed 100644 --- a/arch/powerpc/sysdev/fsl_msi.c +++ b/arch/powerpc/sysdev/fsl_msi.c @@ -216,8 +216,10 @@ static int fsl_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) dev_err(&pdev->dev, "node %pOF has an invalid fsl,msi phandle %u\n", hose->dn, np->phandle); + of_node_put(np); return -EINVAL; } + of_node_put(np); } for_each_pci_msi_entry(entry, pdev) {