From patchwork Mon Oct 24 11:30:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8730 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp423784wru; Mon, 24 Oct 2022 05:25:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5hyTXhibYwXIurQUidb6WClHMZrsmblWLXlOq4AsHwvomXieEDskSl2RY3wroM3oEoaKqF X-Received: by 2002:a17:90b:4c86:b0:20d:402d:6155 with SMTP id my6-20020a17090b4c8600b0020d402d6155mr71779721pjb.229.1666614345450; Mon, 24 Oct 2022 05:25:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666614345; cv=none; d=google.com; s=arc-20160816; b=CqQHlYqAg7p2DeibSPonAwVSLSsuT6Vogkj0wd5Ado3EEsCcF71Zizddv4tfWret+M Zs6gcQm3pXGsgDjOTQGKOhed5ubpsWzrVUwct+kkJhsv5Ik+GxErvjVrKnlMFyqcXCch CKsUSlSadiVN1Fe2J7z2Xg8/67kr02rQ3RRiim5P6W1+r1+JM09ymnMC/lGYz+8ec8J/ e5M/9vXobrLemeUQKf2BFaz5Zz+//FiKcbhl7+eKjcnpJ516Z5f7ksFiKioeg4bRsLmj 3+7sr2tTJSrldYMQjOktk17GlOistGGyAK2C8pbdlYKvE7FvzG26ZO5vvHAHaxDThCGg PsHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NCajvmPzlLtTQEuxTL2OzG5eHDyTQ+NLd7FwXLOsMOI=; b=Dh3gi16GTF4jinXCBRxvSsiWTOjWo08LpSfgQe3Jg2vnVNhX/Y4ml1M5nCllcsWHDK KgZQAHpzsbmqUbUXmE4gluAPQpThhE89qwrUJHCDlclVRnraDCTmhFdEK2I6x7nIxgz3 jiFeXMGxtipBpNAF35OIrsppagcB2KSNud6m/xGcMEY/HKNG2GewYIsssK09y+186QTm d+8/fF+QwNmnMKkqj0bcCTBCk54bcWoDg4uyBZygmRHgR+N4nje2xF4EzqsEo+7cQLMP NBKiFHsH7SVy3akGrCYhn15IT7eydstHCRKu5zbYv8U+hr0GCAL+QDK6A+uLG9ZLPVsA aI2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uYKAOoPx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a637803000000b0046ec38975f7si10908098pgc.49.2022.10.24.05.25.32; Mon, 24 Oct 2022 05:25:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uYKAOoPx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233559AbiJXMZD (ORCPT + 99 others); Mon, 24 Oct 2022 08:25:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233565AbiJXMXO (ORCPT ); Mon, 24 Oct 2022 08:23:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84BB51C428; Mon, 24 Oct 2022 04:59:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D6422612BC; Mon, 24 Oct 2022 11:59:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFDB9C433D7; Mon, 24 Oct 2022 11:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612780; bh=OdCrpPWWG4nWQffHV/hJadngSemBaAi8ZG/iIGDQHl4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uYKAOoPxIqvimA2pNvJRIenD9Yx0Z8rTKbkf9lsN8S/U/eYViS03OHIXKnE0z0kj1 LCMmEC2plGwPU1JpBOSA3P8Pa1PXq2wffkbcpm1wy51mDJRKqxDkBJEWwDNVCHhy/R 7yb92ztKFlQQCfpiXB8AhkFkbHg4Eu/HN2lM4Xho= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vincent Whitchurch , Mark Brown , Sasha Levin Subject: [PATCH 4.19 085/229] spi: s3c64xx: Fix large transfers with DMA Date: Mon, 24 Oct 2022 13:30:04 +0200 Message-Id: <20221024113001.813525650@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571804086031803?= X-GMAIL-MSGID: =?utf-8?q?1747571804086031803?= From: Vincent Whitchurch [ Upstream commit 1224e29572f655facfcd850cf0f0a4784f36a903 ] The COUNT_VALUE in the PACKET_CNT register is 16-bit so the maximum value is 65535. Asking the driver to transfer a larger size currently leads to the DMA transfer timing out. Implement ->max_transfer_size() and have the core split the transfer as needed. Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver") Signed-off-by: Vincent Whitchurch Link: https://lore.kernel.org/r/20220927112117.77599-5-vincent.whitchurch@axis.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-s3c64xx.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1d948fee1a03..d9420561236c 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -84,6 +84,7 @@ #define S3C64XX_SPI_ST_TX_FIFORDY (1<<0) #define S3C64XX_SPI_PACKET_CNT_EN (1<<16) +#define S3C64XX_SPI_PACKET_CNT_MASK GENMASK(15, 0) #define S3C64XX_SPI_PND_TX_UNDERRUN_CLR (1<<4) #define S3C64XX_SPI_PND_TX_OVERRUN_CLR (1<<3) @@ -654,6 +655,13 @@ static int s3c64xx_spi_prepare_message(struct spi_master *master, return 0; } +static size_t s3c64xx_spi_max_transfer_size(struct spi_device *spi) +{ + struct spi_controller *ctlr = spi->controller; + + return ctlr->can_dma ? S3C64XX_SPI_PACKET_CNT_MASK : SIZE_MAX; +} + static int s3c64xx_spi_transfer_one(struct spi_master *master, struct spi_device *spi, struct spi_transfer *xfer) @@ -1118,6 +1126,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) master->prepare_transfer_hardware = s3c64xx_spi_prepare_transfer; master->prepare_message = s3c64xx_spi_prepare_message; master->transfer_one = s3c64xx_spi_transfer_one; + master->max_transfer_size = s3c64xx_spi_max_transfer_size; master->num_chipselect = sci->num_cs; master->dma_alignment = 8; master->bits_per_word_mask = SPI_BPW_MASK(32) | SPI_BPW_MASK(16) |