From patchwork Mon Oct 24 11:29:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp423151wru; Mon, 24 Oct 2022 05:24:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6J0Pk+Y/gInRTxU1F85CnZrYc+YxAmegyNAWKFpPMPpS3ntLHWc+62cY7Z+SCub/rlJe7/ X-Received: by 2002:a05:6402:410:b0:451:ea13:4ed7 with SMTP id q16-20020a056402041000b00451ea134ed7mr31778695edv.262.1666614251940; Mon, 24 Oct 2022 05:24:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666614251; cv=none; d=google.com; s=arc-20160816; b=XdWQVTI6WM2Lb2HzA8Bi/C23ozjCLVgTJ5VK5DlYaJDZy3mfmLGdhy/bf3DSsrk+y8 bqo7beckcdaK9NjB7UpCEq8mxd7hXVWq6ZAGWjUVIR6by7YIO6N5Ihxa4+jxV7o9W7TO zgqtQwcj2ZxK1vtkSIelgZQbKNOCEaXGcDC79MF8ZZcdG56PrfcYn0cINhb9tgdPWj1K gzifZK0d4YqDOfxhsYYBdoUdvuRdwu+tmR42p/JqT8wmEg6FXInboiZJ67xGwy2Miuv6 nDjzAvndny2AXSbwN9uLjS9EnmZQwAVEjq5dBFOFkfd83p6n2GXeX8cF3tIKPgv3o4bs 45fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=X9t+8q4cfCbn3lydR8dQMNGHMbrU1j4hCkeMhmRMZ/E=; b=nQcqj6Su1S0pgv01Sar9Q7SQIyHqrQbytmDq6H6MVeRnGsFBT8Hi3eENWy7Z6URbnI Rn7B0Lmp+Ci5ujTmnNbiW37lKEElsVzDIwjIvuMw2Ehe4mOqflQk9/wCuLeJQBzGu8ce PSWM8FOgNw/EUDWBKXrHxnKjOVL2eNSrFKePoB7KRsCrYtlm6ZSbeDQ2lnswHR8BzCZY cXetetoR/2nbIHjQSDy0lZILyX7OuRFt3dl3qGlp42DaHCC+BLkyVQBeYp/mdf3T6kJe /RmXijpSkNfLfvMiEzpM/pWxMQ8yjgUL2wvKRWGmi3BQxc+LCxjHp3efr4rrdTHfbs3z KaQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2tZVmwz6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m15-20020a1709060d8f00b0073db9474d06si24148006eji.325.2022.10.24.05.23.47; Mon, 24 Oct 2022 05:24:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2tZVmwz6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233537AbiJXMWv (ORCPT + 99 others); Mon, 24 Oct 2022 08:22:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233305AbiJXMUi (ORCPT ); Mon, 24 Oct 2022 08:20:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC18B7C19F; Mon, 24 Oct 2022 04:59:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4325C612CC; Mon, 24 Oct 2022 11:58:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57FA3C433D6; Mon, 24 Oct 2022 11:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612687; bh=Enjz/4GrQEe05c4RvFIjHeawUyag1ck9dA7+R5QI1io=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2tZVmwz6v4Y05JqjJrUTkFIgqe4lYwMsvyhVoFmfTOimEqZRsQMnB3xdGWwl86lkA nLRYv4iIuqWYG5qIGIG8fRXASF438l/jDcvNhp3/mNvtFuNRfR85S8x+dUxrngnDH6 vb2AxxODEfU0u+YrWv4wqDE7IcXWcZ8xzeMVBLzk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bitterblue Smith , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 080/229] wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration Date: Mon, 24 Oct 2022 13:29:59 +0200 Message-Id: <20221024113001.658750801@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571705600828258?= X-GMAIL-MSGID: =?utf-8?q?1747571705600828258?= From: Bitterblue Smith [ Upstream commit e963a19c64ac0d2f8785d36a27391abd91ac77aa ] Found by comparing with the vendor driver. Currently this affects only the RTL8192EU, which is the only gen2 chip with 2 TX paths supported by this driver. It's unclear what kind of effect the mistake had in practice, since I don't have any RTL8192EU devices to test it. Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts") Signed-off-by: Bitterblue Smith Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index ccd76c1da40c..38f06ee98b35 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -2930,12 +2930,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv, } if (!(simubitmap & 0x30) && priv->tx_paths > 1) { - /* path B RX OK */ + /* path B TX OK */ for (i = 4; i < 6; i++) result[3][i] = result[c1][i]; } - if (!(simubitmap & 0x30) && priv->tx_paths > 1) { + if (!(simubitmap & 0xc0) && priv->tx_paths > 1) { /* path B RX OK */ for (i = 6; i < 8; i++) result[3][i] = result[c1][i];