From patchwork Mon Oct 24 11:30:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8670 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp421993wru; Mon, 24 Oct 2022 05:21:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6008Y+Tll86vEdij3R7MPZdJdobbOfKN1zOdNGG7zDbhL1X1ACWQq5EEtpjEhZVALD1ZXB X-Received: by 2002:a17:907:3da2:b0:78d:51c4:5b80 with SMTP id he34-20020a1709073da200b0078d51c45b80mr26935426ejc.716.1666614097958; Mon, 24 Oct 2022 05:21:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666614097; cv=none; d=google.com; s=arc-20160816; b=p3kvCoJ/J7ctiqqxAoKVz32gwRyQSDrXnDEqGr+X64wt/6gf5+75uf9A9e9RejPBJD DB0T6SNO5TwhvQT1js5nD2EZl/NiAR8qVFBeGhFuRmMz6MZ9hS1rnr0XQeaPKRc8vm85 hQADh+mcVKwemLL5lUOJWGw0gtYecVPOvnTlEI0YuQVuzlxyQ2pBU0UL503bnB53tZy8 JM1Zk/0s7y45akKvqTAxFBaRAteUmcEEu9z6Ndk7Kekt4+5g4+hZmMu33CgBX4CQ4l/x gHRvhDCkCKwN2Z4+PQO9CKKcoApobxJp6X6LvXW8YSZFWCK/RE/22+o9uF/6Pu4EO1MA V3Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZsZerslF/0fVhFn6vPF2dvdQANPvXSEZPyznC/Z1wxI=; b=mVDvUrNRZOTWukKle9RoyYz5LiDUnlGhn4kPqq8VaaT21AuoAF8Wq85kN3JgmxGTHR LO5t9oYEtHOdcWzTnA82AOvqriqW2otx9e92UCwdESIQhDojM0wS8FdBcnyDyAkV2kde 3f7ZV/uKW0Drnm3v7WNRh+34cTycN3HHXyIhBAHcSbcWg94QSmXmnECiSSmuoLKvTfPa BKcGHxlb7FSJtKp5Ac92vZTdk36G33Zk1mj3DDgOIxL0Fq7Ln6JCOcUgnq6llGYOUET+ 07IFeLXRrxx4medaWlB5cfAp3oZ7cWUTF3sjGEWcL/sYTKLBjeHL7YzFUWMcepCIOdiW +eFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZY3Sw3xg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga29-20020a1709070c1d00b00782faf12c6esi29625994ejc.78.2022.10.24.05.21.14; Mon, 24 Oct 2022 05:21:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZY3Sw3xg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232959AbiJXMSj (ORCPT + 99 others); Mon, 24 Oct 2022 08:18:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233167AbiJXMQ6 (ORCPT ); Mon, 24 Oct 2022 08:16:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9FA7814FD; Mon, 24 Oct 2022 04:56:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3F193B81186; Mon, 24 Oct 2022 11:52:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B025C433D6; Mon, 24 Oct 2022 11:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612371; bh=e/KEj574MmNa/M0sn4QvklxgLeOlAyMdJQf52uy5n4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZY3Sw3xgXggeSkY96fjQfH5yJOQ8eWrsUaC/Mb5SZ78YGxmVBRnYEKIHzX5ByJqR1 CIoKVdKGcAYdxak56Z/P7uYHP8h2VRKSw33ug9R8JXy1s150JdWoIfYXBEAEkn+Jiv xUqU/vkMr80VDONQ/dsEtkGZkuE0ctBz/cIipjhk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , Hans de Goede , Lee Jones , Sasha Levin Subject: [PATCH 4.14 142/210] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Mon, 24 Oct 2022 13:30:59 +0200 Message-Id: <20221024113001.588033162@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571544632678776?= X-GMAIL-MSGID: =?utf-8?q?1747571544632678776?= From: Christophe JAILLET [ Upstream commit 48749cabba109397b4e7dd556e85718ec0ec114d ] The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220801114211.36267-1-andriy.shevchenko@linux.intel.com Signed-off-by: Sasha Levin --- drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 36adf9e8153e..eb9ff34294e6 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -119,6 +119,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; }