From patchwork Mon Oct 24 11:30:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8698 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp422697wru; Mon, 24 Oct 2022 05:23:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ZFf6ruMEoYBBOtVMC/cqcafJXL9SuMHJcQVuSrmRh7UfUwLzqjoIaCSSX7GIJCsD5xuHx X-Received: by 2002:a17:907:6da3:b0:78e:2a5f:5aaf with SMTP id sb35-20020a1709076da300b0078e2a5f5aafmr27038741ejc.554.1666614182613; Mon, 24 Oct 2022 05:23:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666614182; cv=none; d=google.com; s=arc-20160816; b=w5IHwR3NeP63vCLIsU0AIYYQBmQhyEtZtGOzVmJ6gCHb5hGr1AI9RysaiNXY9E34nm Zv6wH9kV4RSf+ptEGZ5alobV7fMW6t/cvasyotGmtXOiQjI+6owuKM2+YZ7wj+4ymedn 7mdhuflwj5XdzKmZDNn4ew88Ku07aBizyZE3lHiotCJo8Rw5OvqVFnyZ5zmGFKDl2w/1 Dwoa2wBewNowoSCuKVaDq312Edek/X0Qzw6/DbsWq3m4XdoANaKdbav7MLRAfq9PNJbh yPhV2F8TSw6n3JukB/s0VxvC7PiScfqBxTtUcRgYhbLCE2u0Sx3wMn2n7IXR14YybKWA u4fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xVSIX12qppkNni78MxVYb27yW9XD9izW74viCC61gOg=; b=ta46tUe5uYhYj4bYj80Eoc9SDKNEoa3cu+Kx3Yjcx+scLgkqfSEdfMHG+WLf4bCkJd 6b+p8u1GJElGv2vQXsiDZCKbL+mqmoF/UTkKF0xwO2n6sFRPyGGq0pt0TlRcw06q4wtm QBxyMIhTdHt+ZD6dMmxO0I8PfZb2IVYeMTJx3usIOVzwMSH7++Brlf6uwlA77BPb+YS5 vFvn9d2pkKWA4u2g6OvTZI0XmqrjMccEbRhRAJEGDHhV7dOtUMJPK7KTbOKpXRAgt+EL /sZ50QTRkKYORKQDHONyjqUAS8CMCGwVcDBSXaMi0zT3S88d+/04nJKFGdMAOC7rs1OB SIDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iQGydnCT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc35-20020a17090716a300b0073ce34d1a13si32140399ejc.499.2022.10.24.05.22.38; Mon, 24 Oct 2022 05:23:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iQGydnCT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233419AbiJXMVo (ORCPT + 99 others); Mon, 24 Oct 2022 08:21:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233516AbiJXMTn (ORCPT ); Mon, 24 Oct 2022 08:19:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95A698285C; Mon, 24 Oct 2022 04:58:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D657A61254; Mon, 24 Oct 2022 11:50:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E94C1C433C1; Mon, 24 Oct 2022 11:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612255; bh=3woiI64PEx05HutrOLVRH3ZjdrzIYvUydoHTUwinAaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iQGydnCTDjmWfYHWMuCr8s3j2wHwogakGxwV4NZUlpREZWiwwNieVwUAAC2zHTIkV mtTA5/Xl8jqWweLUPgrsCFe9TvngU+3zfg1OeVam6i89j6PbVArwWq2fPnZgl5T2Em U315CMcTiS3N79NY+2+JFOk1nnrXcwmAB8lpzBhw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rasmus Villemoes , Jason Baron , Daniel Vetter , Jim Cromie , Sasha Levin Subject: [PATCH 4.14 128/210] dyndbg: fix module.dyndbg handling Date: Mon, 24 Oct 2022 13:30:45 +0200 Message-Id: <20221024113001.142535065@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571632997900555?= X-GMAIL-MSGID: =?utf-8?q?1747571632997900555?= From: Jim Cromie [ Upstream commit 85d6b66d31c35158364058ee98fb69ab5bb6a6b1 ] For CONFIG_DYNAMIC_DEBUG=N, the ddebug_dyndbg_module_param_cb() stub-fn is too permissive: bash-5.1# modprobe drm JUNKdyndbg bash-5.1# modprobe drm dyndbgJUNK [ 42.933220] dyndbg param is supported only in CONFIG_DYNAMIC_DEBUG builds [ 42.937484] ACPI: bus type drm_connector registered This caused no ill effects, because unknown parameters are either ignored by default with an "unknown parameter" warning, or ignored because dyndbg allows its no-effect use on non-dyndbg builds. But since the code has an explicit feedback message, it should be issued accurately. Fix with strcmp for exact param-name match. Fixes: b48420c1d301 dynamic_debug: make dynamic-debug work for module initialization Reported-by: Rasmus Villemoes Acked-by: Jason Baron Acked-by: Daniel Vetter Signed-off-by: Jim Cromie Link: https://lore.kernel.org/r/20220904214134.408619-3-jim.cromie@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- include/linux/dynamic_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 2fd8006153c3..921649db00f9 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -168,7 +168,7 @@ static inline int ddebug_remove_module(const char *mod) static inline int ddebug_dyndbg_module_param_cb(char *param, char *val, const char *modname) { - if (strstr(param, "dyndbg")) { + if (!strcmp(param, "dyndbg")) { /* avoid pr_warn(), which wants pr_fmt() fully defined */ printk(KERN_WARNING "dyndbg param is supported only in " "CONFIG_DYNAMIC_DEBUG builds\n");