From patchwork Mon Oct 24 11:29:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9986 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp615372wru; Mon, 24 Oct 2022 12:26:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7qBcmqnEc/OqUbnGzBUtnMjent3YGVDV/sAs/GaRSjhCb9qrVWwIklLgycyIqwHZ3E+bzv X-Received: by 2002:a17:907:1c8a:b0:782:1a0d:3373 with SMTP id nb10-20020a1709071c8a00b007821a0d3373mr28037000ejc.135.1666639571478; Mon, 24 Oct 2022 12:26:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666639571; cv=none; d=google.com; s=arc-20160816; b=pkZ6ywP4XvpEoIwbS4+ph0+6GI/4ILFoXYQ/huxns5YjzOs1pUg2FuP3qqzWveRfe0 MzokYDGCz7Vhig0CCEhgeslDyWthhzSns/9/dKJ4s0IXo23WZcgRPzs2eAyJnB0lx4zt UvJD8GrFkWWg0hdrxzWPgG9KEKwgRtuibZtNjXqbWm/IT465kj3VWDoDS9MZagx76NsS 8tKrZsxskoLSkkr6Xa7Diztzo2EH2IR8PWymyYTo2sdAachYGwQbktws9UHe7fNq64vf LBYH9MJhl1a68T8Qd2KBoQunra+Axzk73HT1MmVwLXOwAS46GHt02Jey4miDbDyeVGMm IMNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ukZAfBERIKz4ShL7Y82aqkeal6obOiarLWqtirSqIR4=; b=oOcAytVnFdtkiTM81VFODaR+SnKSWov8NlI5faG63sTBIN2FEAc9S4mFsjB5Z3kKTP MsuR4Y4EKBnhgCsJVMd7R2br5NEhuhHZ25cPTy29o7gCli2xzCU2T8sR9+Zz7RBkoGJu MKgRZ1rDi0T3PXQr+UbsQTo510rJ9bm86TBIvdOgzq+bxfN+oMB7/IIjICKLqPuuzbXW ssCmS0IUlDn2o7iYdiLk4XIyPqwEF9m2/vTQYa7oq/roA727855ssWItFaRO5eSjPNSd TQtPFrSnTj0R4knzyOWa+5FAKrxE/yxbY17u9bcW7DtgboYiIxWZ+3URf9yxE6X7DdVp WcaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Jxy90stt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qo14-20020a170907874e00b007aa5e6c4b5asi644690ejc.128.2022.10.24.12.25.45; Mon, 24 Oct 2022 12:26:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Jxy90stt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232646AbiJXTXp (ORCPT + 99 others); Mon, 24 Oct 2022 15:23:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230455AbiJXTV6 (ORCPT ); Mon, 24 Oct 2022 15:21:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A5D88B2C9; Mon, 24 Oct 2022 10:57:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 19689B811ED; Mon, 24 Oct 2022 11:57:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70C24C433D6; Mon, 24 Oct 2022 11:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612632; bh=EDhmVUVppYFRsGfyqQAfN/KBj1aMj8UYArzRWZSF73E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jxy90sttFJfv4lksn8gFsrqz2+CEKnZN1v6Cl5VklklnArvn87hDU5TJckuXjHhV9 I/4GfsjXq7U72dFiKkCZzbxczCkMSbYZPO11LRF2x4W1eEHXCVQNh+s9RBhbSAtko9 ocSmTttTYYRFwCLKtwmuWeoUHF53+yIEEDm3wY/w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Jinke Han , Theodore Tso Subject: [PATCH 4.19 061/229] ext4: place buffer head allocation before handle start Date: Mon, 24 Oct 2022 13:29:40 +0200 Message-Id: <20221024113001.057389294@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747598255746885335?= X-GMAIL-MSGID: =?utf-8?q?1747598255746885335?= From: Jinke Han commit d1052d236eddf6aa851434db1897b942e8db9921 upstream. In our product environment, we encounter some jbd hung waiting handles to stop while several writters were doing memory reclaim for buffer head allocation in delay alloc write path. Ext4 do buffer head allocation with holding transaction handle which may be blocked too long if the reclaim works not so smooth. According to our bcc trace, the reclaim time in buffer head allocation can reach 258s and the jbd transaction commit also take almost the same time meanwhile. Except for these extreme cases, we often see several seconds delays for cgroup memory reclaim on our servers. This is more likely to happen considering docker environment. One thing to note, the allocation of buffer heads is as often as page allocation or more often when blocksize less than page size. Just like page cache allocation, we should also place the buffer head allocation before startting the handle. Cc: stable@kernel.org Signed-off-by: Jinke Han Link: https://lore.kernel.org/r/20220903012429.22555-1-hanjinke.666@bytedance.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/inode.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1310,6 +1310,13 @@ retry_grab: page = grab_cache_page_write_begin(mapping, index, flags); if (!page) return -ENOMEM; + /* + * The same as page allocation, we prealloc buffer heads before + * starting the handle. + */ + if (!page_has_buffers(page)) + create_empty_buffers(page, inode->i_sb->s_blocksize, 0); + unlock_page(page); retry_journal: