From patchwork Mon Oct 24 11:29:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8762 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp430354wru; Mon, 24 Oct 2022 05:41:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5SP96dJWc7FgTTNq3Fyg/QMnJioVZT0T6wFbHn+s2dDgDZRiEVQvWLRA38+nOGOfwLt/kH X-Received: by 2002:a17:90a:ab90:b0:210:27cb:e337 with SMTP id n16-20020a17090aab9000b0021027cbe337mr30247798pjq.139.1666615278490; Mon, 24 Oct 2022 05:41:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615278; cv=none; d=google.com; s=arc-20160816; b=JF/SqKkNK+AQYHZ4EQ5kaW+lzcTVEoOwxYSDgmtgH9HNC/acrk3spatsRIYSUC9fpp 8YJR8h1uBPZylWJlH0Zp07BU1F/7eLAG7Lk0MtUjKFiA1Iqu6xxLoT5P5aQY/KmLmRqU xtxnv2HSzvCn8R0BUO8/5cjuoc/kVAj3haau5ONM7tqPN1gXIf9cDUQe8aUd1rUSL98s uG1Fs4hLr3z34h2iRlrrUS9ZO8L5UCnzBrf0xfteMtpDqn51eCUurBLfGKVbenGMu6m5 BTeZOJMnG37Od5IJSQvVPPlMvwWQ1f3AhFs+3yqR6mTLCzix5dhwzy5jFJBbGwJsE/4f UIYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WuzPbOZyd4kyCiaHkunfX0Lz4u+bRwvrBg7fKSHuL6A=; b=qdZ1GPA3YaBEIG3rTnxTJ+/P/XF1B2PzjhHIl06wl0KAIFR60iH5CH7mhUad5ZFu+d e4okOTCzYgW95+GjuWAF8UT8Zg4dFOJUgAJXg3HQY/RBMTEEPz1QP0tCSMm0FflktNX6 uAm3FCGUbbIlnRE6+6VScbbCVoo8UI9T1LbtFHpr6VkLQzcsuQnLkw8g8Kc6FC002e/z 2Gr7u0PXMr6sp7Cobio5HUjON0PS3OcwstX8pNxCKu8oGabie4ymaoksi/PbKuLSItMi /7Wvm2WLaJSrcQbSYrXygPd3kjakif2HE8ZdZ8z/h5sS1GPu+ZuAT4vMNZgoiZ5xkaxw P/VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=n1iVg+5S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c3-20020a056a00248300b00536bbfa4994si34165949pfv.345.2022.10.24.05.41.04; Mon, 24 Oct 2022 05:41:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=n1iVg+5S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231611AbiJXM2n (ORCPT + 99 others); Mon, 24 Oct 2022 08:28:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233668AbiJXM1N (ORCPT ); Mon, 24 Oct 2022 08:27:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E316386809; Mon, 24 Oct 2022 05:01:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 74EE6B81186; Mon, 24 Oct 2022 11:57:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1AD0C433D6; Mon, 24 Oct 2022 11:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612630; bh=vu9eNoLHiHjtM5lf+Zi1lWs4QGZZCvb2o0ZwjBsrQh4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n1iVg+5SxRa4jPT9KVHB9AXw7Ae8nUYv0lO8bh71kZOA8qzKiNSHJaEbxwb297ywI t1tYSZiDGiGlmN6NbPs1UW370T8NoSBeEj9g338KJ97Ghlz+ZKGqo+IYMXo6Ka9QMy 9h4AMFhiH/S4qUbOCIMCdOJ4jiO4d9241fU/44iY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Lalith Rajendran , Theodore Tso Subject: [PATCH 4.19 060/229] ext4: make ext4_lazyinit_thread freezable Date: Mon, 24 Oct 2022 13:29:39 +0200 Message-Id: <20221024113001.027446839@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747572782129371097?= X-GMAIL-MSGID: =?utf-8?q?1747572782129371097?= From: Lalith Rajendran commit 3b575495ab8dbb4dbe85b4ac7f991693c3668ff5 upstream. ext4_lazyinit_thread is not set freezable. Hence when the thread calls try_to_freeze it doesn't freeze during suspend and continues to send requests to the storage during suspend, resulting in suspend failures. Cc: stable@kernel.org Signed-off-by: Lalith Rajendran Link: https://lore.kernel.org/r/20220818214049.1519544-1-lalithkraj@google.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3112,6 +3112,7 @@ static int ext4_lazyinit_thread(void *ar unsigned long next_wakeup, cur; BUG_ON(NULL == eli); + set_freezable(); cont_thread: while (true) {