From patchwork Mon Oct 24 11:30:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8822 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp431271wru; Mon, 24 Oct 2022 05:43:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5fUxrxqzGy2053re4ECGqZsYxg0SzlM0MhCsMS7KMXck8hURxUPXzqk/hLvdmXtjCXAugj X-Received: by 2002:aa7:804b:0:b0:56a:ecab:e86a with SMTP id y11-20020aa7804b000000b0056aecabe86amr16206906pfm.40.1666615401872; Mon, 24 Oct 2022 05:43:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666615401; cv=none; d=google.com; s=arc-20160816; b=bCHp/KWJSozFDTIOb1QP/+Fd8sEjehEIHNFmuqXfZ1X6NWwk41J52FEIwhffEbWanj +6Q3rzMkeN2ePj4U4NFbHAJvBV935bDZI0bR3PnIUxqrzNwtOGCOAKXRewPQTr6BJ9Nl 6iwmCrkz18kCz8KKAnAcidhVpVBS6Ml23n+K3NEEakXgz3HuHnCGV8WYjb5pid2YjjAW hnxoGP7ySN2BHDlhnk5cklh+H5ziKvovpAjM53sRdq6EWux96C/TmeVQIYg/QuNLSm2i rpwzv0Upmcr0c7pHAX6sgnwHL9Cmq90HWmss7cG2bSWCG4OUOnQF3avitaaPo51SK3wR y3IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F2D8qWkAFjmj9aOPFnI1ohFLrF4OGWiuqNUGEqJJjjQ=; b=an5SjSyBId/rhOaIPKZ1kWY+jpSbyQWG45nZCjbJY3DVZeA1YIFNdTjtPNEK/ZhmAe eoXEWBu1zM+IzQxLZZ+O4+J5Gv2nmzh6cZrvYtG8BrRZB9dRj0y6T5Vza/JHzqypWhs6 GcfZgwq9imAcVt/ZGDp5t1IVH6jaIW7o/LCpfzmp08Q5EGMrKddFyO3mdCfrIvqu+0GA waRFuODhCPoBfQG7zX0Ynz/6Qc+VLMlfr1qcoyI0qZUnEv3vOClnMVOVzjw6FUfcZ+UJ 919sHQAdFIvEFvlNqQCD//N8cYq8fTmvPAJK+ktyKT80cszqzFTFNfpVjC3ZCbxx+Bz3 UIGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nT01TS7F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ot1-20020a17090b3b4100b00200acd39846si21066683pjb.63.2022.10.24.05.43.02; Mon, 24 Oct 2022 05:43:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nT01TS7F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231804AbiJXMg4 (ORCPT + 99 others); Mon, 24 Oct 2022 08:36:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234427AbiJXMaT (ORCPT ); Mon, 24 Oct 2022 08:30:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B74DC88A03; Mon, 24 Oct 2022 05:03:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ADDB2B8119C; Mon, 24 Oct 2022 11:50:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 095F5C433D6; Mon, 24 Oct 2022 11:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612234; bh=g3xurf+26Zeho2T4obK1FAu9yl7PM0ykkt9q2gqZ0KA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nT01TS7FXF4GjdHy82PMDqIaLLvLYJlci5LJWd9lSJvN1WoJL2nhyibYQ9Kr5Ns/Z Oe/fFkZA0ZsXgw32c7d+8G1N9s5/11FrZTlaj6tPv3QXJrDl9w5H5EPEYj1uDZTakr ICm2v90u8kQ6vCTGsoKtRoWa2bCjc5gHqs8AFf90= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Stephen Boyd , Sasha Levin Subject: [PATCH 4.14 120/210] clk: tegra20: Fix refcount leak in tegra20_clock_init Date: Mon, 24 Oct 2022 13:30:37 +0200 Message-Id: <20221024113000.877227186@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747572911628957176?= X-GMAIL-MSGID: =?utf-8?q?1747572911628957176?= From: Miaoqian Lin [ Upstream commit 4e343bafe03ff68a62f48f8235cf98f2c685468b ] of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 37c26a906527 ("clk: tegra: add clock support for Tegra20") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220523152811.19692-1-linmq006@gmail.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/tegra/clk-tegra20.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c index 837e5cbd60e9..4c9038e73888 100644 --- a/drivers/clk/tegra/clk-tegra20.c +++ b/drivers/clk/tegra/clk-tegra20.c @@ -1101,6 +1101,7 @@ static void __init tegra20_clock_init(struct device_node *np) } pmc_base = of_iomap(node, 0); + of_node_put(node); if (!pmc_base) { pr_err("Can't map pmc registers\n"); BUG();