From patchwork Mon Oct 24 11:29:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8744 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp427304wru; Mon, 24 Oct 2022 05:33:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4bOBLGmZn7xQsNws1fXT1V9WJ9QZzVUejH6Cx2tLKaEUwTzkvl47cgidjlcvnnuPBibOB9 X-Received: by 2002:a05:6402:518d:b0:45d:d319:2a88 with SMTP id q13-20020a056402518d00b0045dd3192a88mr29717707edd.35.1666614801206; Mon, 24 Oct 2022 05:33:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666614801; cv=none; d=google.com; s=arc-20160816; b=zT7mzwnb6mOGTnJf7vcycY/T/i2wTnmpT76+1JlZJDC5cll7XI1+T6JQgFR7BYEQA2 EPHDO/WWfxJ5ICAnovxMQb1BMjDZjHFK+s8kpnWlWedV7KG4hOxqdKci6retSwwsKJkS o9mGJSSs/Go9dcYa5KcUe0fHaUMe/MfSKpf751WYTpC/u2ia6bdOZMKco/2X2zBf4YKD L9PwM//EDaJMMyjsLP08wMGWwC90GFsTU/NqOkhSLvKz+BXggwX5NgcTlnMAZvWSbv8X RZjk+B0y/SjFVoajNmVxZCFaZfNfm5mRVYKTE7RuMazhkOiC1V9Kg7f4yp0brCzIaepy xdhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HG+enwRiIuEkJiHM3XIDjJbjIVnHKm+FiM8QnTd6IYs=; b=DRLXm2wBkclm4XeISoCg92nmENzpP1atDP0+C4j3f8a5l9u7oQ1w/CA6BRYa2daGCy SWnlHAFwH2du1aUTctlRPiFn2guLVnUIkIpVFOrahoLnizE7ndKW3KZVeDADlGF0PZC9 /5xD1fjoxdMtUi+ULQnmAn+G0yXR1RsWPfLVmMDx4DvBiKnnFh4CmhD4Ky7lpBQ5NNOP wcZkYG60YylOmBbQnA6/t4I1IO5qTKn4OAG1ROpA8ouOMWrwrZkikQFVHKaZ+lOpEHI3 JsfwrYkIbVU9PM7IqDUwl51EgNpsdfQXDkIMQISFrCM6UwAR20NwXeYB3F5eR0QFFgBH 8B5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=G36qwIvB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp28-20020a1709071b1c00b0078e27f2ef4bsi27011634ejc.956.2022.10.24.05.32.45; Mon, 24 Oct 2022 05:33:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=G36qwIvB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233728AbiJXM2F (ORCPT + 99 others); Mon, 24 Oct 2022 08:28:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233200AbiJXM1F (ORCPT ); Mon, 24 Oct 2022 08:27:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5B087C308; Mon, 24 Oct 2022 05:01:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 759B7B811DA; Mon, 24 Oct 2022 11:56:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD01DC433D6; Mon, 24 Oct 2022 11:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612569; bh=Z3gWvSE3fw+Ff54MumYb9CCVjoFOZxUJC1XFP/tVtqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G36qwIvBX2a18myutdbA8J0fsC2lgryl8RQylS5jvy5g0zbLD92rvssWcZo+JjKZM 5P/5P9jEJidVCOSyanlaIY1d20DOOVZEXI8cjp+33GG3xBmMvXyvlXXso99XIVYoUG jsScRMN+BndTQYYEj1hX648V4FZqeUcxELIjf14c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Callum Osmotherly , Takashi Iwai Subject: [PATCH 4.19 036/229] ALSA: hda/realtek: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 Date: Mon, 24 Oct 2022 13:29:15 +0200 Message-Id: <20221024113000.275548420@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747572281491524878?= X-GMAIL-MSGID: =?utf-8?q?1747572281491524878?= From: Callum Osmotherly commit 417b9c51f59734d852e47252476fadc293ad994a upstream. After some feedback from users with Dell Precision 5530 machines, this patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK. While it improved the speaker output quality, it caused the headphone jack to have an audible "pop" sound when power saving was toggled. Fixes: 1885ff13d4c4 ("ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5530 laptop") Signed-off-by: Callum Osmotherly Cc: Link: https://lore.kernel.org/r/Yz0uyN1zwZhnyRD6@piranha Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7081,7 +7081,6 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB), - SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),