From patchwork Mon Oct 24 11:30:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8605 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp419652wru; Mon, 24 Oct 2022 05:16:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7UhfqQj5XKe6WqrAHgnLtIoKXccdDW2VRO1aPfLOS68Fj1KFEo1lvFHFvYL96D8Y/27RJu X-Received: by 2002:a17:907:3e02:b0:782:1267:f2c8 with SMTP id hp2-20020a1709073e0200b007821267f2c8mr27336432ejc.585.1666613800251; Mon, 24 Oct 2022 05:16:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666613800; cv=none; d=google.com; s=arc-20160816; b=W8ftfnHorUxWWK+DV2p6Yc9Mdk590oYdO33+zYUx8PDVrzlcH1shlWw05tUMgCzytU d9QYZGne6Tu1TvF7HplVwhTxaNRcQGYpvgTlG2dDJ9AmgHinY2GAo/XmbShawC/1aaop DuNNXkzQVqi/zUuGPaOlGyTxF5uLt8R8Vdxg+qyXhPQhT3kV57Wy5mVjGwvCcnXqPR2J HQZyX006fB1KCLsgOwzz1KZTVr/yXiq2KJbhDNf9C4UQFvoLP3Wo7GxU9jp4/QrjNgnl qya0YG6Ao4BK2sQxXXIpIllqNKls3aXVaXiD4bs5Q9Yc4XACDodbB+g4iEqKfYKdFnlm f0qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4Qnfj47+QNf3DxBDgR+TVIlHZMxx2mjq8qryU69trWg=; b=J7ycnrSED4icI+MRSIA9wbljjDnFHFRv073Ch3gnaQRqD6qtIhjwMJh6EsJUaQP/OL E9TOzwl0gYpq/uHIdKwJ+oPZmCDR9lEYu+DH/PE1PRcn7dfTFiC30D9tJBCmJkjEbWLn cVx43lvrR0LLZ/DY61LAxCsBfgLnwEuv48X8rUeqzQA/05f8a/nJfGjhjuoKTmYbhGzm Lw9lDFUaKI46rX2aW7IMtJBHsLCerGxVeTzQtrbRNr2nJQtPERInbhIwyeu11c+jdK5G UWSF8r7h3BU3PzR8jkxGD4HfWmoRBAq660XvjN9YoS4387STiTwA4rwGbuVNsd/mpLvm AgAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eidavOWb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w10-20020a50d78a000000b004539b045326si27887425edi.417.2022.10.24.05.16.15; Mon, 24 Oct 2022 05:16:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eidavOWb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230457AbiJXMIX (ORCPT + 99 others); Mon, 24 Oct 2022 08:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232646AbiJXMGY (ORCPT ); Mon, 24 Oct 2022 08:06:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15817CE3C; Mon, 24 Oct 2022 04:51:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D6F161252; Mon, 24 Oct 2022 11:49:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C4CFC433C1; Mon, 24 Oct 2022 11:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612149; bh=7oprHukz1adrqSLylbHEoWFbiFBfSQ7jdLdNL0ESvJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eidavOWbKMb34Fw76la0PPCthx/v5ls1hLSQ6MyfUMB0Rhx52sZlXY/I9BBDeIJCF +QqUJz0b61aq+QJaJWFJbpOThDH3WZyreIP4v3krp7QPGIB1zH4LaIBpwIgx60XVHN jeAGJ6VLfvjz7vTi4aNwnBmRDw7HPXFPqkV7452w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bitterblue Smith , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 088/210] wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration Date: Mon, 24 Oct 2022 13:30:05 +0200 Message-Id: <20221024112959.901013860@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571232398619442?= X-GMAIL-MSGID: =?utf-8?q?1747571232398619442?= From: Bitterblue Smith [ Upstream commit e963a19c64ac0d2f8785d36a27391abd91ac77aa ] Found by comparing with the vendor driver. Currently this affects only the RTL8192EU, which is the only gen2 chip with 2 TX paths supported by this driver. It's unclear what kind of effect the mistake had in practice, since I don't have any RTL8192EU devices to test it. Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts") Signed-off-by: Bitterblue Smith Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 7cace68ef3c7..a287c28b38b5 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -2930,12 +2930,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv, } if (!(simubitmap & 0x30) && priv->tx_paths > 1) { - /* path B RX OK */ + /* path B TX OK */ for (i = 4; i < 6; i++) result[3][i] = result[c1][i]; } - if (!(simubitmap & 0x30) && priv->tx_paths > 1) { + if (!(simubitmap & 0xc0) && priv->tx_paths > 1) { /* path B RX OK */ for (i = 6; i < 8; i++) result[3][i] = result[c1][i];