From patchwork Mon Oct 24 11:29:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10297 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp654329wru; Mon, 24 Oct 2022 14:12:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6JSGQfHPgUjAVUakdtw3adcdADjQR+3e53ub7YZdSM+qB4nA82QqWRrMxGhcK3ktspAxsE X-Received: by 2002:a17:90b:2741:b0:20a:ebc3:6513 with SMTP id qi1-20020a17090b274100b0020aebc36513mr41518200pjb.29.1666645919857; Mon, 24 Oct 2022 14:11:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666645919; cv=none; d=google.com; s=arc-20160816; b=t24nzQsuxCCJ6kmhpYK8fWZFfgMl390O/XtjpYcShV5X0YCV+Bi0EecAzr+WzvzMH0 ZyzFoFQYJUZFyUm4n6WHMqEk1vGiS38D/mT8KPnXGPGfVrMSvkQAnqDN1tDNvMDs7xvc S8VWJSMWgfsr4hjkOPdswg+XlYLtOcSC385JMT8iU7X7UxOlpNwMrnPN2jd0Fry75Yqa 4HGr/3IooiPt8KScb/pJqMDyLTll+atr5NTlSCkq0h3uVriCNsxCnjCjiSRP8paDMLHm B/JQOn2Kh4PC7/RXYv9pJByaIH6+Ht+zgZlnDQ9qBLUv/jez8FvKPFpPLIpm3xL0kbfY PNjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=r66xg6lfmnt2LWIH7rWF9mXF3VBGFssYCnkEIGhOO3Q=; b=OmMT0XWoK3BsblyqGU37Q0u1DkexiY1K9jDmiF1IsAVaQfQwA0KrpUuwtPoWHnyGzo wd+DGWlrDQegwYCBDZBfL56P3gwzgBIPmisyVL7r2QFdHHzykJPL9Iw5rylPr0+iPYbU 8WW6YrFnOTmCesriR25bNQ623hPxihlzlFHxSB6+YGlQbjPnZ1WINGp8FTTlpCf8/gBm GWLHfz3WdPyJ+A+TtLlDBnPI0Vm0X8XRJhCLNvdRTpFnYUvzvFmDID2a9H/DGUSZXCOz taoaKe873Z7gm/3nFH567Rl5By+XB6SXUGN2gEI+jGXRJNHicAQfadTClPHdcnpoDLKf gprA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mUhlY4kh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y3-20020a170902cac300b0017340861a6bsi503815pld.611.2022.10.24.14.11.44; Mon, 24 Oct 2022 14:11:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mUhlY4kh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233794AbiJXUxm (ORCPT + 99 others); Mon, 24 Oct 2022 16:53:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235126AbiJXUxS (ORCPT ); Mon, 24 Oct 2022 16:53:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C37C64C01C; Mon, 24 Oct 2022 11:59:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CFC4A612D3; Mon, 24 Oct 2022 11:56:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E66EBC433D6; Mon, 24 Oct 2022 11:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612614; bh=UOXF6r60LZMSfW1hV/2thug7CAKN/lJDdqAzbNeAB/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mUhlY4kh7jK3ctKy85nI9Sbx5s5mB5v1y4BArFu5siUY0TZk6WDJ+Kqw93xaxUp9C ckSFkbi07a903EkY6b/XWzWncEm1OFSqeBtlqD5UcC7WTeysqy/qNLHjvv38kWRA4w TTAe47oatNUZVtdpwdYujQpx3Jy8yK2JUT6iY0Gg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai , Hans de Goede Subject: [PATCH 4.19 023/229] ALSA: hda: Fix position reporting on Poulsbo Date: Mon, 24 Oct 2022 13:29:02 +0200 Message-Id: <20221024112959.895135654@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112959.085534368@linuxfoundation.org> References: <20221024112959.085534368@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747604912226323185?= X-GMAIL-MSGID: =?utf-8?q?1747604912226323185?= From: Takashi Iwai commit 56e696c0f0c71b77fff921fc94b58a02f0445b2c upstream. Hans reported that his Sony VAIO VPX11S1E showed the broken sound behavior at the start of the stream for a couple of seconds, and it turned out that the position_fix=1 option fixes the issue. It implies that the position reporting is inaccurate, and very likely hitting on all Poulsbo devices. The patch applies the workaround for Poulsbo generically to switch to LPIB mode instead of the default position buffer. Reported-and-tested-by: Hans de Goede Cc: Link: https://lore.kernel.org/r/3e8697e1-87c6-7a7b-d2e8-b21f1d2f181b@redhat.com Link: https://lore.kernel.org/r/20221001142124.7241-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2638,7 +2638,8 @@ static const struct pci_device_id azx_id .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_NOPM }, /* Poulsbo */ { PCI_DEVICE(0x8086, 0x811b), - .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE }, + .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE | + AZX_DCAPS_POSFIX_LPIB }, /* Oaktrail */ { PCI_DEVICE(0x8086, 0x080a), .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE },