From patchwork Mon Oct 24 11:29:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8585 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp419194wru; Mon, 24 Oct 2022 05:15:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6qj4+ydugSc1jNoAlqNcG17qK+DsD5X7uzJ2zhBK6RsvL/x+2q/s1GWg2AsqzZOdhq6qr1 X-Received: by 2002:a17:907:97c1:b0:791:98b8:9ab8 with SMTP id js1-20020a17090797c100b0079198b89ab8mr26396176ejc.425.1666613752527; Mon, 24 Oct 2022 05:15:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666613752; cv=none; d=google.com; s=arc-20160816; b=Uo7l5b9+pn2Lkq9mHUZjUPnQaI2Vdv/oYmUaGEEiuDH0WbDG63n0BrJybbxbejugbu QZz8M1ep/c5aGgB6EV7zEIYMlee9vqRSG9+8C7f4oKfoL1o7MewpJsixDOIC8w4oQVgN 7a+skEGpFGprIBnWXp1QCkKk/bK3yHUZyvu/Dv33Fdd9Lfvr4LBqD2rhUfWRGcq2llSi w3qD9xEeQ7kewHAKiTAdQhh4dDENJjtQ/ewShA1qyTeKbxPYZt5n+RfT2chUrP01skPy Md0XKyVt4TbEPJ+YJChX6sJD4Wd6nMR9gB1UezvPG26GiDRk93UpTY1AO5gXaM92eeQM Pwew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4g+UCgAa4jDAMfNpZkbdRRbnc9I+ZBAsUS8coRv62xA=; b=bNJGp2HM3UO5Vm3AKnd+iYvZcgouXMblFWgwLuMKSBykuyh1FWBYsVz6vxOeHPUhFu M9f7WzCbMPllJ5GycDd1ncpkiUiz8iN4H9Fbbu9jUMfcra2Pxrz0n28lNR0QtGUJFDbz 3imjXg75R00xkiYvbdOmfV7JA1WP54JSD03tcvoa97Nr7tSB3bMp6t8fVAvfg00j6asa XDRvwtrmI112T37gHf+7SiDxNdTFjTiuam/WU9wGlA8t2+svq7G9uUsD+nS76Kg3zuLX zI3b9Rhbm51p8NhQjBC73LnbFT6eCDrQvDNNiObAEuovvRIN6+cYz06BheJ4bXC7hruJ 9LZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SD64py0F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o5-20020a509b05000000b00456dc5c7346si23336080edi.97.2022.10.24.05.15.27; Mon, 24 Oct 2022 05:15:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SD64py0F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232700AbiJXMGt (ORCPT + 99 others); Mon, 24 Oct 2022 08:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232909AbiJXMEh (ORCPT ); Mon, 24 Oct 2022 08:04:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC66263D0A; Mon, 24 Oct 2022 04:50:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 17638B811BD; Mon, 24 Oct 2022 11:49:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67101C433D6; Mon, 24 Oct 2022 11:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612186; bh=wPT73C7wz0wOnYYzNDbw2GNECMcxZOHB770mS52PGjY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SD64py0FAiV7HGu71D0Ebc1MqD9gvn7p1+xn4UN+LGOLzRcowRb/snb9EU3vE5bdK Fw5A4Ja0NWU8qtEYLQmA9iFcwjyGwPePYuceSY0lvX0uL34Ur+7dmym5ZdY6X6zA6t 4pYSrADCtEaVUobGI7Oo0gFOFnuNnquCmj75afNw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Jinke Han , Theodore Tso Subject: [PATCH 4.14 071/210] ext4: place buffer head allocation before handle start Date: Mon, 24 Oct 2022 13:29:48 +0200 Message-Id: <20221024112959.364329797@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571182138699846?= X-GMAIL-MSGID: =?utf-8?q?1747571182138699846?= From: Jinke Han commit d1052d236eddf6aa851434db1897b942e8db9921 upstream. In our product environment, we encounter some jbd hung waiting handles to stop while several writters were doing memory reclaim for buffer head allocation in delay alloc write path. Ext4 do buffer head allocation with holding transaction handle which may be blocked too long if the reclaim works not so smooth. According to our bcc trace, the reclaim time in buffer head allocation can reach 258s and the jbd transaction commit also take almost the same time meanwhile. Except for these extreme cases, we often see several seconds delays for cgroup memory reclaim on our servers. This is more likely to happen considering docker environment. One thing to note, the allocation of buffer heads is as often as page allocation or more often when blocksize less than page size. Just like page cache allocation, we should also place the buffer head allocation before startting the handle. Cc: stable@kernel.org Signed-off-by: Jinke Han Link: https://lore.kernel.org/r/20220903012429.22555-1-hanjinke.666@bytedance.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/inode.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1309,6 +1309,13 @@ retry_grab: page = grab_cache_page_write_begin(mapping, index, flags); if (!page) return -ENOMEM; + /* + * The same as page allocation, we prealloc buffer heads before + * starting the handle. + */ + if (!page_has_buffers(page)) + create_empty_buffers(page, inode->i_sb->s_blocksize, 0); + unlock_page(page); retry_journal: