From patchwork Mon Oct 24 11:29:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8592 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp419316wru; Mon, 24 Oct 2022 05:16:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6PLZ3Jt4/pZ6H2XAsAAGB9M2iuiNCSa7i8AVqYTNJoSTzPgfgJU+euhLsRbZD+f1+sGljv X-Received: by 2002:a17:902:ecd2:b0:186:907a:a008 with SMTP id a18-20020a170902ecd200b00186907aa008mr10853093plh.112.1666613765566; Mon, 24 Oct 2022 05:16:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666613765; cv=none; d=google.com; s=arc-20160816; b=NqYihJ4DdgS3zx11WckrxQXyGxfFlisOmU3uoikryiXB0cZDmxsXYeeUs8hVIb1S7A MZE4PhITqdyWo8Mflvvdk49tiGP+hAMXVij+z6jTzNj8e5NyMqfOBtyP2EpWc1wL1LLo XyLMcJN7eeXr3R5KNqrcc5hToI9bUImdvAe2wrPvegKdshPY6rtWBwcqgFi1zeGxd4SY 438sXzkGgKxYbamQtZYfa/WAT5VunHCWxijCmOY/1IdF80c0QZewzwy8uG4MkwMyXeH9 sL6WzHUJ7r9kajpp1vGkyHrA/qaZVVDngDs+4XxWvCMWP4GaA/ggcWffwjhxEcsMhIft CEpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6l8W9BknssCYtsfH0x5+Qwl+hKxZPKsyyfHKEM30Svg=; b=IJK25NF2FbBaBfKJwrihiB/ph/CbuPBq5o6S1Gqo+0DiRdTgmK1+Ws1cSWbKm/uY6T e1E6soKSuU7hVshsNu5xKfBN9yxELgNewbmhhHFcJZSbx1TdKRvrfkWJyI3xv3Ycyw5S oxyNCiru8uM1gjdQia5mwt+42aC7BZSQEP/yoZGpNV1VeApRPbfkVwL6ru4c9Z5hjs+T e3UDSYBpHSGDD+rcmb2SHCMjiuI1ojShIgpMwNMWP32TukaWz+VmZFQ1yXNCko2L6PUh HMJxl1FQAG2HfI1a+euXCBYFba+Rq85FEVwvg4t5tSUHQKss/aZTK/PR9ZTNIUpIFrsM rz5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TyhXCPTa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c3-20020a170902d48300b00186a592183fsi4210050plg.365.2022.10.24.05.15.51; Mon, 24 Oct 2022 05:16:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TyhXCPTa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232515AbiJXMF3 (ORCPT + 99 others); Mon, 24 Oct 2022 08:05:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232559AbiJXMDD (ORCPT ); Mon, 24 Oct 2022 08:03:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E14423EB6; Mon, 24 Oct 2022 04:49:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4A8061290; Mon, 24 Oct 2022 11:49:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C878BC433D7; Mon, 24 Oct 2022 11:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612184; bh=6r7DvksVj6Eagna1spU2oiIU7PrPMrYurWR9NshWROo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TyhXCPTahdQh4sVAiPDWXGzYoC7/8xYBLWAUVp+e/5zy1bZtvDI65kDxOn0kwt2KD ok6vhaC72UMQiWFvmnghf/SP9qcJTcmn4JknYmtt5E8fB+6J1Taww1a/i5zaf+RusX IBS1XZUgyeJ/FR7d4pNyWPxjRL8wevOPg05aqMp0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Lalith Rajendran , Theodore Tso Subject: [PATCH 4.14 070/210] ext4: make ext4_lazyinit_thread freezable Date: Mon, 24 Oct 2022 13:29:47 +0200 Message-Id: <20221024112959.332977521@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571195861138331?= X-GMAIL-MSGID: =?utf-8?q?1747571195861138331?= From: Lalith Rajendran commit 3b575495ab8dbb4dbe85b4ac7f991693c3668ff5 upstream. ext4_lazyinit_thread is not set freezable. Hence when the thread calls try_to_freeze it doesn't freeze during suspend and continues to send requests to the storage during suspend, resulting in suspend failures. Cc: stable@kernel.org Signed-off-by: Lalith Rajendran Link: https://lore.kernel.org/r/20220818214049.1519544-1-lalithkraj@google.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3037,6 +3037,7 @@ static int ext4_lazyinit_thread(void *ar unsigned long next_wakeup, cur; BUG_ON(NULL == eli); + set_freezable(); cont_thread: while (true) {