From patchwork Mon Oct 24 11:29:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10121 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp633215wru; Mon, 24 Oct 2022 13:13:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6HoMiMFUwTgSQ/3tt8fhjuI/T3ckiNvBR30maEwKZU40D9HWp/A0tKxeCjjBheHtSlggd1 X-Received: by 2002:a17:902:b092:b0:17b:833e:74f7 with SMTP id p18-20020a170902b09200b0017b833e74f7mr34658905plr.149.1666642426653; Mon, 24 Oct 2022 13:13:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666642426; cv=none; d=google.com; s=arc-20160816; b=Cl5Vp/+PxftcZ+oZMeSs0qEN052UPcvJKgeZqc07Ml3Cn1PaCAHsGuzdWU9kZuQjru EVYGRd51DKjs51kVgG+OMJ+WZAYEW1MEqh792j+XdXe0OpVDudKvT3yzODP6NXMTdLzc NCpBev7R2WmP+jIMwRsz8YvxmIWyyxGItQZXBu22m4lwbyRYVmKwTOKPI739inHaoX4S va37awz7Db974K3yZLuGXKZQtyTpOh02MkqEhu3oG8eSwh5b9kD5vqxFBOn97IdqWF9t 4nVfq08wQZRBk80fLWo+Ps4x2Ys/xYqTU2iPyYOWcpo2TQ/rKBgcjCTIL2AfGzBsGHTi sDtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pYATm8vVwky0TKbzJPwm0ATIjYIV68nSbyqnIuG0Cp8=; b=x4v2wm2K+fdreTtnhWJG60hInyAalYNFdQdSx9ugtW3yC9HAKVifK+b+22TWw7sNQ9 +ecPZ9WLozJqMyeUiBJ2lwF7SjI3M1ke/1JZ9MgWDA121Fomz0s5FIbZrFTPywZfZHkF 19bBCl4xlrlC2WUqTDcHiaFAXDeHgFBFBYBOX5deyA788MR3E+O5p0XV0bb7wNbXEb7F r/MHoMmyCKtTdhBfiQmSMxwHFJg0JPEuItWP+qwBe9S21rnCZveU48m0VdCiJIzE7G4W kT3OrUOYZYkU+CTK2Nxip5ePluFj3EcYa3gNt0vhFGadjKg5XsmQvhLF5hMLJ6AmVrtH kD9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=R4Fl6gLK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020a170902ed4400b00176a116a20csi369438plb.567.2022.10.24.13.13.33; Mon, 24 Oct 2022 13:13:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=R4Fl6gLK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231178AbiJXUBS (ORCPT + 99 others); Mon, 24 Oct 2022 16:01:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234286AbiJXT7h (ORCPT ); Mon, 24 Oct 2022 15:59:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 896ED103273; Mon, 24 Oct 2022 11:22:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DEE6CB811AE; Mon, 24 Oct 2022 11:49:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 390E9C433C1; Mon, 24 Oct 2022 11:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612181; bh=eiIRWIwuYaAIX1wQZXkNK8DBAUTM4kPb6uvUgm1yFkk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R4Fl6gLKFBy88bE+9evStcOJecRSztNzsUqUwpM/phqcPgxVq4I+kSoZeXSGHUBan qv+mWGvjs43LTgjH7FnHDuO/vbVeW58ICh2Yizd56Iob/j6a4RQAot7AurYdCdr48j IPGnoZ/frk8nN1AYRf1yhUzceI2wbZ3WgrtCzUIw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Baokun Li , Jan Kara , Theodore Tso Subject: [PATCH 4.14 069/210] ext4: fix null-ptr-deref in ext4_write_info Date: Mon, 24 Oct 2022 13:29:46 +0200 Message-Id: <20221024112959.291852310@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747601249357759946?= X-GMAIL-MSGID: =?utf-8?q?1747601249357759946?= From: Baokun Li commit f9c1f248607d5546075d3f731e7607d5571f2b60 upstream. I caught a null-ptr-deref bug as follows: ================================================================== KASAN: null-ptr-deref in range [0x0000000000000068-0x000000000000006f] CPU: 1 PID: 1589 Comm: umount Not tainted 5.10.0-02219-dirty #339 RIP: 0010:ext4_write_info+0x53/0x1b0 [...] Call Trace: dquot_writeback_dquots+0x341/0x9a0 ext4_sync_fs+0x19e/0x800 __sync_filesystem+0x83/0x100 sync_filesystem+0x89/0xf0 generic_shutdown_super+0x79/0x3e0 kill_block_super+0xa1/0x110 deactivate_locked_super+0xac/0x130 deactivate_super+0xb6/0xd0 cleanup_mnt+0x289/0x400 __cleanup_mnt+0x16/0x20 task_work_run+0x11c/0x1c0 exit_to_user_mode_prepare+0x203/0x210 syscall_exit_to_user_mode+0x5b/0x3a0 do_syscall_64+0x59/0x70 entry_SYSCALL_64_after_hwframe+0x44/0xa9 ================================================================== Above issue may happen as follows: ------------------------------------- exit_to_user_mode_prepare task_work_run __cleanup_mnt cleanup_mnt deactivate_super deactivate_locked_super kill_block_super generic_shutdown_super shrink_dcache_for_umount dentry = sb->s_root sb->s_root = NULL <--- Here set NULL sync_filesystem __sync_filesystem sb->s_op->sync_fs > ext4_sync_fs dquot_writeback_dquots sb->dq_op->write_info > ext4_write_info ext4_journal_start(d_inode(sb->s_root), EXT4_HT_QUOTA, 2) d_inode(sb->s_root) s_root->d_inode <--- Null pointer dereference To solve this problem, we use ext4_journal_start_sb directly to avoid s_root being used. Cc: stable@kernel.org Signed-off-by: Baokun Li Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20220805123947.565152-1-libaokun1@huawei.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5601,7 +5601,7 @@ static int ext4_write_info(struct super_ handle_t *handle; /* Data block + inode block */ - handle = ext4_journal_start(d_inode(sb->s_root), EXT4_HT_QUOTA, 2); + handle = ext4_journal_start_sb(sb, EXT4_HT_QUOTA, 2); if (IS_ERR(handle)) return PTR_ERR(handle); ret = dquot_commit_info(sb, type);