From patchwork Mon Oct 24 11:29:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8705 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp422940wru; Mon, 24 Oct 2022 05:23:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4D630OPCazMdfYwqd08pr51HaHjNcZyfchKs9lwrAZgFqIZxRiQeTPLyzUEgM61g/nErRP X-Received: by 2002:a17:906:9fc1:b0:761:9192:504f with SMTP id hj1-20020a1709069fc100b007619192504fmr27781010ejc.116.1666614220997; Mon, 24 Oct 2022 05:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666614220; cv=none; d=google.com; s=arc-20160816; b=CT1/ysnsfG7cjstGgZKUN9XBw+ICkAA4uWobtcgqFU9wqyE7AblrmN7ScfXqk1CRPn eNwE3UfB/dEabM8HxFGCNCxx9tCCqmgPY7a1wpyDdD9Ld46sk7xHUTnzAduHN6duiV04 PjI6rvt8PZZ8vA8bbFYHAvRmyAhIhCJ0IMB78axO4ROqXgrLCkQWUkYHddE0uBpeehtS 9PFOsfB1aB4Eh0w8wX+ZwnD4SJHYBkpL5J6XDYCXMyb4E9yM2MBtJw0sBFdaYktMiPaf 1TEjkxmlTpdN7cEGDC12pqjOB2azqGAuoNrXNm5Q7peD7wicvqAETqXlqWiOTZRo7B+R nPhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hmXdpMxOmd4MJuzvpU/cDsAiYsy+E2+329gIPH+Djks=; b=gJFOe55X+VGF0xdlQLQcUwW8/GcWmOQEZhnswYongjbXyxRz3GEAcMT5/5rzNFeumd U1o2ViU6W4tZCd5s30zegGlAI8miW4iSVqPqBvWkupAQ8090mLdqXvqF9qQCZ2bZKJh6 sleQ5aBpKvLfNY29waH1C2Bf5CCFRzB3do1bjddLqF+kdPjbKJlI10bV2g7v8NRc3eT9 ig3hdqxS8NVLqilT7a3YQHXcVLffdpllGMghy95Udhj5Do6DC0TvqdJLo+VC6b0NtKzC CHU+V2wt7dBpd3jnt4Bg5BmoRMZuNctjUgVBes7jhcxpohEO99mpV4+rV/m4RWJD929u 0+Dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MLjjHABW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z16-20020a50cd10000000b00457ebe79577si26454676edi.623.2022.10.24.05.23.16; Mon, 24 Oct 2022 05:23:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MLjjHABW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233495AbiJXMW3 (ORCPT + 99 others); Mon, 24 Oct 2022 08:22:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233017AbiJXMUB (ORCPT ); Mon, 24 Oct 2022 08:20:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 143E77B2BA; Mon, 24 Oct 2022 04:58:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C73C3612D1; Mon, 24 Oct 2022 11:47:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9221C433D7; Mon, 24 Oct 2022 11:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612062; bh=Awcd/0SSmDN83dUDpNoaIq8lTcT014AjU8Qvxm5qHes=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MLjjHABWdhtW9WAWyU+HSDBLufPEEfEv9GZf6A5Wd9Ir5bT0TsVda5caUKDz53cm7 kUv7ra1VrYqq5YF+1ClkPJrOnLawctV1PYofcof9dTE7uQmuJ5qxCBj6QuPOK3iAlR h6Z0K0EAmA1Mzu1RYwtY+cWN0Gm2iHwoJrxxcTxE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Aring , David Teigland Subject: [PATCH 4.14 055/210] fs: dlm: fix race between test_bit() and queue_work() Date: Mon, 24 Oct 2022 13:29:32 +0200 Message-Id: <20221024112958.796344237@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747571673485988650?= X-GMAIL-MSGID: =?utf-8?q?1747571673485988650?= From: Alexander Aring commit eef6ec9bf390e836a6c4029f3620fe49528aa1fe upstream. This patch fixes a race by using ls_cb_mutex around the bit operations and conditional code blocks for LSFL_CB_DELAY. The function dlm_callback_stop() expects to stop all callbacks and flush all currently queued onces. The set_bit() is not enough because there can still be queue_work() after the workqueue was flushed. To avoid queue_work() after set_bit(), surround both by ls_cb_mutex. Cc: stable@vger.kernel.org Signed-off-by: Alexander Aring Signed-off-by: David Teigland Signed-off-by: Greg Kroah-Hartman --- fs/dlm/ast.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/fs/dlm/ast.c +++ b/fs/dlm/ast.c @@ -198,13 +198,13 @@ void dlm_add_cb(struct dlm_lkb *lkb, uin if (!prev_seq) { kref_get(&lkb->lkb_ref); + mutex_lock(&ls->ls_cb_mutex); if (test_bit(LSFL_CB_DELAY, &ls->ls_flags)) { - mutex_lock(&ls->ls_cb_mutex); list_add(&lkb->lkb_cb_list, &ls->ls_cb_delay); - mutex_unlock(&ls->ls_cb_mutex); } else { queue_work(ls->ls_callback_wq, &lkb->lkb_cb_work); } + mutex_unlock(&ls->ls_cb_mutex); } out: mutex_unlock(&lkb->lkb_cb_mutex); @@ -284,7 +284,9 @@ void dlm_callback_stop(struct dlm_ls *ls void dlm_callback_suspend(struct dlm_ls *ls) { + mutex_lock(&ls->ls_cb_mutex); set_bit(LSFL_CB_DELAY, &ls->ls_flags); + mutex_unlock(&ls->ls_cb_mutex); if (ls->ls_callback_wq) flush_workqueue(ls->ls_callback_wq);