From patchwork Mon Oct 24 11:29:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8535 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp416557wru; Mon, 24 Oct 2022 05:11:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4W9DBC2h/riK24BvZ0MXIusd8pHMR6S395x54fqNpT7GBXd3rqrSv7Nl7KzsQ7aXfA6MUB X-Received: by 2002:a17:907:a065:b0:78d:c5dd:45cf with SMTP id ia5-20020a170907a06500b0078dc5dd45cfmr27842566ejc.117.1666613513053; Mon, 24 Oct 2022 05:11:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666613513; cv=none; d=google.com; s=arc-20160816; b=yuko9XenlEq+NN/zBlCr2WwMhNrt5PHHvUivVBc7hGqr0Rmv+/tXiCaQxyy0Jqn7z1 WJ92qBOkGAH2pc72iEJoRWlsKaPL/LL+Q15pNmle/OKfEq3jsD/d/LYMIB1Dz9lqh+3e j/NRQS3W7LjqZbA8QhjtowRIhnTJMJsMWWrUIQVAV8R3gd7MyjOWUHsVvUGx2OWBiB5A 7+DpIuKSyBidDu1OHP11WI+2dDbj8UXHqPALOk6jyT+5e2yNTn+gQrFQOScCIvjHqMMg Fy3wsT6EDAxVm6WM2BvKyp3S4FIyDCPrIjrkhgusKSSJqNMsCIHtcsgOuVAmn9WRg1zi ufBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=I+ANAJpr+8wMKEpFCB+xk6Qe+OXZhGL2J1jehRPDRjw=; b=KbY9etOZSTHR+5IwcXZ4uvM8/UIXKs4nDLCWQZlakpzLjLqqDpc2kpY4nv9+UQsi7a Zw45ixMqiERuBG1dx5cjltre5V8Rq1OKvB9lHxmcH4XtHLwaV8IduS8zqQ3aFz6OXNhi 8wgnIpZogAfV8OYR4+YrYOMyBYDVuXA+QJpaZUIgNtLrWIoj5JwTzoL7PMjPPr29T1m/ tx8LhptjCxAQqQsqDl64RHBCoFU3qSpaE3gIzkgJ/ePfEyO3GRQ0KNbMyHhEjfLQ2Rcb eOhHQSBgPAriVbjIWI152lH9Yam5JaMUUdcNop3eAnPxeIPQG7zPAEvBNSAQbo1Bk3i1 1o0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mbct1K4V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l22-20020a17090612d600b007836bd283a5si26165154ejb.678.2022.10.24.05.11.24; Mon, 24 Oct 2022 05:11:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mbct1K4V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232392AbiJXL6W (ORCPT + 99 others); Mon, 24 Oct 2022 07:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232156AbiJXL4r (ORCPT ); Mon, 24 Oct 2022 07:56:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F10A7B29E; Mon, 24 Oct 2022 04:47:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9F12B8119F; Mon, 24 Oct 2022 11:47:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C6E1C433C1; Mon, 24 Oct 2022 11:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612022; bh=HcpGPCOEX3wCd/MN7AXOwedC+Kl55GIaCX/bTzIOc+A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mbct1K4VR9qd1EaMv8x71mfEl9J1qHvUahqEikOWK1pJqTCn5Gu0VMvDWPp8Skeeq DD+PMyUE3d+8TMefQ/Felj5paAOJWkFMWM4hIxRL9TMqzb7ppP+9B1xEOUyKq6r1ZU 6OtlJcAABUwI/+kVjSluGlMVlFAPNyq6704ZANbI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai , Hans de Goede Subject: [PATCH 4.14 041/210] ALSA: hda: Fix position reporting on Poulsbo Date: Mon, 24 Oct 2022 13:29:18 +0200 Message-Id: <20221024112958.323821272@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747570931078291200?= X-GMAIL-MSGID: =?utf-8?q?1747570931078291200?= From: Takashi Iwai commit 56e696c0f0c71b77fff921fc94b58a02f0445b2c upstream. Hans reported that his Sony VAIO VPX11S1E showed the broken sound behavior at the start of the stream for a couple of seconds, and it turned out that the position_fix=1 option fixes the issue. It implies that the position reporting is inaccurate, and very likely hitting on all Poulsbo devices. The patch applies the workaround for Poulsbo generically to switch to LPIB mode instead of the default position buffer. Reported-and-tested-by: Hans de Goede Cc: Link: https://lore.kernel.org/r/3e8697e1-87c6-7a7b-d2e8-b21f1d2f181b@redhat.com Link: https://lore.kernel.org/r/20221001142124.7241-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2571,7 +2571,8 @@ static const struct pci_device_id azx_id .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_NOPM }, /* Poulsbo */ { PCI_DEVICE(0x8086, 0x811b), - .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE }, + .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE | + AZX_DCAPS_POSFIX_LPIB }, /* Oaktrail */ { PCI_DEVICE(0x8086, 0x080a), .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE },