From patchwork Mon Oct 24 11:28:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8516 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp405553wru; Mon, 24 Oct 2022 04:57:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5DL3wlGNPeC0kngRehMeQnvoRjpyk75pFpeTNfMWWPFmMvzUlodzDi1ugCzhJaW0iJEk1v X-Received: by 2002:a17:902:ec83:b0:17c:afb3:d1ec with SMTP id x3-20020a170902ec8300b0017cafb3d1ecmr32893376plg.172.1666612625011; Mon, 24 Oct 2022 04:57:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666612625; cv=none; d=google.com; s=arc-20160816; b=huKH5aRWcI/Xpa9MNTy89JxFqwK9jiYW2ZdbCrJzT3DAOPqPvSlYE0jtZv85n94wwA ypJyCpqztDJ0Iv5pDXrKD5xS35jCgPcHLbds9NuG9cytIA/0B1ICClpn/tj4vwTdwlRD XXhwPtyyvY3p2RElwFd/uM5BC71YlktJNiEmFGnXwXzoeDQQN8baaVZtKgmGMaZCh92P FEH93saXkAeNJgl4DI3Hk2dkMBbCFfjFC67/TCI7Sf23LUz/qDMXf26ozIm4ZpVl9Zf9 3VuYsxxM6Xrunx1a7w/OgHiTf7ZYyKTsi9tl6Fo7UxNX1g1LLMossKPe+fp5HN6j4I7t 6MKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Hul2CTZhC61tJSyLLkhgvL6h8RAA2//lM7gTXPP5Vuo=; b=SeC0vU0GG571MyPq5NoJB3kOb1U79tBFUpwsxsS6/WZzSpPA74BtKkUKywUwltE7mB MXGmbJjeMe389y3kW2Mlw4QXAb3YQNuZBp00dSsdQKu6G7tBRTGEwZSSVYQWYQcDLyHz TlVZi+FN3o0m+NLF7tS+OMeqQ0wK4WdyDYD7MJ/5GPPjEgUE8zRA+8euzSC3z/3LGSMx NzRvGXEoefIg4yHO+G5QEACQqjBovYTpQFRrwZWT9yqP4wUFT+0GRRh64O0upCUEVbtr 7XbQI97e8NtP9vsNDwuQMlQ9s6Iric+W+Eu7JCfz1d87JL9+4Gk0gdlGUVnoZytft11b 0gUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AaAVAT0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h64-20020a638343000000b0046ef67cbb02si5151351pge.282.2022.10.24.04.56.51; Mon, 24 Oct 2022 04:57:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AaAVAT0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232180AbiJXL41 (ORCPT + 99 others); Mon, 24 Oct 2022 07:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232453AbiJXLyq (ORCPT ); Mon, 24 Oct 2022 07:54:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BD8D792EA; Mon, 24 Oct 2022 04:45:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5DA5AB81147; Mon, 24 Oct 2022 11:45:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA1A0C433D6; Mon, 24 Oct 2022 11:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611949; bh=If2haa2kx6bY4bNNHjk4aARkFQXvhLrsziM+tWJAtCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AaAVAT0njlsSwVwzUj0rNui1wuhRLODiST2P6hLy2V+LQDgBnEAPbvxypubr4Wy0k YVHCeZD/DgnSb1C8tSczry6jThehyRvkPwlMetFM8jChV2+GAgA5HNWrbWLAiJUCPd R/q3+LhyDZExnl3XPdgh5UsEDKL9zaFQpvhs3hTY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.14 013/210] Input: melfas_mip4 - fix return value check in mip4_probe() Date: Mon, 24 Oct 2022 13:28:50 +0200 Message-Id: <20221024112957.346870488@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747570000186802858?= X-GMAIL-MSGID: =?utf-8?q?1747570000186802858?= From: Yang Yingliang [ Upstream commit a54dc27bd25f20ee3ea2009584b3166d25178243 ] devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER), add a minus sign to fix it. Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220924030715.1653538-1-yangyingliang@huawei.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/touchscreen/melfas_mip4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index 05108c2fea93..633d7e1dc7d6 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -1469,7 +1469,7 @@ static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id) "ce", GPIOD_OUT_LOW); if (IS_ERR(ts->gpio_ce)) { error = PTR_ERR(ts->gpio_ce); - if (error != EPROBE_DEFER) + if (error != -EPROBE_DEFER) dev_err(&client->dev, "Failed to get gpio: %d\n", error); return error;