From patchwork Mon Oct 24 11:28:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8529 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp407254wru; Mon, 24 Oct 2022 05:00:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5CtOmQrWpfEbwuIk6vyiv2NFW5d+Iz+wKk4Xpa+5BcMRVZM3nn8PuYZphSZJhweQelgrdV X-Received: by 2002:a63:4384:0:b0:43a:18ce:f98a with SMTP id q126-20020a634384000000b0043a18cef98amr27553034pga.273.1666612851875; Mon, 24 Oct 2022 05:00:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666612851; cv=none; d=google.com; s=arc-20160816; b=ZjMsoibuAuc23hquHDsUCuLp7B8ORlliqseIXZmL4AsLd3bO0FNppj0wSCeGl9Cbq0 yyT8GvnqhmjKoLXw1NP0B/Wv11JTWO77vVGXQujTa04b7Po+uBwJxZy5lHUj8sv6C1Vh 1K59KJhsd9r8wrkNLTKyVi/8B3lj1Y+QYMztooXHk9BbvRLU3YllotmdBrpcoK5SmN5b PGhhEBi6H1VsKZaeoOKRVHnIWJ5eS8HdtobKOY18TgRyqtpMHfoFsr88sPT7k46J5MQu Vz8iPtqa5Ry29T1/lKKBOaAyrHPoQI0iY7jvsF/RrmNLrunGh5CqwB5OEDRC4h5l4XsI NzPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=b2vw60hTwtl0juR/YHg71uIm0oiq7ogGARyt/sljfn8=; b=Actt+873/PoE5t4h5K0kBy+MKPeT2r+Tv3a0EKqwcse7Rq/owPmC8GqnYkOESzScEZ 7dpSrcgxWRVzDBmhl0bhDMdMxdC4upuPNvURZsjh7yFCGeZEFmNx//RVcowoQjnsflnf xJ/1Uhrx+MBXqgQa3RNnwTUfLbkXsxp2J7hzL/pIqAkQwa5KlehWH2AnLERvDmIXhl3w AVhI+LjMmdcT+TjbSV50IiToDRbmrKHQysQ/FQhJpoft4VuPxtNUyJFsFyQ7pa64Zg4R D/LkP4Eu/amSKcEOutoO01igmawh/U3cy+rfZCihegXkwcdLkd6tTvsTYqPYuV+Cj3N6 jguw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E4v3Le2S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b8-20020a170902b60800b001789faa628fsi31803425pls.395.2022.10.24.05.00.37; Mon, 24 Oct 2022 05:00:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E4v3Le2S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232273AbiJXL5z (ORCPT + 99 others); Mon, 24 Oct 2022 07:57:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232272AbiJXL4U (ORCPT ); Mon, 24 Oct 2022 07:56:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A4D0753B9; Mon, 24 Oct 2022 04:46:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A442F612A8; Mon, 24 Oct 2022 11:46:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6B5DC433C1; Mon, 24 Oct 2022 11:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611996; bh=bGsZF3J1Px/N5/y/h70j0EcZc93RsYKBguiOqZV5QVw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E4v3Le2SSentTpk/bzXQ9/Yww4Mvt3PoK0r3QXuAfqZTno0aFDCGGZeLB4y96gEjG 8MBVoK20TSz8jck99knrI6xr/BWcg8A7sPVo67J6q97R9hwHGM4g6bSGg3Fq7ExXGp uW+LsptquHPpbLJCWDf5GVIVAiJhlJl6QYZZgttI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Stern , stable , Hongling Zeng Subject: [PATCH 4.14 003/210] uas: ignore UAS for Thinkplus chips Date: Mon, 24 Oct 2022 13:28:40 +0200 Message-Id: <20221024112956.942995048@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747570237989139672?= X-GMAIL-MSGID: =?utf-8?q?1747570237989139672?= From: Hongling Zeng commit 0fb9703a3eade0bb84c635705d9c795345e55053 upstream. The UAS mode of Thinkplus(0x17ef, 0x3899) is reported to influence performance and trigger kernel panic on several platforms with the following error message: [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled endpoint or incorrect stream ring [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 1b000000 05038000 [ 720.545894][13] Workqueue: usb_hub_wq hub_event [ 720.550971][13] ffff88026c143c38 0000000000016300 ffff8802755bb900 ffff880 26cb80000 [ 720.559673][13] ffff88026c144000 ffff88026ca88100 0000000000000000 ffff880 26cb80000 [ 720.568374][13] ffff88026cb80000 ffff88026c143c50 ffffffff8186ae25 ffff880 26ca880f8 [ 720.577076][13] Call Trace: [ 720.580201][13] [] schedule+0x35/0x80 [ 720.586137][13] [] schedule_preempt_disabled+0xe/0x10 [ 720.593623][13] [] __mutex_lock_slowpath+0x164/0x1e0 [ 720.601012][13] [] mutex_lock+0x2f/0x40 [ 720.607141][13] [] usb_disconnect+0x59/0x290 Falling back to USB mass storage can solve this problem, so ignore UAS function of this chip. Acked-by: Alan Stern Cc: stable Signed-off-by: Hongling Zeng Link: https://lore.kernel.org/r/1663902249837086.19.seg@mailgw Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -201,6 +201,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x99 USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, + "Thinkplus", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Hans de Goede */ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, "VIA",