From patchwork Mon Oct 24 11:28:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8549 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp417063wru; Mon, 24 Oct 2022 05:12:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM65Tl21VsDRFOp+cslM0XCW/rJ1vzFOItY7xl/F1+NDoJX7FMKFYQ6gghnB9Qqy9xoZ2JaC X-Received: by 2002:a17:906:a4a:b0:782:686d:a1b6 with SMTP id x10-20020a1709060a4a00b00782686da1b6mr27061844ejf.232.1666613554334; Mon, 24 Oct 2022 05:12:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666613554; cv=none; d=google.com; s=arc-20160816; b=XWHVvVx9bRax+ipBEdV1DzMUA4h8OLSGavCIguuPBh6f9F1gr7tMOYixciD877Nnv9 HsCsgHjNRPBZf22wbprSSelONWkQ3Xbx91OJmhlN0fIGRdE/w1q+/+cM5jbUUQuLXXjm GMTuX//2dhzCofR0le4tz7jVKpoEOoTb2bqWYfqcnECyTcLnvDIbCI3M2nm8oEsC9+mP +1W14cmFTpDIfBcMoM3OMluGfjVHFY4nLxzMAgL1DHSCD5/Gk1PVnOAE0Xj7dO/Jjx1n l1EHwMA2GJifNCgS5Bg0mtDd1iCjvSXcxv+3jwDlpbrnoq316wLIQBQ7sN+BvybHXDrV cpBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2xPDsIt+Ao/LoywEAsWG/tUQz9y9QuPAQju764Ol+xc=; b=Od+WwOPZVUjyKQlJ8jbGCDDGSs4OkSk7x95rtKAuZ9xMNqJLf2fp0JlyFIABWdtN4Y vlpmltoVGj+jhQSKPwsKEFNMTODlPZ0sL3U1pwihGV0r/danWBd5AUpqsZmsE2R36CuY QygCjuAY2H3s/yqlI7+LNnz3czd0JXLQw/GpU4mCPnNi41lxQB7DTBsoadzIggBSzmLb 9XsdZfIN/PcAQaZVtXvyFDj9bdLTUsQe/KfZom09g7grK0BHUHvro8//onBw9auTwyTl U0yjEJYk3wXvTmsExn9TlGUnXQiUGBai3bB1lDIMNXYbCGkQh5hUSr0gSsUscFAJJ9hG yU1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="SWI1y/lM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wt6-20020a170906ee8600b007aae0b30283si433237ejb.691.2022.10.24.05.12.08; Mon, 24 Oct 2022 05:12:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="SWI1y/lM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232449AbiJXMAz (ORCPT + 99 others); Mon, 24 Oct 2022 08:00:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232431AbiJXL6w (ORCPT ); Mon, 24 Oct 2022 07:58:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A11EB7A747; Mon, 24 Oct 2022 04:47:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DE064612A1; Mon, 24 Oct 2022 11:46:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00CA2C433C1; Mon, 24 Oct 2022 11:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611967; bh=WBnd2eNBW/mUz+GKBeaLTmL2wQBXursKCCUI3t17eqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SWI1y/lMF0pFIVGhUsxwrdLQAT1Dh0UISeZ9wCP/1CLVB0gPWXLTn1CwIFjata/gw 5b5wAj1M7JJGX2lZ3T7nceddmWuGw3qqiL+InjmAmJb2MN1aNzyXcBjmZMPTYt17LA TaqiNdL/0o78KXv9Fu1MvHK3gz1/qwwrSv5hFzs0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Stern , stable , Hongling Zeng Subject: [PATCH 4.14 002/210] usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS Date: Mon, 24 Oct 2022 13:28:39 +0200 Message-Id: <20221024112956.907522003@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747570974637923534?= X-GMAIL-MSGID: =?utf-8?q?1747570974637923534?= From: Hongling Zeng commit e00b488e813f0f1ad9f778e771b7cd2fe2877023 upstream. The UAS mode of Hiksemi USB_HDD is reported to fail to work on several platforms with the following error message, then after re-connecting the device will be offlined and not working at all. [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 inflight: CMD [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 04 00 00 [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 00 08 00 These disks have a broken uas implementation, the tag field of the status iu-s is not set properly,so we need to fall-back to usb-storage. Acked-by: Alan Stern Cc: stable Signed-off-by: Hongling Zeng Link: https://lore.kernel.org/r/1663901185-21067-1-git-send-email-zenghongling@kylinos.cn Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -152,6 +152,13 @@ UNUSUAL_DEV(0x0bc2, 0xab2a, 0x0000, 0x99 USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x0bda, 0x9210, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Benjamin Tissoires */ UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, "Initio Corporation",