From patchwork Mon Oct 24 11:31:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8518 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp405625wru; Mon, 24 Oct 2022 04:57:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4h5jxNDicAdYWPkB7S5o3kKUwZ07/l1YknSJ0/amGLG2XxRq6O9/BUIazlTfbWKSiv6Rfi X-Received: by 2002:a17:90b:17ca:b0:20d:76bb:3f8c with SMTP id me10-20020a17090b17ca00b0020d76bb3f8cmr71862887pjb.28.1666612631826; Mon, 24 Oct 2022 04:57:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666612631; cv=none; d=google.com; s=arc-20160816; b=wQp1OCjsUdXPYIeWDSL6eLBJgL5OmOEO/RTd95H93crEAxcW9V2R/jXIhtXNBDTb7D YZ8JRq4GGJ1t1II0ZVs+nCpXXSF71jM/sZrLSMtwAVzZ3nFvfu5TG4q8oiFSyOYWkjXi OVfMDoJk5Hu8q/WjRkYgBZSze5J07I/lihBUWICcfsCI0y7MiZOGPZlYTh9rI8RnTkhJ bxvAB32rqjXjLlYkh+K7SCiNr5DsnhUWKKaTInxb4vU2wHIKe6quajyxbhHQ7WyMjQNC 959QCS9yzDYnKYmyJY7ilvWeEpC2YdKC0LtSVkdnzS1GR0aGEZbTI96vbBeqkGNFnytZ 1dqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=De2Hw+cMRcAxJBxximsSc5Ym2DiT4zWZYtAMocw3X10=; b=gN4Aorck6ylppG4IiJMCoQt6rvI8jzYbG30SVzCpIsNinm/GD50wBgYdt9mAGP5Gls qsk+exOun/1aEqXIHNG6FX2H2K2u0dL/6nGKRknxPkWsiykF6Y8vha1VTqRajSNog1lQ f4dHJWUqVNrhF1Dui7+/KzDaUhVRgNPABU89NS1yDKIwAOoobvGfBL89Dc2hX1F8rOph p0xG3/tpMlBRtSIX2boSf1eijRYo4yYjfHcRYZhT3DG3goa09N1LO42XtcGDmD5+5ROZ JbxUx3kSjI63L2rZGp++HCLxljNrX8G/yQZOzCLHqWfnU7dDcnKOI2jjsbz3m6bkJpXH qDcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uBEgwsJe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m18-20020a6562d2000000b00439494dfd20si34744490pgv.202.2022.10.24.04.56.58; Mon, 24 Oct 2022 04:57:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uBEgwsJe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232284AbiJXL4i (ORCPT + 99 others); Mon, 24 Oct 2022 07:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232178AbiJXLyE (ORCPT ); Mon, 24 Oct 2022 07:54:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E71474BBD; Mon, 24 Oct 2022 04:45:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 237B5B81151; Mon, 24 Oct 2022 11:45:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72B60C433D6; Mon, 24 Oct 2022 11:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611922; bh=X/cIJmrKiiqRqx/BcVynhDgyBSUjjuc0ViUWGM72QBM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uBEgwsJeM657bkm5Zzllr7qcN4rgIZV8tLWGFAMJxAO4od/n8PAy/UyzNjL+9epy9 TR+eSS/cn64Zmzynj4dcM3M0y5sUcbcfMHm9Pt8AAm0if2KR7JGe9EPOyzgeWfgevQ wPhZt0UBvxbbg5X03GdvNBr95GBhSvXG0YvT5J24= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, sunghwan jung , Sasha Levin Subject: [PATCH 4.9 151/159] Revert "usb: storage: Add quirk for Samsung Fit flash" Date: Mon, 24 Oct 2022 13:31:45 +0200 Message-Id: <20221024112954.937926881@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112949.358278806@linuxfoundation.org> References: <20221024112949.358278806@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747570006834762027?= X-GMAIL-MSGID: =?utf-8?q?1747570006834762027?= From: sunghwan jung [ Upstream commit ad5dbfc123e6ffbbde194e2a4603323e09f741ee ] This reverts commit 86d92f5465958752481269348d474414dccb1552, which fix the timeout issue for "Samsung Fit Flash". But the commit affects not only "Samsung Fit Flash" but also other usb storages that use the same controller and causes severe performance regression. # hdparm -t /dev/sda (without the quirk) Timing buffered disk reads: 622 MB in 3.01 seconds = 206.66 MB/sec # hdparm -t /dev/sda (with the quirk) Timing buffered disk reads: 220 MB in 3.00 seconds = 73.32 MB/sec The commit author mentioned that "Issue was reproduced after device has bad block", so this quirk should be applied when we have the timeout issue with a device that has bad blocks. We revert the commit so that we apply this quirk by adding kernel paramters using a bootloader or other ways when we really need it, without the performance regression with devices that don't have the issue. Signed-off-by: sunghwan jung Link: https://lore.kernel.org/r/20220913114913.3073-1-onenowy@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/storage/unusual_devs.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index 5a6ca1460711..8c51bb66f16f 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h @@ -1294,12 +1294,6 @@ UNUSUAL_DEV( 0x090a, 0x1200, 0x0000, 0x9999, USB_SC_RBC, USB_PR_BULK, NULL, 0 ), -UNUSUAL_DEV(0x090c, 0x1000, 0x1100, 0x1100, - "Samsung", - "Flash Drive FIT", - USB_SC_DEVICE, USB_PR_DEVICE, NULL, - US_FL_MAX_SECTORS_64), - /* aeb */ UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff, "Feiya",