From patchwork Mon Oct 24 11:31:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9587 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp528596wru; Mon, 24 Oct 2022 09:02:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5WsraFuyRlS0vh0tRA6peTjDPBOkV8Ah22Jyy2o5MnZdWFq7CUFmYjI41NLLw2Ux+QSY2O X-Received: by 2002:a05:6a00:140d:b0:528:5a5a:d846 with SMTP id l13-20020a056a00140d00b005285a5ad846mr13180491pfu.9.1666627343358; Mon, 24 Oct 2022 09:02:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666627343; cv=none; d=google.com; s=arc-20160816; b=ATI2QlGRQskJ7td4DSEvlsTykDKjw9WmJjjYuI0ISxQMFFOEPqmRplJ+/iqi9l+HtT 6emsLdxxtzMTmXueUCsLpzsLBBOx/FPKJqdLZsQg8p6AQ/guZ4/9qolrPkj+SCl4ZtS9 zmwRjjsSuqkc5yJDARQEUBn/b/hmNzhA5tQT4ZsxBzzFJLhsuyhCVnU7dDxrhXb7X7q8 +ra1szqZANyqwUXOYm+O5WS0Uy0FFjx1gZ+P64qu9ORUcx/mHaQKYh6q0HyfzdQg5unQ JZrGodCTKL6BIbyvoBbQu9xqGqAEPMOXlJSCdzK2m3XFLoUmRC9d4HAZ2kjVEaEOHXAe fd8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4DZ2sXle55rsbx9Pvh5pboZ3RE4XNALU9zscxcnPiWE=; b=UnBkGx47Vvcnau2SXcnqH88lMOKbBUU/PjdlYCuiI37FiVEwdliVWF7sm4+iBfVPcy DuBcbfB0wxb/0wqX5bF5SJ4naTIPe81+DULt/Zf54SxVKC52nSnC6z5Hw/JURCgWco0d qMDwkDf3J6CgopefusyTm+3182CirJ6eZ5KF9BtUAdS0t8ZDLUyLrfr0gOC0bb6bWTmi 8eWt5cCfnK7j/wUMTe9gYWPEug+/OsoO5lQY9Hnh06Zt1/U9/QW3VeNYN1CPklJODOvP zZUwKvduw8JwhLWI+OT+Z75yLaCP4DSis7dGZYSjnMzJVXeZP3t1cIeHRPNoAtDqXRoH /8Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DIKO6Fwo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a170902d5cd00b0017889771a05si32362182plh.566.2022.10.24.09.02.05; Mon, 24 Oct 2022 09:02:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DIKO6Fwo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231249AbiJXQAc (ORCPT + 99 others); Mon, 24 Oct 2022 12:00:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232452AbiJXP7E (ORCPT ); Mon, 24 Oct 2022 11:59:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB9F0AA372; Mon, 24 Oct 2022 07:54:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BE072B8118D; Mon, 24 Oct 2022 11:44:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 235C1C433D6; Mon, 24 Oct 2022 11:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611883; bh=xnZ+hfZhsqsSL1RT5Zrzd/2FlzdEfr8WWwLO7c/CQn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DIKO6FwotRjLlj69GGN/WJilr2Hcuijz7q8n2F7fCEBuqPv6WwhBPSIGXDFeaAiJ5 K3ZpPHYVio2xjMBdYiJd3WgrHsKA2W4gMJtHu1xHNjHtBkg2aiUAgaL3u6PmKk9WDE cwp115k31j6VJW5sYlVfrxfCPuKMCXTjvkrdaqjo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Tony Lindgren , Stephen Boyd , Sasha Levin Subject: [PATCH 4.9 117/159] clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe Date: Mon, 24 Oct 2022 13:31:11 +0200 Message-Id: <20221024112953.765014334@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112949.358278806@linuxfoundation.org> References: <20221024112949.358278806@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747585433008133186?= X-GMAIL-MSGID: =?utf-8?q?1747585433008133186?= From: Miaoqian Lin [ Upstream commit 9c59a01caba26ec06fefd6ca1f22d5fd1de57d63 ] pm_runtime_get_sync() will increment pm usage counter. Forgetting to putting operation will result in reference leak. Add missing pm_runtime_put_sync in some error paths. Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220602030838.52057-1-linmq006@gmail.com Reviewed-by: Tony Lindgren Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/clk-dra7-atl.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c index 7d060ffe8975..9b1f9af35a23 100644 --- a/drivers/clk/ti/clk-dra7-atl.c +++ b/drivers/clk/ti/clk-dra7-atl.c @@ -249,14 +249,16 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) if (rc) { pr_err("%s: failed to lookup atl clock %d\n", __func__, i); - return -EINVAL; + ret = -EINVAL; + goto pm_put; } clk = of_clk_get_from_provider(&clkspec); if (IS_ERR(clk)) { pr_err("%s: failed to get atl clock %d from provider\n", __func__, i); - return PTR_ERR(clk); + ret = PTR_ERR(clk); + goto pm_put; } cdesc = to_atl_desc(__clk_get_hw(clk)); @@ -289,8 +291,9 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) if (cdesc->enabled) atl_clk_enable(__clk_get_hw(clk)); } - pm_runtime_put_sync(cinfo->dev); +pm_put: + pm_runtime_put_sync(cinfo->dev); return ret; }