From patchwork Mon Oct 24 11:31:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8459 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp402801wru; Mon, 24 Oct 2022 04:50:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Ix7UO/DvixWU7bHvPJC74pYPbejy5qxKt8Yy54u04TJ3FDbvLQ3JkxwPxfdqHg8Zx53QR X-Received: by 2002:a17:902:748c:b0:186:6a25:b6a8 with SMTP id h12-20020a170902748c00b001866a25b6a8mr20384862pll.40.1666612242069; Mon, 24 Oct 2022 04:50:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666612242; cv=none; d=google.com; s=arc-20160816; b=HXma2XgkhzNFWW54+ubbeEx9+SWTpVtl0KvA7Q6GZeAwIQFHr4iZOSXzeelZv9nNFQ DsXZCEmQaD/AL+RFdXK/hcXVEYyfnEsIi1oX/JjJ85BT9KZjj1w/rZEzSBQgU8o4YJEl m175nbkJ8sriR5x+EmhpHUsw7DLdgVEVyvSa7ifzYsopkgQDPQcoGFD+ZoVrCQVx+Q/D STHUdcEQwmnAUlFyNzhi9mWBRgfQVLUp/1D2AuKcZu4vv8didenVmFrT8mum2uuYc9Ib r/1em4p6/s3r5jgV935kxwc4FLP4eIEmQqN1h05npSxWdtX7s2o09+YZNyNz/7nqcdU8 kJww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RN18VPapSo4RmrEqRNTZ521hopPHnIc8DvOFkR4c/ao=; b=JhAY7LPAKSB+rec6t567TmvvuObt9GvAXGVqgH53Qj64J98Xhqp72W8JNzSQg2fPBJ IQm1PhaFAsiisdquoGGB+l1l0uOD/XbpVKWIFpbrnDgZUnpycreRaQzysjFCqM6y5dGE h6vWr43Uu/DgmkG6xso2mUihjVijeyJHngSXS7NasF+tDGr5Kx/Vs9hjE/3NdXw8ySsr Oh2J5COv3OOf0oTSmeWvATloP3pjdxtHyXCkrc4mmucsiJOxz0cTh5+sxAy+QMEpSN73 QfOAYfR1lOrEgBcIYw3jAElQGeJRbQc8lG7d7NjQkzXQGIiq42dDtYr4DIjBi7X3EOiS O0bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="P+t/zJBh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o29-20020a635a1d000000b0043f06af773dsi34923113pgb.33.2022.10.24.04.50.26; Mon, 24 Oct 2022 04:50:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="P+t/zJBh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231803AbiJXLuJ (ORCPT + 99 others); Mon, 24 Oct 2022 07:50:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231743AbiJXLsL (ORCPT ); Mon, 24 Oct 2022 07:48:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB33351414; Mon, 24 Oct 2022 04:43:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 386E3612B8; Mon, 24 Oct 2022 11:43:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D66EC433C1; Mon, 24 Oct 2022 11:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611791; bh=qyPKBhptZLK8DelWc0viy1Dy4e9UgeA6goOXR9m28iE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P+t/zJBhYbULSxjC3KA3tBWzKlxeHDrPfxkWmoqu3nV3uME3W/jXDfUt0UOQBlcBI m24NMl8ezZCZR7sUtK4Sp2JsAcq0GDhQ/zZy4lJ0evI03ZxKyTIPxlLlCCvFCkC28S QkmhbiSzQ/YPYYGtn/yxuveL0Y0aMSzRKlP/2gMo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , Hans de Goede , Lee Jones , Sasha Levin Subject: [PATCH 4.9 111/159] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Mon, 24 Oct 2022 13:31:05 +0200 Message-Id: <20221024112953.508551717@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112949.358278806@linuxfoundation.org> References: <20221024112949.358278806@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747569598292928077?= X-GMAIL-MSGID: =?utf-8?q?1747569598292928077?= From: Christophe JAILLET [ Upstream commit 48749cabba109397b4e7dd556e85718ec0ec114d ] The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220801114211.36267-1-andriy.shevchenko@linux.intel.com Signed-off-by: Sasha Levin --- drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 12d6ebb4ae5d..e233585645b9 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -118,6 +118,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; }