From patchwork Mon Oct 24 11:30:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8425 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp400637wru; Mon, 24 Oct 2022 04:47:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM64BKNO1FC5yJyktE0oVcLWf2QRyB8L3VyGmRctH8pDnMNqleeYeD150M/V6Oq7e5DOOKXQ X-Received: by 2002:a17:907:3e95:b0:792:e5b3:5a19 with SMTP id hs21-20020a1709073e9500b00792e5b35a19mr21850272ejc.766.1666612049388; Mon, 24 Oct 2022 04:47:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666612049; cv=none; d=google.com; s=arc-20160816; b=lV1z0StCiEXtSXF8Z3owMLE1Hz4uO3LSjFcFKR6IZ5Ww9PHnjCsUK/X9S4MiIkQmwj y6wKaJGXLCJJnClefDjNS5uaT135ZbyJThWSRq/IKaa/89ogTJI0VaTbIs2w1Fnp7epc D7RogtsTsyuRHoE33Fipe8YTIUY8An5Wn3A1Wy2ysLwPT82ueGnsRyBt5qlcgOL1jeqb YBgPL6NlZC5irN+G24ieKhvAYJLhUMZz0Bsv7DWmsavjTtPm5PbUG+6DfEFwYBcuT8CK 1TriIrTx/w+RV3SgEdSAA6X2akneKmMnC86MzbVJwZZSVGbxIBFqLm5FpGcu4oUHioS0 AYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2lXJZhxDEEs6hNAfSVssNZjVKsiVJyiu7y2GNyzAMSU=; b=kBaRLFEz6rb1EZ4usf+I+q24o3QEzZNh+uuR2NYbhKKZh5AO3dnXUAnwi22NMioQau ZGsDnvBqm+4QnfZQZvdAWKeaeGQWEDqHLqHZdH5EfbxDeGanS5q/IG8/knALX6Zt03hd Fkin+3VJIksQrypqXqlBNvL7/Hsr9PgWXFSg6NvWEkkOp2lhxGsqbW0GPpe9k9K+XRzw 7wODF9BluCxDqbV0J4bq32CDn16eDkNpFmyCtgrutXdcWcRxsfE+D8/CjzUV2sH9C88+ 69HtoIw8lzatNJHVhgR+w3BZbDhw9J2RHNUSZ6axkYeHJ7OJokFamRmI0e2HB+V4EkgA JM6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2iqDxJCc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc41-20020a1709078a2900b0078d027ceb41si31214731ejc.857.2022.10.24.04.47.06; Mon, 24 Oct 2022 04:47:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2iqDxJCc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231622AbiJXLqh (ORCPT + 99 others); Mon, 24 Oct 2022 07:46:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231820AbiJXLod (ORCPT ); Mon, 24 Oct 2022 07:44:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3972754A1; Mon, 24 Oct 2022 04:42:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F2E19B81188; Mon, 24 Oct 2022 11:41:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F4B4C433D6; Mon, 24 Oct 2022 11:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611681; bh=BsjeOKCEr2SWKzLt9qvyOm1BnV092tyoRVicBoSzI8Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2iqDxJCc0vCoROc7TUGMJ3smsgebGTDWCqj1LgS5vOUK4Vt7WNHpWjnQHRF6ig6MJ bwd8iwrclmG+xs6cVi06gOyfIr+yBriPMOYOSCkYJRZstnicBM6t1nqwu7M9+in7/c Svsgpikt1BfutEyZbC0+luPR/haAxnsEOUSvRr+w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bitterblue Smith , Kalle Valo , Sasha Levin Subject: [PATCH 4.9 070/159] wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration Date: Mon, 24 Oct 2022 13:30:24 +0200 Message-Id: <20221024112952.016351511@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112949.358278806@linuxfoundation.org> References: <20221024112949.358278806@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747569395953098132?= X-GMAIL-MSGID: =?utf-8?q?1747569395953098132?= From: Bitterblue Smith [ Upstream commit e963a19c64ac0d2f8785d36a27391abd91ac77aa ] Found by comparing with the vendor driver. Currently this affects only the RTL8192EU, which is the only gen2 chip with 2 TX paths supported by this driver. It's unclear what kind of effect the mistake had in practice, since I don't have any RTL8192EU devices to test it. Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts") Signed-off-by: Bitterblue Smith Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 31e9495bb479..6875ec7290bf 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -2930,12 +2930,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv, } if (!(simubitmap & 0x30) && priv->tx_paths > 1) { - /* path B RX OK */ + /* path B TX OK */ for (i = 4; i < 6; i++) result[3][i] = result[c1][i]; } - if (!(simubitmap & 0x30) && priv->tx_paths > 1) { + if (!(simubitmap & 0xc0) && priv->tx_paths > 1) { /* path B RX OK */ for (i = 6; i < 8; i++) result[3][i] = result[c1][i];