From patchwork Mon Oct 24 11:30:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8490 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp403787wru; Mon, 24 Oct 2022 04:53:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6vd2fd04JdAUp/2nn060f1hCNyy5PnpYPvkQQVw88kbPYsz0vLF6tYKKknou2RE1uM0wXY X-Received: by 2002:a63:6f8a:0:b0:439:36bc:89f9 with SMTP id k132-20020a636f8a000000b0043936bc89f9mr27480114pgc.100.1666612401004; Mon, 24 Oct 2022 04:53:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666612400; cv=none; d=google.com; s=arc-20160816; b=IEIxxElAZe8y61YVSoKaqbsSh6zByl2ArZQOeRSYwT08uhmGRC/8AFPYyb/5KXkagz sxIFl5qKGX9GBEmMFVi3KoFqhs3c4Hf/JN9tYGRecrx+DgAu+CYpML8BgJcN3zpTIGGs ICgU1hGBfqODXLeIZsJY43HLQzIz8ktnvOzPF8d95fIA78ynS6TzT8YkJEDoVCm2W9/r 3ZJQSYF/24S4dOEFMauOMjMB4QS+InpvW3QZz2ZdssBmjf06yPjEF6cxDQp2PMnE1KiT ctXwQKhqKJEJLpNJcTCQaWBMyuOLZLA47LK7wI2gXmwWgnvUalQpU4iy/YMSJJeVrve6 r00w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FkYr2WiLDxAHnuoN8q9oL5I7p3NnA29PH1II9qhlljo=; b=zVUG8pF1k0q80B6/up3/RQf1LH0y4L/4aHS8JJTgCe7DdFoclSl7vr9F/46SDqhNi5 jCnJuUilI2TdwHqtUp178rkD/W6dAORljTWKV7+5hzAx3p9it1CyAdPC0FKa7k7y8oOk tO9joHSdkTdMhWTPaQJi3MW4nIPCDxKfKxRm2+cIPVNvu6D/DU3F3M+7kp7hyoRb/EdI O3EjdsadqI2Om5A7FXIPIYd1iG+9riyuJazppo9X4dSGBjsAsgbB23XsfCglDEsJp7l4 O6xZkJGIcq1GNJ/ygK5mtuXZGm1VWC5apJ4unSqbbZzVZfE/uadDmoI+U4I4IrHF9k9i UKlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=avclhSTJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k14-20020a633d0e000000b00439d86cf509si39367819pga.645.2022.10.24.04.53.07; Mon, 24 Oct 2022 04:53:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=avclhSTJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231986AbiJXLwg (ORCPT + 99 others); Mon, 24 Oct 2022 07:52:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231983AbiJXLvn (ORCPT ); Mon, 24 Oct 2022 07:51:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A22D25DB; Mon, 24 Oct 2022 04:44:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F5F66127D; Mon, 24 Oct 2022 11:42:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CE4AC433D6; Mon, 24 Oct 2022 11:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611721; bh=gK9tBW5QGusxJXici9NHLyY1IzBuFwJKABTxygaS+yI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=avclhSTJTkr5wehxEju2JltpUsP9HWiS/S9QRkuGvgnnJwNJdqjaGpgD8ByhBwW7V 9TT6IvvKVHr01rWqPheF4ugAz8V0Eg2zTlwBwI4QzghwOzW7qShT0FkjTfbX51fiMV 242yFgmUbpG1LdA+ogLHruqVsZKwXSZcI0QMJniY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Baokun Li , Jan Kara , Theodore Tso Subject: [PATCH 4.9 056/159] ext4: fix null-ptr-deref in ext4_write_info Date: Mon, 24 Oct 2022 13:30:10 +0200 Message-Id: <20221024112951.478694189@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112949.358278806@linuxfoundation.org> References: <20221024112949.358278806@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747569765007171010?= X-GMAIL-MSGID: =?utf-8?q?1747569765007171010?= From: Baokun Li commit f9c1f248607d5546075d3f731e7607d5571f2b60 upstream. I caught a null-ptr-deref bug as follows: ================================================================== KASAN: null-ptr-deref in range [0x0000000000000068-0x000000000000006f] CPU: 1 PID: 1589 Comm: umount Not tainted 5.10.0-02219-dirty #339 RIP: 0010:ext4_write_info+0x53/0x1b0 [...] Call Trace: dquot_writeback_dquots+0x341/0x9a0 ext4_sync_fs+0x19e/0x800 __sync_filesystem+0x83/0x100 sync_filesystem+0x89/0xf0 generic_shutdown_super+0x79/0x3e0 kill_block_super+0xa1/0x110 deactivate_locked_super+0xac/0x130 deactivate_super+0xb6/0xd0 cleanup_mnt+0x289/0x400 __cleanup_mnt+0x16/0x20 task_work_run+0x11c/0x1c0 exit_to_user_mode_prepare+0x203/0x210 syscall_exit_to_user_mode+0x5b/0x3a0 do_syscall_64+0x59/0x70 entry_SYSCALL_64_after_hwframe+0x44/0xa9 ================================================================== Above issue may happen as follows: ------------------------------------- exit_to_user_mode_prepare task_work_run __cleanup_mnt cleanup_mnt deactivate_super deactivate_locked_super kill_block_super generic_shutdown_super shrink_dcache_for_umount dentry = sb->s_root sb->s_root = NULL <--- Here set NULL sync_filesystem __sync_filesystem sb->s_op->sync_fs > ext4_sync_fs dquot_writeback_dquots sb->dq_op->write_info > ext4_write_info ext4_journal_start(d_inode(sb->s_root), EXT4_HT_QUOTA, 2) d_inode(sb->s_root) s_root->d_inode <--- Null pointer dereference To solve this problem, we use ext4_journal_start_sb directly to avoid s_root being used. Cc: stable@kernel.org Signed-off-by: Baokun Li Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20220805123947.565152-1-libaokun1@huawei.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5381,7 +5381,7 @@ static int ext4_write_info(struct super_ handle_t *handle; /* Data block + inode block */ - handle = ext4_journal_start(d_inode(sb->s_root), EXT4_HT_QUOTA, 2); + handle = ext4_journal_start_sb(sb, EXT4_HT_QUOTA, 2); if (IS_ERR(handle)) return PTR_ERR(handle); ret = dquot_commit_info(sb, type);