From patchwork Mon Oct 24 11:29:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 8450 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp402319wru; Mon, 24 Oct 2022 04:49:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5gC6GlVX5JefJun2l2kuyfgYZiW5OLkfq2+chef2yx4MIrrE2e3F+YxAwbuXAaLF5tUBCi X-Received: by 2002:a63:874a:0:b0:46e:bcc0:c69d with SMTP id i71-20020a63874a000000b0046ebcc0c69dmr13571815pge.89.1666612193297; Mon, 24 Oct 2022 04:49:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666612193; cv=none; d=google.com; s=arc-20160816; b=GJfgp2eeTUGBUzRd03p3lG7DR3jkrWt8ETsSd0V013gqpRiVvYj8ubGi9wYoE6mekv TUB7+TZKxgy7i5aJzcKUd7aYRVBarHLGZ384fYWi72Dk2tWT1iNiFDFZIAKldcd5bMhQ gG8MyukF21G2DLg3oGYkjLksmyaPbxg5G/tpvZmKL83QHn8WfNkFf8wMtpDEEpc274yN P+ZerinylelGuCsuVbqXb8+QA6nk0ayRlR+xHkealcBuYMiWukboQGdpQdgnQbhkK3sk KHLNeW+s04L5PCfsUj5KIhy7Ua5E8pVjuvKX+QaWJ0fgmHVkPJ4c7e5vb04d2Zt8JzVs bD+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9TIF4x2/ptokehMJk5B4KkWUReXmT8fsdHwmXTxdKwk=; b=Ae2bg3ntPqBKUMSS54ekSRdnazaGVPCkVX9dHVgwJi8xLtfnhbrQvGAPONQvye3yxD BlfD0HEoPQ1d+Ki7FDjZmP8fWCRTLDB5NweYxnZjoWzn3goFpB+tGH+BDoCpd2119lWR 0rE/JgO9DXa9/ha6U34qywOwjGUPAvORryhSCS+iZ2JG1SHZDO5X/6DZAFgKCAGuo5e7 pjIRF9XhmQUOJUfHTuR6vrTFmpRDDlmL5ik0JF4sNX55ys8RBSiwhDR3RWNZQL3dAYJV dNY4csSIEznRV+xlwafi1bW1CvBcxpY7H4ZjSNdcr0GGaG5IzJvtJJ43DKsJ2nR2Pv/d /+Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cCBoLMbd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t6-20020a17090ad50600b0020ab20c54fesi8537478pju.114.2022.10.24.04.49.39; Mon, 24 Oct 2022 04:49:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cCBoLMbd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231761AbiJXLsc (ORCPT + 99 others); Mon, 24 Oct 2022 07:48:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231712AbiJXLrg (ORCPT ); Mon, 24 Oct 2022 07:47:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C762B1EACB; Mon, 24 Oct 2022 04:43:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E25AC6125A; Mon, 24 Oct 2022 11:39:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0B8AC43141; Mon, 24 Oct 2022 11:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611577; bh=csLkbOe7YV/S/rd9A47GzNYDSCRvmZ0xqZTGJscfmwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cCBoLMbdgzKVaosFN3BZtELfxM26wlNoeYeAFa9som4uN9TPxPjk5en6uL7b1fIV/ fXJc+bqXAC4+8rpfdBF9LYxE3eZVcu0jeW5LgZRmG9OoMmybRm5qi6yyt7z5ruowEo YDhT/c7i9JnCq2/4iD79l05gXOPQZcLo/tF+Mnrs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai , Hans de Goede Subject: [PATCH 4.9 032/159] ALSA: hda: Fix position reporting on Poulsbo Date: Mon, 24 Oct 2022 13:29:46 +0200 Message-Id: <20221024112950.578096067@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112949.358278806@linuxfoundation.org> References: <20221024112949.358278806@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747569547606457070?= X-GMAIL-MSGID: =?utf-8?q?1747569547606457070?= From: Takashi Iwai commit 56e696c0f0c71b77fff921fc94b58a02f0445b2c upstream. Hans reported that his Sony VAIO VPX11S1E showed the broken sound behavior at the start of the stream for a couple of seconds, and it turned out that the position_fix=1 option fixes the issue. It implies that the position reporting is inaccurate, and very likely hitting on all Poulsbo devices. The patch applies the workaround for Poulsbo generically to switch to LPIB mode instead of the default position buffer. Reported-and-tested-by: Hans de Goede Cc: Link: https://lore.kernel.org/r/3e8697e1-87c6-7a7b-d2e8-b21f1d2f181b@redhat.com Link: https://lore.kernel.org/r/20221001142124.7241-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2320,7 +2320,8 @@ static const struct pci_device_id azx_id .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_NOPM }, /* Poulsbo */ { PCI_DEVICE(0x8086, 0x811b), - .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE }, + .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE | + AZX_DCAPS_POSFIX_LPIB }, /* Oaktrail */ { PCI_DEVICE(0x8086, 0x080a), .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE },