From patchwork Mon Oct 24 11:29:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9639 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp532677wru; Mon, 24 Oct 2022 09:08:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Z6BG+M9J2TnC0tg/gJMHQqDsBzLhDlAgsOxJm93NMaJRUMostmm0Rl08xnWf7cRxG3KV1 X-Received: by 2002:a17:906:7314:b0:791:a45a:bc84 with SMTP id di20-20020a170906731400b00791a45abc84mr26792121ejc.394.1666627705419; Mon, 24 Oct 2022 09:08:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666627705; cv=none; d=google.com; s=arc-20160816; b=dW3ieUXG6LKKXoNGHL35kqSwVFGB42OhYM6jN4ZxpR0GOsxYtLjp3hrimodXsEQ17F b10jABo+pwlq88rPHYceLNS6/5+1CboMabwa47dbFhX8KncogJmvuH+1sNQEkni2b68O vGQV6xi5gWubWqInWIHfSJhLBrznNla2Dz80dHFCxhT2EypCpmaxwwLDBoBwmdYTTw36 9mYOjquQXNnKCcMMhX2RVdKxND2UkGbGRP2NWn/CK0J6nVMs6FeLE+kRxBIUrgKmBVIC TOsemfDtVnTlLiOBKLfRvDp12RKDWzVkKGjTBIERKSpreL5tRnhKGZYnH05m6wi3ky5h rzRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Sz1b6S2pVLCUqRoM12hcVgNtfau1RcxycjRWT1cik2M=; b=v8SQ1tM1JGe/IJ2XVnoOP+Kyv9gRjrlsbXCLrToyXYhde5uD/zS/QUeRX7YEU6SlfF MQ+aciqEAX6a2Ycb+EUbRr4LhWiLrj2ZsEqy/2vzBd88qjGUofrQ2PR+ILR3mmk6O8nM jDMVx0crcQ/pwr6U4zXveu+ym42vK7PJO1APIzjuL84NlIzxKheIxZLNJCJcbuJqMnVy GrbIIbjy6IZjo4/iXLjKJ2SUNQDdx00i714lkbVVi8jzzNzxd0MINJPIN7sMZ6HQv/+c XC8poPKfvCffERsCGKlAetVAwBOiz7iWlGcf1vRkUfpSFR29U6m0GT4VMJjP6HyMfojK VZSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p68hk6mj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rk20-20020a170907215400b0078d3b940ec5si134688ejb.373.2022.10.24.09.07.59; Mon, 24 Oct 2022 09:08:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p68hk6mj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232674AbiJXQHU (ORCPT + 99 others); Mon, 24 Oct 2022 12:07:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233170AbiJXQES (ORCPT ); Mon, 24 Oct 2022 12:04:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF96711D983; Mon, 24 Oct 2022 07:56:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 291C3B8114D; Mon, 24 Oct 2022 11:39:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8474AC433D6; Mon, 24 Oct 2022 11:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666611550; bh=Knoyj2ev+3EeXZB1JZ1QQ9InFBfJAJbjg7VhFi59HoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p68hk6mjYgufP0VS+B+7ek1HZ6yXFPLBD3hb4dyszigSbu6huv1ItI7CJVAASNbTM nkFw6b6jzJsYK5rWaAx2xUX+o17RHdioKk+heOlalVRBWDmbRuHdd7aBUiT+q62Rz4 mbcmXhbAhgxD3lQ7jWQZk74ULVxnUIZMj9RzEiQc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.9 009/159] Input: melfas_mip4 - fix return value check in mip4_probe() Date: Mon, 24 Oct 2022 13:29:23 +0200 Message-Id: <20221024112949.703648319@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112949.358278806@linuxfoundation.org> References: <20221024112949.358278806@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747585812847167057?= X-GMAIL-MSGID: =?utf-8?q?1747585812847167057?= From: Yang Yingliang [ Upstream commit a54dc27bd25f20ee3ea2009584b3166d25178243 ] devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER), add a minus sign to fix it. Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220924030715.1653538-1-yangyingliang@huawei.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/touchscreen/melfas_mip4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index 552a3773f79d..cec2df449f89 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -1416,7 +1416,7 @@ static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id) "ce", GPIOD_OUT_LOW); if (IS_ERR(ts->gpio_ce)) { error = PTR_ERR(ts->gpio_ce); - if (error != EPROBE_DEFER) + if (error != -EPROBE_DEFER) dev_err(&client->dev, "Failed to get gpio: %d\n", error); return error;