From patchwork Mon Oct 24 11:16:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 8349 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp386416wru; Mon, 24 Oct 2022 04:20:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4TVlfDJZaAazYrw00ici9a6K8i++muoqVZF22jmiWy+ur90WMs87wMOxhvqfAu9GK2N40u X-Received: by 2002:a05:6402:440f:b0:45d:297b:c70a with SMTP id y15-20020a056402440f00b0045d297bc70amr30427299eda.187.1666610444201; Mon, 24 Oct 2022 04:20:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666610444; cv=none; d=google.com; s=arc-20160816; b=Ulo5CSzP+qh8Nd3lUj91d+xmNvQDeCKktSb0x9VHxKsmqrPFN9Xq0fgMnEtHMYaf8q lQNH6iLH2TceW91EbrpyxcFoXaN96xocq1JKqUs53S5bUxzIljCTodLb5XlESHu3RHyi OCmsms0OMLXRHIyHEvXprFnl3g3YTSC3HzzdvZxqJxUtnGaE8X7zj186k9uWSvyYT/nf +bMTXrd/65nFz/cfrdaKVQxpAriczzKa3PxgZCLbDc8Ektn0j3OcCmlxsL3SDxJi765+ 3zjTxOOgenZWBJ4i0i4pIGjoYl9MwOGwGTrfRMHG6th2ycDzDj9QPywLtgCgGK8GHluM 8QPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ByUidQ+HVkzMHaKmgMlffJkBEgLLlkmot6oV+zDZQVA=; b=hvnCobsS+nAkgX24oBsTxIoCBhqIeCsUh6wKDOkowu/J+J4xd8/jFXq1nm/CpLSfau mr9e7sv6ghQEArAzqsdCi2YihVCFoCez6vs4+WKrlDDsQIL/7ig8vh29ct5TD2cYwwI/ ZnJNEYePeD5gyNg04/0l+uAzgkgLwtYQ5pOE7r1dQFchoBBSLaqaDhVnMYDgNw2wGPz9 MOozLXRohaG/QK4QYuswDfqI3I4y6SwD/Sn/lYkzeANPud+2owU0Jq5TVGnrMLTHSmAz V3QNRVb2zBFF7NObJAz9DtmvUfG/wRuZCLCW41RLTJIgtmpjvrBKXsVhjs2mU20MBNsS QIgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=T7sQbPBj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sg20-20020a170907a41400b0078db6f5f4b2si27814058ejc.546.2022.10.24.04.20.19; Mon, 24 Oct 2022 04:20:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=T7sQbPBj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbiJXLQG (ORCPT + 99 others); Mon, 24 Oct 2022 07:16:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbiJXLQD (ORCPT ); Mon, 24 Oct 2022 07:16:03 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 642015F11D for ; Mon, 24 Oct 2022 04:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666610162; x=1698146162; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=bjhqc5XhXHy+win/gLYj6TzJI0CmJ2ZsazUDU3tvEls=; b=T7sQbPBjw1rc6eBz5l/c5k1qM4+aHJqT6VAhpVvsBE5KXRs8OhpatH4O lHxJ1O7s74gudN/a+lA2D4s5l2dwMI+pJnvkmf3XXQNq92WatTprNongT UwAxRKi9+regCQyGN+UKr05s1Zzg14KtG2d0YD2L++gR4lK5AEV/2cAUw HSbhRJpti+DV/xl6AsIoCWRstRPRvcyVywJg4DHHgFPm79nBOLHgy3y/S /0QI8VEV4F5bmU2bFDzsJYoyx+pCrJp9AympWSdhD0GULGuRjdLsF/UF8 N0bXbX+30f7R0TdVdfQ+pDTB7zpVGskMngt9bPr8WQEmc+SIARsVleFbb A==; X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="309078117" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="309078117" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 04:16:01 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="582384741" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="582384741" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 04:16:00 -0700 Received: from punajuuri.localdomain (punajuuri.localdomain [192.168.240.130]) by paasikivi.fi.intel.com (Postfix) with ESMTP id 1D7C3201D5; Mon, 24 Oct 2022 14:15:58 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.94.2) (envelope-from ) id 1omvRT-000JZQ-AC; Mon, 24 Oct 2022 14:16:27 +0300 From: Sakari Ailus To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , "Rafael J. Wysocki" , David Laight Subject: [PATCH v2 1/1] linux/container_of.h: Warn about loss of constness Date: Mon, 24 Oct 2022 14:16:27 +0300 Message-Id: <20221024111627.75183-1-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747556862081691433?= X-GMAIL-MSGID: =?utf-8?q?1747567712751335300?= container_of() casts the original type to another which leads to the loss of the const qualifier if it is not specified in the caller-provided type. This easily leads to container_of() returning a non-const pointer to a const struct which the C compiler does not warn about. Signed-off-by: Sakari Ailus Acked-by: Andy Shevchenko --- include/linux/container_of.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/container_of.h b/include/linux/container_of.h index 2f4944b791b81..591db643269aa 100644 --- a/include/linux/container_of.h +++ b/include/linux/container_of.h @@ -13,6 +13,7 @@ * @type: the type of the container struct this is embedded in. * @member: the name of the member within the struct. * + * WARNING: any const qualifier of @ptr is lost. */ #define container_of(ptr, type, member) ({ \ void *__mptr = (void *)(ptr); \