From patchwork Mon Oct 24 10:44:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 8327 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp375992wru; Mon, 24 Oct 2022 03:57:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4i9kezifg186PGs3lNprpbVSWg4R02ErpTe95a3rMDi8W/sIGKOm0URcorDtyAguGCyt0/ X-Received: by 2002:a17:907:2d89:b0:78d:9c30:452b with SMTP id gt9-20020a1709072d8900b0078d9c30452bmr25544103ejc.533.1666609026015; Mon, 24 Oct 2022 03:57:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666609026; cv=none; d=google.com; s=arc-20160816; b=xhstNnTy0m1X/acQK8e4dIJhMf+kTqSoTpn1YI5zvSQRycNTQ0vOTLTyJJK8f3eu94 VpvmSj6/dy+S0ZuFSHkNyN2z0aTbB5e4jzfYh9/+LOl0k9nX0yFsYcw7LmWKhMZPxoq1 eJODw9lykzKcsV9zcgM8cKlpE4f/XmjCOQ11bIbg+JSr1YH7+1OM/tEBZVtzO7g/lZZX 0VapdZ/kc5+A+2U6YW+NP7J4Ehx5I0hgq4DAa07Yf5MDaU2rR7+c2bghv6QUjASFNjBV EE2ZIC0H4DuQ2oqyOALPwYXAkeeT5QlSh6IFVupdbdUmsdEqOSJah+liSt7RcEUmIbVB uimQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ewd7YIr3/bEdlcKC7v2uy0s+SHWdjFr5K1Yi5NyIu0o=; b=eHpNQK1cRy9vc4QvAvQ7adh0B6pTysqkrdMNZWjLT6nYo5fBxDmkz9kLy0zKY7aGOh CSxNvjnl03eFmWS7JndXoPhP7nasmJVcCEEJ+dUiH51ItZAGcCo9hS1paaPrWHrLcCO2 o9kEVa90Nfz0ToCoVKBsrmcBzVtteY9KvgFv5Y1OFfKkwkGwmM60yqMwddRI8kmdrLaM Syc/mprhVEv+r3shjuERmbo9eCOONTfclkRFYdMtaUppgNLYs4T34aDUgKTvqu6oOP66 0nECKRhzNHQ6TrDstVPIdD7YxEP7x+QaDfKm9UtKcmduBLtT5T+Z3Dixs91I3IHhj+3A 2TMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@monom.org header.s=dkim header.b=C4+RmTg5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=monom.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020aa7dc09000000b00456964d3369si23478283edu.230.2022.10.24.03.56.42; Mon, 24 Oct 2022 03:57:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@monom.org header.s=dkim header.b=C4+RmTg5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=monom.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230085AbiJXKzb (ORCPT + 99 others); Mon, 24 Oct 2022 06:55:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbiJXKy6 (ORCPT ); Mon, 24 Oct 2022 06:54:58 -0400 Received: from mail.nearlyone.de (mail.nearlyone.de [46.163.114.145]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C78D13F0E; Mon, 24 Oct 2022 03:54:38 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9CD8E61D7D; Mon, 24 Oct 2022 12:44:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monom.org; s=dkim; t=1666608272; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=Ewd7YIr3/bEdlcKC7v2uy0s+SHWdjFr5K1Yi5NyIu0o=; b=C4+RmTg5hzIEjuwHdWs8SjfZlMU3wo4WAXs4hFa2XAeFvu7j/5Ex526Dr8JBA/Rpd8240j Lvl25pbIOnbMYiQ5Q63Zn9n+AiEZNa8+hsqjOdes0N1hWylcOuqwZqclS7EoN9ydqC1XCE C71lqELBsDMUJrw5ZSB8NzDLSXqMCnEuaGiCzQU+lFylRPG5OBNSQKEYHaDfJ8Ni2Nfirs sfim8pizNBl+Hcuy1Nz4M+DraDhnpArs/5hMlNI5ZejIYJqtdLdTW1CBuIXthe1cp1LycB FeVnF3jK7IQeCZiETOlo/kkfmj+S7+V+oiDu1bqT2W0G1/OU3CpgdiWN02iWiw== From: Daniel Wagner To: LKML , linux-rt-users , Steven Rostedt , Thomas Gleixner , Carsten Emde , John Kacur , Sebastian Andrzej Siewior , Tom Zanussi , Clark Williams , Pavel Machek Cc: Daniel Wagner Subject: [PATCH RT 5/9] timers: Keep interrupts disabled for TIMER_IRQSAFE timer. Date: Mon, 24 Oct 2022 12:44:21 +0200 Message-Id: <20221024104425.16423-6-wagi@monom.org> In-Reply-To: <20221024104425.16423-1-wagi@monom.org> References: <20221024104425.16423-1-wagi@monom.org> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747566225942749226?= X-GMAIL-MSGID: =?utf-8?q?1747566225942749226?= From: Sebastian Andrzej Siewior v4.19.255-rt114-rc1 stable review patch. If anyone has any objections, please let me know. ----------- Keep interrupts disabled across callback invocation for the TIMER_IRQSAFE as expected. This is required for the timer used by workqueue after the upcomming rework. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Daniel Wagner --- kernel/time/timer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index a2be2277506d..3e2c0bd03004 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -1397,8 +1397,7 @@ static void expire_timers(struct timer_base *base, struct hlist_head *head) fn = timer->function; - if (!IS_ENABLED(CONFIG_PREEMPT_RT_FULL) && - timer->flags & TIMER_IRQSAFE) { + if (timer->flags & TIMER_IRQSAFE) { raw_spin_unlock(&base->lock); call_timer_fn(timer, fn); base->running_timer = NULL;